From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54432)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eSKux-0001Q5-Sp
	for guix-patches@gnu.org; Fri, 22 Dec 2017 05:51:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eSKus-0003zH-4S
	for guix-patches@gnu.org; Fri, 22 Dec 2017 05:51:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:38228)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eSKus-0003z2-10
	for guix-patches@gnu.org; Fri, 22 Dec 2017 05:51:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eSKur-00064z-NJ
	for guix-patches@gnu.org; Fri, 22 Dec 2017 05:51:01 -0500
Subject: [bug#29409] Remove hugetlb control group on ARM32.
Resent-Message-ID: <handler.29409.B29409.151393984523341@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <877euhtjkj.fsf@gmail.com> <87ind19pok.fsf@gmail.com>
	<20171221095752.1a018320@scratchpost.org> <87tvwk3wpk.fsf@gnu.org>
	<87vagzb3kn.fsf@gmail.com>
Date: Fri, 22 Dec 2017 11:50:40 +0100
In-Reply-To: <87vagzb3kn.fsf@gmail.com> (Mathieu Othacehe's message of "Fri,
	22 Dec 2017 08:54:16 +0100")
Message-ID: <87wp1f829r.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 29409@debbugs.gnu.org

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> From a531af25b3cffeb70e5681ef70ced564378f2db7 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Fri, 22 Dec 2017 08:42:29 +0100
> Subject: [PATCH 1/2] file-systems: Do not mount hugetlb cgroup filesystem.
>
> On ARM32 without LPAE support, hugetlb control group is not supported.
> As it is not needed by elogind, remove it for all platforms.
>
> * gnu/system/file-systems.scm (%control-groups): Remove hugetlb from cont=
rol
>   groups platforms.

LGTM, but please make sure that a gnu/system/examples/desktop.tmpl or
similar still works in a VM.

> From 4a28602843a661989c687086af009481dab05eed Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe@gmail.com>
> Date: Fri, 22 Dec 2017 08:43:24 +0100
> Subject: [PATCH 2/2] file-systems: Move %control-groups from
>  %base-file-systems to %elogind-file-systems.
>
> * gnu/system/file-systems.scm (%base-file-systems): Move %control-groups =
from
> here, to ...
> (%elogind-file-systems): ... here.

LGTM, but please double-check that =E2=80=9Cmake check-system TESTS=3Dbasic=
=E2=80=9D and
bare-bones.tmpl or install.scm (which do not use elogind) still work as
expected.

Thanks!

Ludo=E2=80=99.