From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33134)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYs0l-0002YE-Pd
	for guix-patches@gnu.org; Tue, 09 Jan 2018 06:24:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYs0g-00071k-Ko
	for guix-patches@gnu.org; Tue, 09 Jan 2018 06:24:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:33469)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eYs0g-00071X-Gb
	for guix-patches@gnu.org; Tue, 09 Jan 2018 06:24:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eYs0g-0003Yx-5T
	for guix-patches@gnu.org; Tue, 09 Jan 2018 06:24:02 -0500
Subject: [bug#29880] [PATCH] gnu: grep: Add PCRE support.
Resent-Message-ID: <handler.29880.B29880.151549701113652@debbugs.gnu.org>
References: <87mv22u0eq.fsf@gmail.com> <87mv1ok9ab.fsf@gnu.org>
	<87lgh8iabe.fsf@gnu.org> <87bmi3xvhb.fsf@gnu.org>
From: Roel Janssen <roel@gnu.org>
In-reply-to: <87bmi3xvhb.fsf@gnu.org>
Date: Tue, 09 Jan 2018 12:23:09 +0100
Message-ID: <87wp0ri8de.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 29880@debbugs.gnu.org


Ludovic Courtès writes:

> Hello,
>
> Roel Janssen <roel@gnu.org> skribis:
>
>> I have been maintaining a separate package for grep with PCRE support
>> for the users on our cluster.  What I would like to add is that at least
>> Debian and RedHat enable PCRE in their grep versions.  So using Guix's
>> grep broke some scripts.
>>
>> If compatibility with other GNU/Linux distributions counts for anything,
>> I'd say we should enable it.  I am in favor of enabling PCRE.
>
> OK, that makes sense.
>
>> We could provide a separate version of grep without PCRE as a
>> grep-minimal.
>
> Alternately, what we could do is:
>
>   1. Keep ‘grep-final’ as it is right now (without PCRE support; this
>      has never been a problem so far.)
>
>   2. Add PCRE to ‘grep’ itself (like Oleg did).
>
> Thoughts?

Yes that seems fine to me.

Kind regards,
Roel Janssen