From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er5i2-0002dN-Jz for guix-patches@gnu.org; Wed, 28 Feb 2018 12:40:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1er5hz-0004we-FA for guix-patches@gnu.org; Wed, 28 Feb 2018 12:40:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58109) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1er5hz-0004w8-9C for guix-patches@gnu.org; Wed, 28 Feb 2018 12:40:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1er5hy-00040x-7n for guix-patches@gnu.org; Wed, 28 Feb 2018 12:40:02 -0500 Subject: [bug#28004] Chromium Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180226234144.032af030@alma-ubu> References: <87shensfq6.fsf@gnu.org> <87o9p45bb6.fsf@fastmail.com> <20180104191648.custe7w3l57fvbac@abyayala> <87wp0s2ewl.fsf@fastmail.com> <20180108232042.nqjurjr2bcfl2yyc@abyayala> <87373cey5b.fsf@fastmail.com> <87vag16g5z.fsf@gnu.org> <87fu75aar5.fsf@fastmail.com> <874lnkr0vf.fsf@gnu.org> <87vaejvclc.fsf@fastmail.com> <20180226200133.zsnahblbgzovrtmu@abyayala> <87muzvv7ku.fsf@fastmail.com> <20180226234144.032af030@alma-ubu> Date: Wed, 28 Feb 2018 18:38:56 +0100 Message-ID: <87woyxt3nz.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Cc: 28004@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bj=C3=B6rn H=C3=B6fling writes: > Hi Marius, > > On Mon, 26 Feb 2018 21:06:57 +0100 > Marius Bakke wrote: > >> ng0 writes: >>=20 >> > Marius Bakke transcribed 2.1K bytes:=20=20 >> >> Mike Gerwitz writes: >> >>=20=20=20 >> >> > On Tue, Jan 16, 2018 at 20:01:34 +0100, Marius Bakke wrote:=20=20 >> >> >> If there are no objections, expect to see this in 'master' in >> >> >> 1-2 weeks.=20=20 >> >> > >> >> > I want to express gratitude for your hard work on this---given >> >> > that IceCat does not contain many of the FF devtool updates, >> >> > Chromium is very desirable for web development. It's also >> >> > needed for certain Node.js tools, like node-inspector. >> >> > >> >> > So, thank you!=20=20 >> >>=20 >> >> Thank *you* for the kind words! :-) >> >>=20 >> >> Here is the latest iteration of this patch. New in this version: >> >>=20 >> >> * Chromium 64 (duh). >> >> * The 'delete-bundled-software' phase has been moved to a snippet, >> >> shaving ~100MiB (~22%) off the compressed tarball size (and >> >> drastically reduces (de)compression time). >> >> * The New Tab page does not show any thumbnails for new profiles.=20= =20 >> > >> > I think you forgot to attach the patches :)=20=20 >>=20 >> Derp. I realized that and just used `git send-email`[0], but have >> attached it here for convenience since the debbugs web UI doesn't >> allow easy download of a raw message. >>=20 >> [0] https://debbugs.gnu.org/cgi/bugreport.cgi?msg=3D131;bug=3D28004#131 >>=20 > > > This looks like a lot of work. Thank you! > > I quickly tried to apply and build the patch and have two first remarks: > > The file says: > > ;;; Copyright =C2=A9 2016, 2017, 2018 Marius Bakke > > I haven't followed history, have you worked on this since 2016? Yeah, I started this shortly after going full-GuixSD in October 2016. But I didn't submit it until now because I didn't think it met Guix's standards (and still think it's questionable due to privacy concerns). > One patch has a hash-mismatch: > > Starting download of /gnu/store/q8hlws48cjfcmz6i40jrnxn3kp750gy4-chromium= -icu.patch > From https://anonscm.debian.org/cgit/pkg-chromium/pkg-chromium.git/plain/= debian/patches/system/icu.patch?id=3Ddebian/64.0.3282.119-2... > icu.patch 2KiB 1.8MiB/s 00:00 [####################]= 100.0% > output path `/gnu/store/q8hlws48cjfcmz6i40jrnxn3kp750gy4-chromium-icu.pat= ch' should have sha256 hash `0kf77d8lyma3w0xpgfv2k0c741zp6ii08gzllfja6d5s59= c15ylv', instead has `19r0bpv2hapzq5m0m7rlz1dwn3h2ijgkilb2hmhw56qvwpbw0b59' > @ build-failed /gnu/store/cqdllqn8ig5wnjn0yqvnh4vlzsvnpzv6-chromium-icu.p= atch.drv - 1 output path `/gnu/store/q8hlws48cjfcmz6i40jrnxn3kp750gy4-chrom= ium-icu.patch' should have sha256 hash `0kf77d8lyma3w0xpgfv2k0c741zp6ii08gz= llfja6d5s59c15ylv', instead has `19r0bpv2hapzq5m0m7rlz1dwn3h2ijgkilb2hmhw56= qvwpbw0b59' > cannot build derivation `/gnu/store/vacxbwsprcp52vp6q975450zi091dak2-chro= mium-64.0.3282.186.tar.xz.drv': 1 dependencies couldn't be built > @ build-started /gnu/store/7q53inn1v32b5fain0h0wcrliclf0ff1-libvpx+experi= mental-1.7.0.drv - x86_64-linux /var/log/guix/drvs/7q//53inn1v32b5fain0h0wc= rliclf0ff1-libvpx+experimental-1.7.0.drv.bz2 > cannot build derivation `/gnu/store/5qv7anaaqk4576pma9mhcsz1nhrx1n01-chro= mium-64.0.3282.186.drv': 1 dependencies couldn't be built > guix build: error: build failed: build of `/gnu/store/5qv7anaaqk4576pma9m= hcsz1nhrx1n01-chromium-64.0.3282.186.drv' failed > > I looked into the file and it looks reasonable, like a patch-file. It has= no download errors. > > It starts like this: > > description: backwards compatibility for older versions of icu > author: Michael Gilbert > > --- a/v8/src/runtime/runtime-intl.cc > +++ b/v8/src/runtime/runtime-intl.cc > @@ -627,7 +627,11 @@ RUNTIME_FUNCTION(Runtime_PluralRulesSele > > ... > > Can you check this file again? Whoops, indeed. I had an older patch in my store and apparently forgot to update the hash. The correct hash for %chromium-system-icu.patch is: 19r0bpv2hapzq5m0m7rlz1dwn3h2ijgkilb2hmhw56qvwpbw0b59 Thanks for letting me know! I'll send an updated patch later, with some other minor improvements. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqW6TAACgkQoqBt8qM6 VPrVOQgAmxdpWrvUsJjBCD8ISMJ3fs5nDZt3/jDfiwj2glLjCjGvqjqytxhOYkXM CeeuO1Um8gb270ePmBAnY02dRL2Qx8oF6ORcw4xS7rh5MyJJzfbYk4pjx8MvvrI4 L4mV6piCMYj85BsYkud+9ni7P+HKoTaExve5DEImmz5ZiU5QkleJKoRspugIydQn ExEekgSvG7kOsNY1NyQw3CE2CYToFrKyLsaWWYvkGzh7hkie/9x9Z/kMfK6HSqoq 5twX9XKHn2g9I+V1IXTIRua16TVy8qsbNtxEqcNXpFu9emrEbC7l5OFyKAXV0+yV GEDEs14P/WnvwhFFADdNfTxI1JevNg== =UrxJ -----END PGP SIGNATURE----- --=-=-=--