Björn Höfling writes: > Hi Marius, > > On Mon, 26 Feb 2018 21:06:57 +0100 > Marius Bakke wrote: > >> ng0 writes: >> >> > Marius Bakke transcribed 2.1K bytes: >> >> Mike Gerwitz writes: >> >> >> >> > On Tue, Jan 16, 2018 at 20:01:34 +0100, Marius Bakke wrote: >> >> >> If there are no objections, expect to see this in 'master' in >> >> >> 1-2 weeks. >> >> > >> >> > I want to express gratitude for your hard work on this---given >> >> > that IceCat does not contain many of the FF devtool updates, >> >> > Chromium is very desirable for web development. It's also >> >> > needed for certain Node.js tools, like node-inspector. >> >> > >> >> > So, thank you! >> >> >> >> Thank *you* for the kind words! :-) >> >> >> >> Here is the latest iteration of this patch. New in this version: >> >> >> >> * Chromium 64 (duh). >> >> * The 'delete-bundled-software' phase has been moved to a snippet, >> >> shaving ~100MiB (~22%) off the compressed tarball size (and >> >> drastically reduces (de)compression time). >> >> * The New Tab page does not show any thumbnails for new profiles. >> > >> > I think you forgot to attach the patches :) >> >> Derp. I realized that and just used `git send-email`[0], but have >> attached it here for convenience since the debbugs web UI doesn't >> allow easy download of a raw message. >> >> [0] https://debbugs.gnu.org/cgi/bugreport.cgi?msg=131;bug=28004#131 >> > > > This looks like a lot of work. Thank you! > > I quickly tried to apply and build the patch and have two first remarks: > > The file says: > > ;;; Copyright © 2016, 2017, 2018 Marius Bakke > > I haven't followed history, have you worked on this since 2016? Yeah, I started this shortly after going full-GuixSD in October 2016. But I didn't submit it until now because I didn't think it met Guix's standards (and still think it's questionable due to privacy concerns). > One patch has a hash-mismatch: > > Starting download of /gnu/store/q8hlws48cjfcmz6i40jrnxn3kp750gy4-chromium-icu.patch > From https://anonscm.debian.org/cgit/pkg-chromium/pkg-chromium.git/plain/debian/patches/system/icu.patch?id=debian/64.0.3282.119-2... > icu.patch 2KiB 1.8MiB/s 00:00 [####################] 100.0% > output path `/gnu/store/q8hlws48cjfcmz6i40jrnxn3kp750gy4-chromium-icu.patch' should have sha256 hash `0kf77d8lyma3w0xpgfv2k0c741zp6ii08gzllfja6d5s59c15ylv', instead has `19r0bpv2hapzq5m0m7rlz1dwn3h2ijgkilb2hmhw56qvwpbw0b59' > @ build-failed /gnu/store/cqdllqn8ig5wnjn0yqvnh4vlzsvnpzv6-chromium-icu.patch.drv - 1 output path `/gnu/store/q8hlws48cjfcmz6i40jrnxn3kp750gy4-chromium-icu.patch' should have sha256 hash `0kf77d8lyma3w0xpgfv2k0c741zp6ii08gzllfja6d5s59c15ylv', instead has `19r0bpv2hapzq5m0m7rlz1dwn3h2ijgkilb2hmhw56qvwpbw0b59' > cannot build derivation `/gnu/store/vacxbwsprcp52vp6q975450zi091dak2-chromium-64.0.3282.186.tar.xz.drv': 1 dependencies couldn't be built > @ build-started /gnu/store/7q53inn1v32b5fain0h0wcrliclf0ff1-libvpx+experimental-1.7.0.drv - x86_64-linux /var/log/guix/drvs/7q//53inn1v32b5fain0h0wcrliclf0ff1-libvpx+experimental-1.7.0.drv.bz2 > cannot build derivation `/gnu/store/5qv7anaaqk4576pma9mhcsz1nhrx1n01-chromium-64.0.3282.186.drv': 1 dependencies couldn't be built > guix build: error: build failed: build of `/gnu/store/5qv7anaaqk4576pma9mhcsz1nhrx1n01-chromium-64.0.3282.186.drv' failed > > I looked into the file and it looks reasonable, like a patch-file. It has no download errors. > > It starts like this: > > description: backwards compatibility for older versions of icu > author: Michael Gilbert > > --- a/v8/src/runtime/runtime-intl.cc > +++ b/v8/src/runtime/runtime-intl.cc > @@ -627,7 +627,11 @@ RUNTIME_FUNCTION(Runtime_PluralRulesSele > > ... > > Can you check this file again? Whoops, indeed. I had an older patch in my store and apparently forgot to update the hash. The correct hash for %chromium-system-icu.patch is: 19r0bpv2hapzq5m0m7rlz1dwn3h2ijgkilb2hmhw56qvwpbw0b59 Thanks for letting me know! I'll send an updated patch later, with some other minor improvements.