From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evNCM-0004a4-WF for guix-patches@gnu.org; Mon, 12 Mar 2018 09:09:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evNCH-0007Sc-Vi for guix-patches@gnu.org; Mon, 12 Mar 2018 09:09:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evNCH-0007SG-Ri for guix-patches@gnu.org; Mon, 12 Mar 2018 09:09:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evNCH-0005jI-La for guix-patches@gnu.org; Mon, 12 Mar 2018 09:09:01 -0400 Subject: [bug#30761] [PATCH staging 1/9] gnu: meson: Don't wrap the meson executable. Resent-Message-ID: From: Marius Bakke In-Reply-To: <876061jw9o.fsf@fastmail.com> References: <20180309180914.22752-1-mbakke@fastmail.com> <20180309181108.22888-1-mbakke@fastmail.com> <87vae2tfxy.fsf@gnu.org> <876061jw9o.fsf@fastmail.com> Date: Mon, 12 Mar 2018 14:08:29 +0100 Message-ID: <87woyhigqa.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30761@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Ludovic Court=C3=A8s writes: > >> Hello! >> >> Marius Bakke skribis: >> >>> * gnu/packages/build-tools.scm (meson)[arguments]: Delete WRAP-PHASE. >>> --- >>> gnu/packages/build-tools.scm | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm >>> index 2abb44fdb..1ebccca43 100644 >>> --- a/gnu/packages/build-tools.scm >>> +++ b/gnu/packages/build-tools.scm >>> @@ -81,6 +81,11 @@ makes a few sacrifices to acquire fast full and incr= emental build times.") >>> (base32 >>> "06r8limj38mv884s5riiz6lpzw37cvhbf9jd0smzcbi7fwmv3yah"= )))) >>> (build-system python-build-system) >>> + (arguments >>> + `(#:phases (modify-phases %standard-phases >>> + ;; Meson runs itself through the Python interpreter,= so >>> + ;; we cannot use the shell wrapper. >>> + (delete 'wrap)))) >> >> I=E2=80=99m not sure what this means. The =E2=80=98wrap=E2=80=99 phase = is precisely for things >> with #!/=E2=80=A6/python, right? >> >> What problem does it solve? > > The problem is that at some point after 0.42 (the current > meson-for-build), Meson does the equivalent of `python $(which meson)` > at runtime. Which ends up tripping over the shell wrapper. > > I don't remember exactly where I saw the problem, it could have been > with "mesontest" which also resides in "meson/bin". The only downside > to deleting the wrapper is that you cannot call meson directly from the > store; it works fine as long as PYTHONPATH is set (e.g. in a profile). Actually, I just checked; "meson" in master does not work at all, whether from the store or from a profile: $ guix environment --ad-hoc meson -- meson --help Traceback (most recent call last): File "/gnu/store/lv22yqqnwaz7zjacmgqi8v18d9manr0y-meson-0.44.0/bin/.meson= -real", line 17, in from mesonbuild import mesonmain, mesonlib File "/gnu/store/lv22yqqnwaz7zjacmgqi8v18d9manr0y-meson-0.44.0/lib/python= 3.6/site-packages/mesonbuild/mesonmain.py", line 18, in from . import environment, interpreter, mesonlib File "/gnu/store/lv22yqqnwaz7zjacmgqi8v18d9manr0y-meson-0.44.0/lib/python= 3.6/site-packages/mesonbuild/environment.py", line 17, in from . import coredata File "/gnu/store/lv22yqqnwaz7zjacmgqi8v18d9manr0y-meson-0.44.0/lib/python= 3.6/site-packages/mesonbuild/coredata.py", line 20, in from .mesonlib import MesonException, commonpath File "/gnu/store/lv22yqqnwaz7zjacmgqi8v18d9manr0y-meson-0.44.0/lib/python= 3.6/site-packages/mesonbuild/mesonlib.py", line 60, in meson_command =3D python_command + [detect_meson_py_location()] File "/gnu/store/lv22yqqnwaz7zjacmgqi8v18d9manr0y-meson-0.44.0/lib/python= 3.6/site-packages/mesonbuild/mesonlib.py", line 51, in detect_meson_py_loca= tion raise RuntimeError('Could not determine how to run Meson. Please file a= bug with details.') RuntimeError: Could not determine how to run Meson. Please file a bug with = details. So we really need to drop the wrapper. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqme80ACgkQoqBt8qM6 VPqhIwf/VLFQBdNKOD6D2vClkaeYyeTK/Pr9tXfw4xYTluZsWMSWXVobG13sk1VX K3/sup82bHBZ3ITL42N5UrW8HE88u1IYZMxx79iz9+YYRYLkHsf9tVFeJuKPKOrA 6pg5BbuqOwL1TB8f/GmJgWBRpd/HlgmQ27C1KHF0MKSTaZtCtN65X9ypP3iESe5I IXVAR9XL2KZEWhU9vSBXTMzPgvGLLOoReMpP07XIiPGffrEqDwofc/842SJvCHdG 9m0vtl7wrCpnYGWYjUeJzh0Yr1UyCmlSeVCmsJlK8gXsQrFIQ/wOlMz74ZdHzKIv NchmJ4jIBuLgCoOgM9SVYQju9ymRNA== =qPDs -----END PGP SIGNATURE----- --=-=-=--