From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35029)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fK8b9-0004qz-27
	for guix-patches@gnu.org; Sat, 19 May 2018 16:37:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fK8b8-0002WZ-6l
	for guix-patches@gnu.org; Sat, 19 May 2018 16:37:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:33470)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fK8b8-0002WT-29
	for guix-patches@gnu.org; Sat, 19 May 2018 16:37:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fK8b7-0000l5-S0
	for guix-patches@gnu.org; Sat, 19 May 2018 16:37:01 -0400
Subject: [bug#30702] [PATCH] services: nginx: Support extra content in the
	http block.
Resent-Message-ID: <handler.30702.B30702.15267621962874@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87h8pel6q6.fsf@gnu.org> <20180518085422.15849-1-mail@cbaines.net>
Date: Sat, 19 May 2018 22:36:26 +0200
In-Reply-To: <20180518085422.15849-1-mail@cbaines.net> (Christopher Baines's
	message of "Fri, 18 May 2018 09:54:22 +0100")
Message-ID: <87wovzo01h.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 30702@debbugs.gnu.org

Hello,

Christopher Baines <mail@cbaines.net> skribis:

> This helpful when adding content to the nginx configuration file, which i=
sn't
> supported by the record type used for the configuration.  For example, li=
ke
> adding proxy_cache_path configuration.
>
> * gnu/packages/web.scm (<nginx-configuration>): Add new extra-content fie=
ld.
>   (nginx-configuration-extra-content): New field accessor.
>   (default-nginx-config): Add support for the extra-content field.
> * doc/guix.texi (NGINX): Document the new extra-content field.

[...]

> +@item @code{extra-content} (default: @code{""})
> +Extra content for the @code{http} block.  Should be string or a string
> +valued G-expression.

[...]

>     (apply mixed-text-file "nginx.conf"
>            (flatten
>             "user nginx nginx;\n"
> @@ -542,7 +546,8 @@ of index files."
>             "\n"
>             (map emit-nginx-upstream-config upstream-blocks)
>             (map emit-nginx-server-config server-blocks)
> -           "}\n"
> +           extra-content
> +           "\n}\n"
>             "events {}\n"))))

That doesn=E2=80=99t work if =E2=80=98extra-content=E2=80=99 is something l=
ike:

  #~(string-append "foo" bar)

does it?

My understanding of the doc above was that it intends to allow this.
But maybe it doesn=E2=80=99t matter after all?

Thanks,
Ludo=E2=80=99.