From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLSal-0005Rd-Rn for guix-patches@gnu.org; Wed, 23 May 2018 08:10:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLSag-0005Zk-37 for guix-patches@gnu.org; Wed, 23 May 2018 08:10:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:36977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fLSaf-0005Ze-W2 for guix-patches@gnu.org; Wed, 23 May 2018 08:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fLSaf-0004nS-P8 for guix-patches@gnu.org; Wed, 23 May 2018 08:10:01 -0400 Subject: [bug#31430] [PATCH 0/3] gnu: Add xtensor and its dependencies. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: Date: Wed, 23 May 2018 14:09:07 +0200 In-Reply-To: (Fis Trivial's message of "Sat, 12 May 2018 14:21:45 +0000") Message-ID: <87wovuzi8s.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Fis Trivial Cc: 31430@debbugs.gnu.org Hello, Fis Trivial skribis: > One of the variables that is added by these patches is > `json-modern-cxx`. It's not a real name. The full name of this package > should be "JSON for Modern C++", which is registered in the json > website[1]. On the other hand, it's repo's name is just "json". > > I think this package should not occupy the name "json", and a package > name "json-for-modern-c++" feels weird and long, so I renamed it as > "json-modern-cxx". I believe there is a better choice, but wording is > just not my thing. Tell me about your idea and I will make the > corresponding changes. That makes sense to me! > * gnu/packages/cpp.scm (json-modern-cxx): New variable. [...] > +(define-public json-modern-cxx > + ;; The downloaded tar ball is about 109 MiB large, the most significan= t part > + ;; comes from testing data file. > + (package > + (name "json-modern-cxx") > + (version "3.1.2") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://github.com/nlohmann/json/archive/v" > + version ".tar.gz")) > + (sha256 > + (base32 > + "0m5fhdpx2qll933db2nsi30nns3cifavzvijzz6mxhdkpmngmzz8")) > + (file-name (string-append name "-" version ".tar.gz")))) > + (home-page "https://github.com/nlohmann/json") > + (build-system cmake-build-system) > + (synopsis "JSON for Modern C++") What about something like: =E2=80=9CJSON parser and printer library for C++= =E2=80=9D? Another issue: the tarball contains a few bundled dependencies under thirdparty/: amalgate, Catch, Fuzzer, etc. Could you look into =E2=80=9Cunbundling=E2=80=9D these? Ideally you would add the missing package definitions (if any), add them as inputs, and add a snippet that (delete-file-recursively "thirdparty"). If it turns out to be trickier than expected, let us know as well. :-) TIA! Ludo=E2=80=99.