From: "Clément Lassieur" <clement@lassieur.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: Cuirass changes
Date: Wed, 11 Jul 2018 16:55:13 +0200 [thread overview]
Message-ID: <87wou1vn3i.fsf@lassieur.org> (raw)
In-Reply-To: <874lh6nkwd.fsf@gnu.org>
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
>> 1. Adding support for multiple inputs. Currently Cuirass only supports
>> one input per specification, which has to be the Guix git repository.
>> But one might want inputs for:
>> - a repository containing the 'proc' that returns the jobs,
>> - a repository containing extra packages (GUIX_PACKAGE_PATH).
>> Those inputs would be fetched at INTERVAL as well, and any change would
>> trigger an evaluation. This is a follow-up of
>> https://lists.gnu.org/archive/html/guix-patches/2018-06/msg00311.html.
>
> Excellent. I think the polling interval should be per input, while
> we’re at it.
Indeed, but that would complicate things. Would it make sense to do it
in another commit?
>> 3. Allowing any input to be in Guile's %load-path when 'proc' is called.
>> Usually, the only input that is in Guile's %load-path is Guix. But
>> someone might want to use a custom library in 'proc'. The alternative
>> is to just specify the Guix input that should be appended to Guile's
>> %load-path.
>>
>> (I'm unsure about 3., I can't find any real use case. That would just
>> make it more flexible I guess.)
>
> We can also wait until there’s a real use case, it’s often a good idea.
> :-)
I finally opted for a flexible %load-path. I think it also makes the
structure of the specification more transparent and understandable: it's
very clear that the input will be used as the load path, it's less
magical. But if you object I'd happily change it.
>> I'm sending this email because even though the patches are already done
>> and they work on my Cuirass instance, there are a few other things to do
>> before I can send them:
>> - add a mechanism to update the database,
>> - update the documentation.
>> So if you think I'm not on the right track, please let me know as soon
>> as possible :-)
>
> Looks like you’re on the right track. You submitted changes to
> guix-patches in the meantime so I’ll take a look at these.
Cool! Thank you :-)
Clément
next prev parent reply other threads:[~2018-07-11 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 18:01 Cuirass changes Clément Lassieur
2018-07-11 10:09 ` Ludovic Courtès
2018-07-11 12:17 ` Ricardo Wurmus
2018-07-11 14:24 ` Clément Lassieur
2018-07-11 14:55 ` Clément Lassieur [this message]
2018-07-11 17:19 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wou1vn3i.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.