Re: Guile-JSON now seems to be a required dependency

[Joshua Branson <jbranso@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

Timothy Sample <samplet@ngyro.com> writes:

> Hi Eric,
>
> Eric Bavier <ericbavier@centurylink.net> writes:
>
>> On Fri, 30 Nov 2018 23:45:04 -0500
>> Timothy Sample <samplet@ngyro.com> wrote:
>>
>>> Hello all,
>>>
>>> I just tried to build Guix from source and got an error:
>>>
>>>     ERROR: no code for module (json)
>>>
>>> It looks like the new “swh.scm” module (which is really cool!) makes
>>> Guile-JSON a required dependency.  I’m not sure if this is intentional.
>>> If it is, the “Requirements” section of the manual needs an update.
>>
>> Yes, we decided to make it a hard requirement.  I'm working on a patch
>> to follow through.

I believe I created such a patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: guile-json --]
[-- Type: text/x-patch, Size: 1565 bytes --]

From 2d860d1889b6c4bafe3d605ee47f9c93c3e91091 Mon Sep 17 00:00:00 2001
From: Joshua Branson <jbranso@fastmail.com>
Date: Sat, 1 Dec 2018 08:36:20 -0500
Subject: [PATCH] Adding guile-json as a required dependency for swh.scm. I
 also alphabetized the requirements.

---
 doc/guix.texi | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index fff5dfe0b..e651c3617 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -643,15 +643,17 @@ later, including 2.2.x;
 @item @url{https://notabug.org/cwebber/guile-gcrypt, Guile-Gcrypt}, version
 0.1.0 or later;
 @item
-@uref{http://gnutls.org/, GnuTLS}, specifically its Guile bindings
-(@pxref{Guile Preparations, how to install the GnuTLS bindings for
-Guile,, gnutls-guile, GnuTLS-Guile});
+@c FIXME: Specify a version number once a release has been made.
+@uref{https://gitlab.com/guile-git/guile-git, Guile-Git}, from August
+@item @url{https://github.com/aconchillo/guile-json, Guile-JSON}, version
+1.2.0 or later;
 @item
 @uref{https://notabug.org/guile-sqlite3/guile-sqlite3, Guile-SQLite3}, version 0.1.0
 or later;
 @item
-@c FIXME: Specify a version number once a release has been made.
-@uref{https://gitlab.com/guile-git/guile-git, Guile-Git}, from August
+@uref{http://gnutls.org/, GnuTLS}, specifically its Guile bindings
+(@pxref{Guile Preparations, how to install the GnuTLS bindings for
+Guile,, gnutls-guile, GnuTLS-Guile});
 2017 or later;
 @item @url{http://zlib.net, zlib};
 @item @url{http://www.gnu.org/software/make/, GNU Make}.
-- 
2.19.2


[-- Attachment #3: Type: text/plain, Size: 97 bytes --]



>
> That’s good to know.  Thanks very much for your work.  :)
>
>> `~Eric
>
> -- Tim