From: Timothy Sample <samplet@ngyro.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 33922@debbugs.gnu.org
Subject: bug#33922: failing git-annex build
Date: Tue, 15 Jan 2019 13:48:05 -0500 [thread overview]
Message-ID: <87won5u596.fsf@ngyro.com> (raw)
In-Reply-To: <87bm53gs9w.fsf@elephly.net>
Hi again,
Timothy Sample <samplet@ngyro.com> writes:
> Ricardo Wurmus <rekado@elephly.net> writes:
>>
>> [...]
>>
>> The most appropriate line to modify would then be this:
>>
>> confs = map (path </>) $ filter (".conf" `isSuffixOf`) fs
>>
>> where “fs” is the list of FilePath values (strings). I think you can
>> just do this:
>>
>> confs = map (path </>) $ filter (".conf" `isSuffixOf`) (sort fs)
>>
>> because “fs” is of type [FilePath], which is [String], which is sortable
>> via “sort” as String has an Ord instance.
>>
>> What do you think?
>
> I thought about this approach, but I was worried it wouldn’t be so easy.
> What you suggest looks pretty straight-forward though. I will test
> everything with this approach and report back. If it works, I agree
> that it is better.
The results are in and this seems to do the trick, too. I built GHC and
the packages I mentioned before on two different machines, and
everything came out identical. Hence, LGTM.
-- Tim
next prev parent reply other threads:[~2019-01-15 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-30 2:19 failing git-annex build Kyle Meyer
2018-12-30 11:36 ` bug#33922: " Ricardo Wurmus
2018-12-30 15:46 ` Kyle Meyer
2019-01-02 22:14 ` bug#33922: " Timothy Sample
2019-01-05 20:12 ` Kyle Meyer
2019-01-12 7:42 ` Ricardo Wurmus
2019-01-12 15:54 ` Timothy Sample
2019-01-15 18:48 ` Timothy Sample [this message]
2019-01-17 17:33 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87won5u596.fsf@ngyro.com \
--to=samplet@ngyro.com \
--cc=33922@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.