From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:32781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gn50Q-0006xb-UO for guix-patches@gnu.org; Fri, 25 Jan 2019 12:11:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gn50Q-00031q-9t for guix-patches@gnu.org; Fri, 25 Jan 2019 12:11:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46224) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gn50Q-00031b-69 for guix-patches@gnu.org; Fri, 25 Jan 2019 12:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gn50P-0000nh-Ud for guix-patches@gnu.org; Fri, 25 Jan 2019 12:11:01 -0500 Subject: [bug#34086] [PATCH] Add StepMania Resent-Message-ID: From: Nicolas Goaziou References: <875zuprduu.fsf@nicolasgoaziou.fr> <87o98bnquh.fsf@gnu.org> <871s55gkhv.fsf@nicolasgoaziou.fr> <20190122192442.GE25842@jasmine.lan> <87muns1i8t.fsf@nicolasgoaziou.fr> <87fttjiueo.fsf@gnu.org> Date: Fri, 25 Jan 2019 18:10:33 +0100 In-Reply-To: <87fttjiueo.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 23 Jan 2019 10:40:31 +0100") Message-ID: <87womsy86u.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34086@debbugs.gnu.org Hello, Ludovic Court=C3=A8s writes: > Nicolas Goaziou skribis: > >> +(define-public ffmpeg-for-stepmania >> + (hidden-package >> + (inherit ffmpeg) >> + (version "2.1.3") > > I=E2=80=99m pretty sure this doesn=E2=80=99t evaluate, does it? :-) Indeed. Fixed. > Should be: > > (hidden-package > (package > (inherit ffmpeg) > =E2=80=A6)) > > Apart from that, could you please add the explanation and/or a link to > an upstream discussion summarizing what you described regarding this > choice of a custom FFMpeg variant? Done. > OK with this changes! Pushed. Thank you! Regards, --=20 Nicolas Goaziou