From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:58051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwa63-0005dU-GJ
	for guix-patches@gnu.org; Wed, 20 Feb 2019 17:12:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwa61-0003TG-DE
	for guix-patches@gnu.org; Wed, 20 Feb 2019 17:12:07 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57947)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gwa5y-0003SP-OC
	for guix-patches@gnu.org; Wed, 20 Feb 2019 17:12:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gwa5y-0001u4-HP
	for guix-patches@gnu.org; Wed, 20 Feb 2019 17:12:02 -0500
Subject: [bug#34514] [PATCH 12/34] gnu: Add ruby-with-advisory-lock.
Resent-Message-ID: <handler.34514.B34514.15507006937267@debbugs.gnu.org>
References: <87sgwm44a9.fsf@cbaines.net>
	<20190217192314.5666-1-mail@cbaines.net>
	<20190217192314.5666-12-mail@cbaines.net>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20190217192314.5666-12-mail@cbaines.net>
Date: Wed, 20 Feb 2019 23:11:12 +0100
Message-ID: <87wolu3ybj.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 34514@debbugs.gnu.org


Christopher Baines <mail@cbaines.net> writes:

> * gnu/packages/rails.scm (ruby-with-advisory-lock): New variable.
[=E2=80=A6]
> +    (description
> +     "Adds advisory locking to ActiveRecord for PostgreSQL and MySQL.  S=
QLite
> +is also supported, but this uses the filesystem for locks.")

Please use full sentences here.

> +    (home-page "http://closuretree.github.io/with_advisory_lock/")

You can use HTTPS here.

Otherwise LGTM, thanks!

--=20
Ricardo