From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:51624)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjJ9U-0001Is-OC
 for guix-patches@gnu.org; Fri, 05 Jul 2019 04:01:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjJ9S-0001yq-Ba
 for guix-patches@gnu.org; Fri, 05 Jul 2019 04:01:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43481)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hjJ9S-0001yj-7w
 for guix-patches@gnu.org; Fri, 05 Jul 2019 04:01:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjJ9S-0003jG-5R
 for guix-patches@gnu.org; Fri, 05 Jul 2019 04:01:02 -0400
Subject: [bug#36404] [PATCH 0/6] Add 'guix deploy'.
Resent-Message-ID: <handler.36404.B36404.156231363114290@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87o92ianbj.fsf@sdf.lonestar.org> <87o92glap5.fsf@dustycloud.org>
 <878sthoqzi.fsf@gnu.org> <87r2799tzd.fsf@sdf.lonestar.org>
 <87d0isrsmk.fsf@sdf.lonestar.org> <878std3fw0.fsf@sdf.lonestar.org>
Date: Fri, 05 Jul 2019 10:00:03 +0200
In-Reply-To: <878std3fw0.fsf@sdf.lonestar.org> (Jakob L. Kreuze's message of
 "Thu, 04 Jul 2019 12:48:15 -0400")
Message-ID: <87wogwoqrg.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "Jakob L. Kreuze" <zerodaysfordays@sdf.lonestar.org>
Cc: 36404@debbugs.gnu.org

Hi Jakob,

zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:

> Something hit me today. There aren't any tests for 'guix system
> reconfigure'. There are for 'guix system init' in
> 'gnu/tests/install.scm', but not for 'guix system reconfigure', which
> makes me think that I'm going about testing this the wrong way. I feel I
> should begin by isolate the behavior that's common between 'guix system
> reconfigure' and 'guix deploy' as you suggested, and then writing tests
> for that common code in the system test suite.

That would be great, especially factorizing these bits.

Note that writing tests could be tricky because it=E2=80=99s about testing =
the
effect of these reconfigure actions.  At any rate, let us know how it
goes!

> Then, as Ricardo suggested, mocking can be used for the parts that are
> specific only to 'guix deploy'.

Sounds good.

Thank you!

Ludo=E2=80=99.