From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:38576)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iD7Po-0006iL-03
 for guix-patches@gnu.org; Wed, 25 Sep 2019 09:33:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iD7Pi-0004W2-PK
 for guix-patches@gnu.org; Wed, 25 Sep 2019 09:33:07 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:60480)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iD7Pi-0004Vv-Le
 for guix-patches@gnu.org; Wed, 25 Sep 2019 09:33:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iD7Pi-0003s5-HX
 for guix-patches@gnu.org; Wed, 25 Sep 2019 09:33:02 -0400
Subject: [bug#37465] add xftwidth displayed textwidth calculator package
Resent-Message-ID: <handler.37465.B37465.156941836414852@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <4e2e655c245cfc810b0faaf4c63b8fd99b384269.camel@gmail.com>
Date: Wed, 25 Sep 2019 15:32:32 +0200
In-Reply-To: <4e2e655c245cfc810b0faaf4c63b8fd99b384269.camel@gmail.com> (Kyle
 Andrews's message of "Thu, 19 Sep 2019 20:25:42 -0400")
Message-ID: <87wodwlcwf.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kyle Andrews <kyle.c.andrews@gmail.com>
Cc: 37465@debbugs.gnu.org

Hello Kyle,

Kyle Andrews <kyle.c.andrews@gmail.com> skribis:

> From 60deaa526b4a6ca5a66f3b67ba77aa353409d542 Mon Sep 17 00:00:00 2001
> From: Kyle Andrews <kyle.c.andrews@gmail.com>
> Date: Thu, 19 Sep 2019 20:16:28 -0400
> Subject: [PATCH] gnu: Add xftwidth.
>
> * gnu/packages/wm.scm: added xftwidth package.

I think this should rather go to xdisorg.scm, WDYT?

> +    (build-system gnu-build-system)
> +    (inputs `(("freetype"    ,freetype)
> +              ("libx11"      ,libx11)
> +              ("fontconfig"  ,fontconfig)
> +              ("libxft"      ,libxft)))

Nitpicking: we don=E2=80=99t usually align input tuples like that.  :-)

> +    (synopsis "Calculator for determining displayed text widths using Xf=
t fonts.")
> +    (description "A small C program to calculate pixel widths for displa=
yed
> +text using Xft fonts (given a specific font name and size). It is ideal =
for
> +scripts including text into the custom (e.g. dzen and xmobar based) pane=
ls
> +often used in conjunction with minimalistic window managers.")

Could you address the warnings reported by =E2=80=98guix lint=E2=80=99 here=
?  Also, make
sure to write full sentences in the description:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

The rest LGTM!  Could you send an updated patch?

Thanks,
Ludo=E2=80=99.