all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Kyle Andrews <kyle.c.andrews@gmail.com>
Cc: 37465@debbugs.gnu.org
Subject: [bug#37465] add xftwidth displayed textwidth calculator package
Date: Wed, 25 Sep 2019 15:32:32 +0200	[thread overview]
Message-ID: <87wodwlcwf.fsf@gnu.org> (raw)
In-Reply-To: <4e2e655c245cfc810b0faaf4c63b8fd99b384269.camel@gmail.com> (Kyle Andrews's message of "Thu, 19 Sep 2019 20:25:42 -0400")

Hello Kyle,

Kyle Andrews <kyle.c.andrews@gmail.com> skribis:

> From 60deaa526b4a6ca5a66f3b67ba77aa353409d542 Mon Sep 17 00:00:00 2001
> From: Kyle Andrews <kyle.c.andrews@gmail.com>
> Date: Thu, 19 Sep 2019 20:16:28 -0400
> Subject: [PATCH] gnu: Add xftwidth.
>
> * gnu/packages/wm.scm: added xftwidth package.

I think this should rather go to xdisorg.scm, WDYT?

> +    (build-system gnu-build-system)
> +    (inputs `(("freetype"    ,freetype)
> +              ("libx11"      ,libx11)
> +              ("fontconfig"  ,fontconfig)
> +              ("libxft"      ,libxft)))

Nitpicking: we don’t usually align input tuples like that.  :-)

> +    (synopsis "Calculator for determining displayed text widths using Xft fonts.")
> +    (description "A small C program to calculate pixel widths for displayed
> +text using Xft fonts (given a specific font name and size). It is ideal for
> +scripts including text into the custom (e.g. dzen and xmobar based) panels
> +often used in conjunction with minimalistic window managers.")

Could you address the warnings reported by ‘guix lint’ here?  Also, make
sure to write full sentences in the description:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

The rest LGTM!  Could you send an updated patch?

Thanks,
Ludo’.

  reply	other threads:[~2019-09-25 13:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20  0:25 [bug#37465] add xftwidth displayed textwidth calculator package Kyle Andrews
2019-09-25 13:32 ` Ludovic Courtès [this message]
2019-09-29 14:24   ` Kyle Andrews
2019-09-29 15:32     ` Tobias Geerinckx-Rice via Guix-patches via
2019-09-29 19:46     ` bug#37465: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wodwlcwf.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=37465@debbugs.gnu.org \
    --cc=kyle.c.andrews@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.