From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37841) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG2Oh-0002ge-MG for guix-patches@gnu.org; Thu, 03 Oct 2019 10:48:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iG2Og-0000Wo-Hi for guix-patches@gnu.org; Thu, 03 Oct 2019 10:48:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iG2Og-0000We-6a for guix-patches@gnu.org; Thu, 03 Oct 2019 10:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iG2Og-0008UW-2i for guix-patches@gnu.org; Thu, 03 Oct 2019 10:48:02 -0400 Subject: [bug#37603] [PATCH] gnu: Add aha. Resent-Message-ID: References: <20191003141529.3940-1-wz@freeshell.de> In-reply-to: <20191003141529.3940-1-wz@freeshell.de> Date: Thu, 03 Oct 2019 16:47:07 +0200 Message-ID: <87wodl51jo.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: Wiktor =?UTF-8?Q?=C5=BBelazny?= Cc: 37603@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Wiktor, Thanks for the patch! This isn't a review, just an answer to your=20 question: Wiktor =C5=BBelazny =E5=86=99=E9=81=93=EF=BC=9A > Hi, This is the first time that I=E2=80=99m submitting something that=20 > uses the > git-fetch method. I tried to follow the manual. Unfortunately,=20 > it does > not explain the role of this "0.9" string. I noticed that other > contributors use various values. I left it at "0.9". It's not a random value; it's the last =E2=80=98real=E2=80=99 release, thin= k of it=20 as =E2=80=98release 0.9 + some more commits that were needed for some=20 reason=E2=80=99. If the project has never seen a release, =E2=80=980.0.0= =E2=80=99 is=20 used. You'll find that this is quite common, too. At https://github.com/theZiz/aha/releases, we can see that the=20 last release before this commit was =E2=80=980.5=E2=80=99, so that's what y= ou=20 should use. However: we prefer packaging releases, not arbitrary commits. Why=20 not package 0.5? If it's because it's old (it is) and missing=20 cool features, consider asking the author to cut a new release. Whatever the case, please note the reason in a comment: =E2=80=98The last=20 release 0.5 is missing the vital foo feature and/or crashes on=20 Fridays=E2=80=99. Since I'm here (still not a review! :-): > + (revision "1")) ;Guix package revision I know you probably copied this from elsewhere, but don't think=20 this comment adds anything. > + (url "git://github.com/theZiz/aha.git") Please use https:// instead of git://. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl2WCesACgkQ2Imw8BjF STyjSQ/+MtkPQ6hJN21N4lwpr3CAgp0V2aR9hZL2VLSUPhsUsLdWyf22qCROAiV9 lodqm219qc0ATd+SAkC4EA0W6p8w+QecSP8C/PhklvjVChx3SyvguEENl1z0Y25E oAiAWteURK2iKggwlHbJCMgOHpf8ok12IOEToOM+q5PNtfy57spqMG0IQox0ZZJq YkDByqP+wLzY0cde71+Ajoj980FwMh1gr4HzyyWjoKrMOSDC3ya1apm/8f9PvEEc KaPbw3XJwEIAbULVNms3lITshV2Sh7GjmV9JJu6Q8Xp8THlzFqw7gnJgHOE5MQNn PZD4Tyet5r8YoaktBb0tbM8sli+0Ff9jwIkwJjt0lmsLydAJvUlKrdj03w4r6aCw vuURIqQvbi+VhlSBtINTkns4I2ANi5Qi0Xcltp7puduADRdzROUT3MQvxOjAQkLs vNBeqhvw7VmW3RepKAUjvF2fpeedXw8hOwhZ89uGNVlJxyDPAb8RDFPj68iTnLgL QA6zCCBsG3Jc977R+NRaUiYe2hPOMiinGOnBwpDGWSu1d+qWd47FG/APlyl27oAK vd34fVlO7yr5K4LhS0hQrZbozip8YRyqOvKY7StPw6ih/LrAuEpO4rke516SSqAF LaJ7hGoXJqSROozPOsCacWLT3kKQZoDHfCAlOn9tzszVKNrmNsE= =U5Lu -----END PGP SIGNATURE----- --=-=-=--