Remarks about commit 2c82d4ad10de8

[Mathieu Othacehe <m.othacehe@gmail.com>]

Hello Brett,

I have a few remarks on the aforementioned commit.

> +       (list (string-append "-DCMAKE_CXX_FLAGS='-isystem "
> +                            (assoc-ref %build-inputs "gcc")
> +                            "/include/c++'"))))

Why is this needed? The following snippet in clang-from-llvm isn't enough?

--8<---------------cut here---------------start------------->8---
;; Make clang look for libstdc++ in the right
;; location.
(("LibStdCXXIncludePathCandidates\\[\\] = \\{")
 (string-append
  "LibStdCXXIncludePathCandidates[] = { \"" gcc "/include/c++\","))
--8<---------------cut here---------------end--------------->8---

> +     (inputs
>       `(("clang" ,clang)
> -       ("llvm" ,llvm)))
> +       ("ncurses" ,ncurses)))
> +    (native-inputs
> +     `(("rapidjson" ,rapidjson)

Rapidjson is an input (even if ccls is not linked against because its a
header-only library).

> +       ("gcc" ,gcc)))

This shouldn't be needed as it is an implicit input.

Thanks,

Mathieu