From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:55634)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1igtE3-0003qy-IY
 for guix-patches@gnu.org; Mon, 16 Dec 2019 11:28:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1igtE2-0004w8-9Y
 for guix-patches@gnu.org; Mon, 16 Dec 2019 11:28:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:34341)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1igtE2-0004vG-1k
 for guix-patches@gnu.org; Mon, 16 Dec 2019 11:28:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1igtE1-0004Iu-Nn
 for guix-patches@gnu.org; Mon, 16 Dec 2019 11:28:01 -0500
Subject: [bug#38637] [PATCH 1/4] gnu: Add python-iocapture.
Resent-Message-ID: <handler.38637.B38637.157651367916536@debbugs.gnu.org>
References: <326bca30-7d18-a02b-9400-2f12bc0e5c21@mdc-berlin.de>
 <20191216152519.3595-1-madalinionel.patrascu@mdc-berlin.de>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20191216152519.3595-1-madalinionel.patrascu@mdc-berlin.de>
Date: Mon, 16 Dec 2019 17:27:50 +0100
Message-ID: <87woawb5h5.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= <madalinionel.patrascu@mdc-berlin.de>
Cc: 38637@debbugs.gnu.org


Hi M=C4=83d=C4=83lin,

> * gnu/packages/python-xyz.scm (python-iocapture): New variable.

thanks for the patch!

> +(define-public python-iocapture
> +  ;; the latest is more than year newer than the latest realease

I know what you mean but that=E2=80=99s not what the comment says ;)  I
changed it.

> +  (let ((commit "fdc021c431d0840303908dfc3ca8769db383595c")
> +        (revision "1"))
> +    (package
> +     (name "python-iocapture")
> +     (version "0.1.2")
> +     (source
> +      (origin
> +       (method git-fetch)
> +       (uri (git-reference (url "https://github.com/oinume/iocapture.git=
")
> +                           (commit commit)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1mkbhqibxvgwg0p7slr8dfraa3g2s6bsayladhax2jccwj4kcndz"))))
> +     (build-system python-build-system)
> +     (propagated-inputs
> +      `(("python-flexmock" ,python-flexmock)
> +        ("python-pytest" ,python-pytest)
> +        ("python-pytest-cov" ,python-pytest-cov)
> +        ("python-six" ,python-six)))
> +     (home-page "https://github.com/oinume/iocapture")
> +     (synopsis "Phython capuring tool for stdout and stderr")

Typos: Phython =E2=80=93> Python; capuring =E2=80=93> capturing

> +     (description
> +      "python-iocapture helps you to capture the standard out (stdout) a=
nd the
> +standard error channel (stderr) in your program.")
> +     (license license:expat)))) ; MIT license

The term =E2=80=9CMIT license=E2=80=9D is ambiguous, so we don=E2=80=99t us=
e it, not even in a
comment.

I noticed that the tests were not actually run, so I overrode the check
phase.

I pushed this with modifications to the =E2=80=9Cmaster=E2=80=9D branch wit=
h commit
dbcef44a0b.

Thanks again!

--
Ricardo