all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: "Mădălin Ionel Patrașcu" <madalinionel.patrascu@mdc-berlin.de>
Cc: 38637@debbugs.gnu.org
Subject: [bug#38637] [PATCH 1/4] gnu: Add python-iocapture.
Date: Mon, 16 Dec 2019 17:27:50 +0100	[thread overview]
Message-ID: <87woawb5h5.fsf@elephly.net> (raw)
In-Reply-To: <20191216152519.3595-1-madalinionel.patrascu@mdc-berlin.de>


Hi Mădălin,

> * gnu/packages/python-xyz.scm (python-iocapture): New variable.

thanks for the patch!

> +(define-public python-iocapture
> +  ;; the latest is more than year newer than the latest realease

I know what you mean but that’s not what the comment says ;)  I
changed it.

> +  (let ((commit "fdc021c431d0840303908dfc3ca8769db383595c")
> +        (revision "1"))
> +    (package
> +     (name "python-iocapture")
> +     (version "0.1.2")
> +     (source
> +      (origin
> +       (method git-fetch)
> +       (uri (git-reference (url "https://github.com/oinume/iocapture.git")
> +                           (commit commit)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1mkbhqibxvgwg0p7slr8dfraa3g2s6bsayladhax2jccwj4kcndz"))))
> +     (build-system python-build-system)
> +     (propagated-inputs
> +      `(("python-flexmock" ,python-flexmock)
> +        ("python-pytest" ,python-pytest)
> +        ("python-pytest-cov" ,python-pytest-cov)
> +        ("python-six" ,python-six)))
> +     (home-page "https://github.com/oinume/iocapture")
> +     (synopsis "Phython capuring tool for stdout and stderr")

Typos: Phython –> Python; capuring –> capturing

> +     (description
> +      "python-iocapture helps you to capture the standard out (stdout) and the
> +standard error channel (stderr) in your program.")
> +     (license license:expat)))) ; MIT license

The term “MIT license” is ambiguous, so we don’t use it, not even in a
comment.

I noticed that the tests were not actually run, so I overrode the check
phase.

I pushed this with modifications to the “master” branch with commit
dbcef44a0b.

Thanks again!

--
Ricardo

      parent reply	other threads:[~2019-12-16 16:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 15:23 [bug#38637] (no subject) mpatras
2019-12-16 15:25 ` [bug#38637] [PATCH 1/4] gnu: Add python-iocapture Mădălin Ionel Patrașcu
2019-12-16 15:25   ` [bug#38637] [PATCH 2/4] gnu: Add python-argh Mădălin Ionel Patrașcu
2019-12-16 16:31     ` Ricardo Wurmus
2019-12-16 15:25   ` [bug#38637] [PATCH 3/4] gnu: python-pyfaidx: Update to 0.5.7 Mădălin Ionel Patrașcu
2019-12-16 22:26     ` Ricardo Wurmus
2019-12-16 15:25   ` [bug#38637] [PATCH 4/4] gnu: Add python-gffutils Mădălin Ionel Patrașcu
2019-12-16 22:33     ` bug#38637: " Ricardo Wurmus
2019-12-16 16:27   ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87woawb5h5.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=38637@debbugs.gnu.org \
    --cc=madalinionel.patrascu@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.