From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: bug#39551: [PATCH v2] Cannot declare an NFS mount using the record Date: Wed, 12 Feb 2020 14:13:42 -0500 Message-ID: <87wo8r1uvt.fsf_-_@gmail.com> References: <87pnem2ps1.fsf@gmail.com> <87d0akfao2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:59371) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1xSV-0000S9-EO for bug-guix@gnu.org; Wed, 12 Feb 2020 14:14:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1xSU-0002UP-87 for bug-guix@gnu.org; Wed, 12 Feb 2020 14:14:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53095) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1xSU-0002UE-2m for bug-guix@gnu.org; Wed, 12 Feb 2020 14:14:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1xST-0000E5-V0 for bug-guix@gnu.org; Wed, 12 Feb 2020 14:14:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87d0akfao2.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 12 Feb 2020 03:54:21 -0500") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: 39551@debbugs.gnu.org --=-=-= Content-Type: text/plain Attached is v2 of the patch, fixing the comment in the code as reported by Tobias. Thank you! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-scripts-system-Do-not-validate-network-file-systems.patch >From 666ce396f2a53bec4d88ee90c1612166421f3ed8 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Mon, 10 Feb 2020 15:06:50 -0500 Subject: [PATCH] scripts: system: Do not validate network file systems. Fixes issue #39551 (https://bugs.gnu.org/39551). * guix/scripts/system.scm (check-file-system-availability): Ignore file systems of the NFS type. --- guix/scripts/system.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index b0386a1392..ac2475c551 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -566,6 +566,8 @@ any, are available. Raise an error if they're not." (and (file-system-mount? fs) (not (member (file-system-type fs) %pseudo-file-system-types)) + ;; Don't try to validate network file systems. + (not (string-prefix? "nfs" (file-system-type fs))) (not (memq 'bind-mount (file-system-flags fs))))) file-systems)) -- 2.23.0 --=-=-=--