From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: 13/15: gnu: libreoffice: Fix =?utf-8?B?4oCYc29mZmljZeKAmQ==?= in a pure environment. Date: Sat, 22 Feb 2020 19:19:45 +0100 Message-ID: <87wo8etrgo.fsf@nckx> References: <20200221173940.26669.60790@vcs0.savannah.gnu.org> <20200221173946.F136121233@vcs0.savannah.gnu.org> <87r1ymyaj3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:45054) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5ZN8-0005Oe-O5 for guix-devel@gnu.org; Sat, 22 Feb 2020 13:19:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5ZN7-0006o7-Fj for guix-devel@gnu.org; Sat, 22 Feb 2020 13:19:26 -0500 In-reply-to: <87r1ymyaj3.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ludo', Ludovic Court=C3=A8s =E5=86=99=E9=81=93=EF=BC=9A > I strongly encourage using literal strings as patterns, it=E2=80=99s=20 > more > robust. In this case, you could replace the =E2=80=98for-each=E2=80=99=20 > expression with > something like (untested): > > (substitute* "desktop/scripts/soffice.sh" > (("\\<(dirname|grep|uname)\\>" _ cmomand) > (which command))) > > WDYT? Yeah. I use substitute*'s wonderful pattern matching all the=20 time, probably more than most. I have no idea why it didn't occur=20 to me here. I'll push this to staging, libreoffice users have been suffering=20 enough rebuilds lately. Thanks! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl5RcMIACgkQ2Imw8BjF STyGrw//RKp4lnQOtamjqAgn+yzjspIFq4mdf1qlwknXbNi8Tarn7O5Kx7jkbZl/ zhCePer7rdu2OIpeFxDjPs69l+/ln+b8XHvhtqT3u5G8h3hWUdKEcEqUnGQbmg7v ZntKZQVu2sOIkuRUi2WkVxqPwTyrobo+T8xuSEG8VsgqTyEkkuiSEVUA8zkHr4en U02n8c9U8uYaTEnehnbWN+lT3xfZrP1pGp/C4vLdKr41zU9t0BZ1GA+1STmeVglb YDzLAIMijf5IZ80hSHzTIkInryrMatF+1rwp9/MaFy7Bt0s3rTh7UVgRp6Rl0Lcr WfOVOk1d9pHL1pyO2MACEcrAc6CpJC+ImuSpsAGr3tTkN/uU955BVgowvRUhuxr8 9mVJQo4dxExPgtwBKh0ix51hZn6I+MNU0kOsUOSUo9gPXu72n7IG5RCTRcOZaMuw qLfiyEPWJB8/41UTm87gqtU3KVdQcpyciCX0KGtF5mgk6jwzGjsEA367PaFfCPGg y1iLSIGxD9nAYIn9z1DtQsVMDtGsHIIwHQAHqwiFVGTIxD1uDMp6a4fQdPf9WMpg 0z6lSfa7eTsKX+VwKLrm4q1PEzgNEiyTGwlU/64tzvM6zvDKC/A10aHM5Fpj4O0H K8suYkZArDjTrAwgVG6DylhiA4RXMn3DyGudEtgrOxjPA7aKdK4= =IOJm -----END PGP SIGNATURE----- --=-=-=--