From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:44026)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j87u7-0003AW-3m
 for guix-patches@gnu.org; Sat, 29 Feb 2020 14:36:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j87u5-0001t6-Vq
 for guix-patches@gnu.org; Sat, 29 Feb 2020 14:36:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:57679)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1j87u5-0001sz-Sk
 for guix-patches@gnu.org; Sat, 29 Feb 2020 14:36:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1j87u5-0005RF-Py
 for guix-patches@gnu.org; Sat, 29 Feb 2020 14:36:01 -0500
Subject: [bug#39818] [PATCH] gnu: Add emacs-ddskk.
Resent-Message-ID: <handler.39818.B39818.158300494620882@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <RBSjADghVPemvtNv7mi9eAoMggKAs5j95fTjdEDP5xhK6NqrkrQV-6rpW9xWP-_dFZvsXwx86wqMI--1LDn6Akv1vo3cyv1ZbiFfGnePKY8=@tojo.tokyo>
Date: Sat, 29 Feb 2020 20:35:34 +0100
In-Reply-To: <RBSjADghVPemvtNv7mi9eAoMggKAs5j95fTjdEDP5xhK6NqrkrQV-6rpW9xWP-_dFZvsXwx86wqMI--1LDn6Akv1vo3cyv1ZbiFfGnePKY8=@tojo.tokyo>
 (Masaya Tojo's message of "Fri, 28 Feb 2020 00:44:22 +0000")
Message-ID: <87wo852nll.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Masaya Tojo <masaya@tojo.tokyo>
Cc: 39818@debbugs.gnu.org

Hello,

Masaya Tojo <masaya@tojo.tokyo> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ddskk): New variable.

Thank you!

> +(define emacs-ddskk

Wouldn't it be emacs-skk, since one need to (require 'skk)?

> +  (package
> +    (name "emacs-ddskk")
> +    (version "17.0.50")

Is it an unstable version? Latest release seems to be 16.3. If so, if
there is a strong reason to use it instead, we should give it in
a comment.

> +    (home-page "https://github.com/skk-dev/ddskk")

This should be at the end of the package definition, right above
`synopsis'.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url home-page)
> +             (commit "b7bf6fa0e0fbb562c27a887283627a8781de0a34")))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1ysn73yysaxpm93y9d4g2hmnd7qhh6lv93wgkrdw1cx11xl1g7yk"))))
> +    (build-system emacs-build-system)
> +    (inputs `(("inetutils" ,inetutils)))
> +    (synopsis "Simple Kana to Kanji conversion program")
> +    (description "Daredevil SKK is a version of SKK (Simple Kana to Kanji
> + conversion program, an input method of Japanese) 

is a version of @acronym{SKK, Simple Kana to Kanji} conversion program,
an input method of Japanese.

> + maintained by the SKK development team at http://openlab.jp/skk.")

We may want to drop that part, not very useful in the package
description. However, if you keep it, it should be
@url{http://openlab.jp/skk}.

BTW, I cannot apply your patch. Could you send an updated revision with
the changes suggested above?

Regards,

-- 
Nicolas Goaziou