From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#39970: guix commands broken on Azerbaijani 'az_AZ' and Turkish 'tr_TR' locales Date: Tue, 17 Mar 2020 22:20:01 +0100 Message-ID: <87wo7ibrwe.fsf@gnu.org> References: <20200307120052.ocwzphlvemvmb2ts@pelzflorian.localdomain> <20200307152003.myj7jkjthokbmark@pelzflorian.localdomain> <20200308070804.ylpb5yrwpgbc3p3w@pelzflorian.localdomain> <8736ah1mxb.fsf@gnu.org> <20200312110206.2hsinzejnmcefmot@pelzflorian.localdomain> <874kutsgmx.fsf@gnu.org> <20200317094443.cnajoi4yuzvxaafe@pelzflorian.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:42753) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEJe5-0004bo-BC for bug-guix@gnu.org; Tue, 17 Mar 2020 17:21:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEJe2-0002aJ-W6 for bug-guix@gnu.org; Tue, 17 Mar 2020 17:21:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33646) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEJe2-0002Y6-Qp for bug-guix@gnu.org; Tue, 17 Mar 2020 17:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jEJe2-0000G6-L1 for bug-guix@gnu.org; Tue, 17 Mar 2020 17:21:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20200317094443.cnajoi4yuzvxaafe@pelzflorian.localdomain> (pelzflorian@pelzflorian.de's message of "Tue, 17 Mar 2020 10:44:43 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: "pelzflorian (Florian Pelz)" Cc: 39970@debbugs.gnu.org Hi, "pelzflorian (Florian Pelz)" skribis: > On Thu, Mar 12, 2020 at 05:05:26PM +0100, Ludovic Court=C3=A8s wrote: >> "pelzflorian (Florian Pelz)" skribis: >> > Why would not using a regexp be better? >>=20 >> It reduces reliance on libc, reduces complexity, and performs better as >> noted in the commit log of 35eb77b09d957019b2437e7681bd88013d67d3cd. > > Thank you for your wisdom. I hope the attached patch is OK. > > `LC_ALL=3Den_US.utf8 make check` is mostly fine (except tests/pack.scm, > which also failed before). > > Manual testing of `./pre-inst-env guix environment` works. Good! > `LC_ALL=3Dtr_TR.utf8 make check` is still very unhappy though. > There are many failures. I will continue to investigate later today. OK. > From: Florian Pelz > Date: Thu, 12 Mar 2020 11:08:16 +0100 > Content-Type: text/plain; charset=3DUTF-8 > Content-Transfer-Encoding: 8bit > Subject: [PATCH] store: Fix many guix commands failing on some locales. > > Partly fixes bug #39970 (see: https://bugs.gnu.org/39970). I=E2=80=99d just write: Partly fixes . Concise, clear, greppable. :-) > At least 'guix environment', 'guix install' and 'guix pull' > on 'az_AZ.utf8' and 'tr_TR.utf8' were affected. > > * guix/store.scm (store-path-hash-part): Move base path detection to ... > (store-path-base): ... this new exported procedure. > (store-path-package-name): Use it instead of locale-dependent regexps. > (store-regexp*): Remove. LGTM, thank you! Ludo=E2=80=99.