From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:43069) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOpR2-0004Ge-39 for guix-patches@gnu.org; Wed, 15 Apr 2020 17:19:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOpR0-0005FC-JU for guix-patches@gnu.org; Wed, 15 Apr 2020 17:19:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53907) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jOpR0-0005F3-9C for guix-patches@gnu.org; Wed, 15 Apr 2020 17:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jOpR0-0006yE-4y for guix-patches@gnu.org; Wed, 15 Apr 2020 17:19:02 -0400 Subject: [bug#40635] [PATCH] gnu: Add emacs-moody. Resent-Message-ID: References: <20200415050447.14598-1-barbanegra+guix@posteo.mx> In-reply-to: <20200415050447.14598-1-barbanegra+guix@posteo.mx> Date: Wed, 15 Apr 2020 23:18:26 +0200 Message-ID: <87wo6gzbvh.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: 40635@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Alberto, Alberto Eleuterio Flores Guerrero =E5=86=99=E9=81=93=EF=BC=9A > * gnu/packages/emacs-xyz.scm (emacs-moody): New variable. > --- > gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm=20 > b/gnu/packages/emacs-xyz.scm > index a9550ee112..364cec47da 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -507,6 +507,33 @@ Alternatively the menu can be bound=20 > globally, for example: > @code{(global-set-key [S-down-mouse-3]=20 > 'minions-minor-modes-menu)}.") > (license license:gpl3+))) >=20=20 > +(define-public emacs-moody > + (let ((commit "2751d36152abcc2ac1479225392182b53f1e02dd") > + (revision "1")) There's a =E2=80=98v0.5.3=E2=80=99 tag so we can just use that: (version "0.5.3") (source (origin (method git-fetch) (uri (git-reference (url "https://=E2=80=A6") ;; =E2=80=98Commit=E2=80=99 can really be any git identifier. (commit (string-append "v" version)))) =E2=80=A6)) and drop the (let =E2=80=A6). > + (package > + (name "emacs-moody") > + ;; version 4.0 is a bit old (2018) Nitpick: ;;-comments are sentences, so capitalise and end with a=20 full stop. However, IMO no comment is needed. The top release at=20 is 0.5.3, and I've=20 grown to ignore the =E2=80=98latest release=E2=80=99 badge on GitHub unless= there=20 are reasons not to. Too many upstreams forget to move it. > + (version (git-version "0.5.3" revision commit)) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url=20 > "https://github.com/tarsius/moody.git") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > +=20 > "1xyw4l42053595r76lj8safsx6pj25as0107wd96by3h7dg9m586")))) > + (build-system emacs-build-system) > + (home-page "https://github.com/tarsius/moody") > + (synopsis "Tabs and ribbons for Emacs mode-line") More nitpicks: =E2=80=98=E2=80=A6the Emacs mode line=E2=80=99. > + (description > + "@code{emacs-moody} provides utilities for displaying=20 > elements of > +the mode line as tabs and ribbons. It also provides=20 > replacements for a few > +built-in elements. The biggest differences to similar packages=20 > is that =E2=80=98=E2=80=A6difference[singular] with=E2=80=A6=E2=80=99. > +this one is much simpler and much more consistent. When using=20 > this package, I don't know enough about other extensions to judge whether that's=20 true, so I'll give it the benefit of the doubt. In general: feel free to remove content-free marketing from=20 upstream descriptions. > +then only the color of the mode line changes when a window=20 > becomes in-/active.") You can drop =E2=80=98then=E2=80=99 here. I'd write =E2=80=98(in)active=E2= =80=99 but that might=20 be purely a matter of taste. No need to send an updated patch; I'll make above changes and push=20 if that's all right with you. I might give others time to chime=20 in if I'm feeling laz^Wgenerous. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl6XeiIACgkQ2Imw8BjF STwawhAAlfkD8jvxvMeb+Ndz5KG3O8s8C0QYaUA4RCTiumPgcmtvCNa79QcjJ97W SoN4ZgAHJfzG6HzPOZijrcloP0+lUAFPu3G7i519aBNv9nle8K427N1Du023T0D/ 6HT26FjP0F6ycyyyJEVhpcTsgLG4i1HxTwgBaHZC+TYhOn89KygFTIPeJTQ/58au ARqFre/tTZLb/cDzwfw73+S/SvNh0DbOFZ/p14RUZVnwWAfZaVvbmzpy8/1VKu5j YjgcXBkUsVaIezsaogPtzFMtQY2+ifMFjq3jNo20xg047HEtNz2OZ4za7ynwDSzO DcqLyNei6/pCXD1T1waX+qJmi+SU+Zwbc4xq23abceQkOYc528cwk/ESQ9B8eMp6 qjdwpDef8zgMENf2j59jabOoQ1K/kTPLfq0chYCPcAGZuqxmYeQMZEzvJxu2sTyo V2LcGeLftzJ/i7v8foFbsbX9pTBihCSxvBhMz20sSVXx0LMBp/GY2CLIEy/w+k5c V4FyVwz0djvfaF574kTLMI/5A8x2Z64Ow5BNnQfKU+njlHNFLmDgvRbu6+IRvGxN ww5vkh9PHezYpaATQgoVcxz5z/6GwePpn851BZsR/bwCuSY/2xMASaf7YG/rvnzZ RxFV6hfSLlMbwntS1LintS3DUQcDUX197brsWNV8GMKgovgzWkM= =qxc7 -----END PGP SIGNATURE----- --=-=-=--