From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +PHUJ01bq17VEAAA0tVLHw (envelope-from ) for ; Thu, 30 Apr 2020 23:12:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id QKHXHlZbq16vLAAA1q6Kng (envelope-from ) for ; Thu, 30 Apr 2020 23:12:22 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 740479413B0 for ; Thu, 30 Apr 2020 23:12:21 +0000 (UTC) Received: from localhost ([::1]:37474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUILs-0005Cp-SE for larch@yhetil.org; Thu, 30 Apr 2020 19:12:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40062) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUILH-0004ii-87 for guix-patches@gnu.org; Thu, 30 Apr 2020 19:11:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUIJh-0003ui-AP for guix-patches@gnu.org; Thu, 30 Apr 2020 19:11:42 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUIJe-0003oE-Ki for guix-patches@gnu.org; Thu, 30 Apr 2020 19:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUIJe-0007yn-0t for guix-patches@gnu.org; Thu, 30 Apr 2020 19:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40925] [PATCH] Add collectd Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 30 Apr 2020 23:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 40925@debbugs.gnu.org Received: via spool by 40925-submit@debbugs.gnu.org id=B40925.158828814830579 (code B ref 40925); Thu, 30 Apr 2020 23:10:01 +0000 Received: (at 40925) by debbugs.gnu.org; 30 Apr 2020 23:09:08 +0000 Received: from localhost ([127.0.0.1]:47894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUIIm-0007x9-5o for submit@debbugs.gnu.org; Thu, 30 Apr 2020 19:09:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUIIh-0007wZ-2o for 40925@debbugs.gnu.org; Thu, 30 Apr 2020 19:09:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60635) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUIIb-0000Uh-08; Thu, 30 Apr 2020 19:08:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35908 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUIIa-0002oy-AD; Thu, 30 Apr 2020 19:08:56 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200428085719.GA3395@zpidnp36> <20200428092938.GB3395@zpidnp36> Date: Fri, 01 May 2020 01:08:54 +0200 In-Reply-To: <20200428092938.GB3395@zpidnp36> (Lars-Dominik Braun's message of "Tue, 28 Apr 2020 11:29:38 +0200") Message-ID: <87wo5winax.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -0.30 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-0.30 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49484502863613]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.17), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MIME_TRACE(0.00)[0:+]; R_MIXED_CHARSET(0.71)[subject]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; R_DKIM_NA(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[ludo@gnu.org,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[leibniz-psychology.org:email,makefile.in:url]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[gnu.org]; HAS_LIST_UNSUB(-0.01)[]; RCVD_COUNT_SEVEN(0.00)[10]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: yEjrr/u249EE Hi, Lars-Dominik Braun skribis: > From 05110cd7f0af5f870daa48a1e32bff56efb2676a Mon Sep 17 00:00:00 2001 > From: Lars-Dominik Braun > Date: Tue, 28 Apr 2020 10:50:10 +0200 > Subject: [PATCH] gnu: Add collectd > > * gnu/packages/monitoring.scm (collectd): New variable > * gnu/local.mk (dist_patch_DATA): Add new patch > * gnu/packages/patches/collectd-5.11.0-noinstallvar.patch: New file [...] > + (arguments > + `(#:configure-flags (list "--localstatedir=3D/var" "--sysconfdir=3D= /etc") > + #:phases > + (modify-phases %standard-phases > + ;; Required because of patched sources. > + (add-before 'configure 'autoreconf > + (lambda _ (invoke "autoreconf" "-vfi") #t))= ))) Another option is to patch Makefile.in to avoid the dependency on Autoconf/Automake/Libool + this phase. > + (license '(licenses:expat licenses:gpl2)))) This is incorrect (see patch below, which also includes indentation fixes and minor changes to the description to placate =E2=80=98guix lint=E2= =80=99.) Also, could you add a comment stating whether it=E2=80=99s dual-licensing or just that there=E2=80=99s code in both licenses? > diff --git a/gnu/packages/patches/collectd-5.11.0-noinstallvar.patch b/gn= u/packages/patches/collectd-5.11.0-noinstallvar.patch > new file mode 100644 > index 0000000000..a8ca142147 > --- /dev/null > +++ b/gnu/packages/patches/collectd-5.11.0-noinstallvar.patch A one-line comment at the top explaining what it does would be great. Otherwise LGTM. Could you send an updated patch? Thanks in advance! Ludo=E2=80=99.