From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KMtfKmJ1U18wLQAA0tVLHw (envelope-from ) for ; Sat, 05 Sep 2020 11:24:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ANAdJmJ1U181TQAAB5/wlQ (envelope-from ) for ; Sat, 05 Sep 2020 11:24:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 39C809403EE for ; Sat, 5 Sep 2020 11:24:18 +0000 (UTC) Received: from localhost ([::1]:41200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEWIq-0002jH-0n for larch@yhetil.org; Sat, 05 Sep 2020 07:24:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEWIc-0002iS-DU for guix-patches@gnu.org; Sat, 05 Sep 2020 07:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEWIc-0000G5-4O for guix-patches@gnu.org; Sat, 05 Sep 2020 07:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEWIc-0003bE-05 for guix-patches@gnu.org; Sat, 05 Sep 2020 07:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 05 Sep 2020 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 43204@debbugs.gnu.org, mike@rohleder.de X-Debbugs-Original-Cc: 43204@debbugs.gnu.org, Michael Rohleder , guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.159930503813822 (code B ref -1); Sat, 05 Sep 2020 11:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Sep 2020 11:23:58 +0000 Received: from localhost ([127.0.0.1]:41617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEWIY-0003as-4b for submit@debbugs.gnu.org; Sat, 05 Sep 2020 07:23:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:49078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEWIW-0003al-GF for submit@debbugs.gnu.org; Sat, 05 Sep 2020 07:23:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEWIW-0002ge-Ah for guix-patches@gnu.org; Sat, 05 Sep 2020 07:23:56 -0400 Received: from mout.gmx.net ([212.227.17.22]:46407) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEWIU-0000CQ-8e for guix-patches@gnu.org; Sat, 05 Sep 2020 07:23:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599305022; bh=2Lui4zQULpPScBT7ZrfX+lvnQK0lzDNzH3RwRSmvLM0=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=Z0hV9g4G9GMafCnw6XfRfbJnfuLiwTgHuS0hMinkROA1K/RFdJ3bqh5DgqWIvIqo4 rCowkJ78O0bCEHeIznFukw7HJtSpceqfJ5/wVhnr4LdDW19DtKBQ+5G7doiDGmTjTW fjRktXe94O61i2UxZ4GOv48nq7uuuHAsPDpFHS3s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mf0BG-1kl6DU2fne-00gYJI; Sat, 05 Sep 2020 13:23:42 +0200 References: <20200904153824.27164-1-mike@rohleder.de> <87363xmsfx.fsf@gmx.com> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois In-reply-to: <87363xmsfx.fsf@gmx.com> Date: Sat, 05 Sep 2020 12:23:43 +0100 Message-ID: <87wo18piv4.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Provags-ID: V03:K1:qcVvjt3qzXHy7DFbqk+/Z+JmSk/U8AwAnlMNeTsYQdsEIrFnDib zTsZGwHeYSlKqxNTC/xbvx9dDGb+8iv2csTuGxuUcE2uItpDVwLHQjecOMcb8gGyktYyooT GKOV7x4SlTMt2CHy1UhwRy0z1rerhf7mdwXFQtnD1mdIxVwz6jn8Jc/Y127S2MN1hKgQVnB FDpmWLqjq5bVMchpkIigA== X-UI-Out-Filterresults: notjunk:1;V03:K0:yGs4UE66+1g=:zj3p/RZ5oW3vlhAmBIO8zU 84+sA0Jo0d2I8SpKOhoPA6oJz5mxACP+GR7yv4616SnYYv9b9xdSVmu3eqW8/w7qTzDxB+P6p tP2pb2Ekd1t/FIviMTL4PQZ+sgoUDIfwrC1gSz3ZG/mQ9ucQsyu3slXxaNaC6DZjk32nNJ7YO oFF5jmU4OKiSEZSo/t1WTgbGFEfhBCbKfKCFtfpvLnE/LtjUMGnYXFfQ4qZPfKAd3kD10hbu9 oYgJ+J8yYAmn05hWlbTDYgOUhPImfoY7rUMwtx3r8p2d68/WGFneAATErmT9F/Jw5vmM1mqFG bZLxFywh9nG46ttZYB7zjG+QxpsqiWvH2OjdV7aodGiFwaomvVN3eljl5hABn2J1Ixn6UHCwu QpGhkzcFGMeCfU6OwT4DPq9zaVFzxJsW6GoRUDGgySBklM2zb2CTczpSELf0gvH5i40xSL0zJ wL6FsU1QmH3vwMot60P1BBD+fqrB9DHBqekO4s8bhgeTgn17ReVyRwBG2cBBX/ydozKDy6UkK SrG93Gf5lEsZXZK8imFJprgcdAauc9YfTch26ntvQBMKapd/9pYpWfIlihZh+aBmv/ZCEHOSv HzKHeKfNr6v/9hINt1sJ0+O/MEL7Vl6oLcOhrJvOqT0gJLmT9LcW7BVteyjHEcUNa2STLHOkI Rh3ESmH8SB2lUkSBSI8ll6sdChADuQfcVvu8HSWMAxmWzZzi2sx/uPiKwVHsdX9UkVBdhlY6H cXD3X40YQFda+SUv31CnCQgRADCXqeoqd7jicj1acO6W1UIbIOZhX//l/RMp3sIgqqzy0D/SI q5Yu7UDfGjj6Q4K9dkfreRtlyt+55OGqpJK52n6SwiXcs63oTnwzAiDUEmrMGa3CZ26MiLdYF FINIeO6yjxXMVZG+rpYp54Gld5CFePPEYkB/G5aHCOGfifnI2nnD+cxhv/2fKXK1ZqLO96z+9 5lW2asX6LdGu9ETsogz8049SKm1+6JpfArhjdp7+1ULyzksdACs1eQyJdt16Fir0/TJ0a+rIm 4BNJe8fdfHAoeHKlCbDcbpttqoqa30mteaG02v0EOSRaqVbREGyqc4yE9R59Oo4nfeDgolRJl cljFZSObSfCOjY6BFUJRylzI2aEnma4FpBmu1Skz+Dc2FCiwc2qHrshutQMbShdzUPrCfwL4j ZW4zzho0UPooc3hBpfRj2uU3vb6qUVxJiGyPosFtLBF7GL75lrGWav4k33eYvgY94/ylYrq7J kIFK5ikfJVoAixISQVeyN+Z/HR36Ua+pIsjpFzw== Received-SPF: pass client-ip=212.227.17.22; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/05 07:23:51 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.4 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmx.net header.s=badeba3b8450 header.b=Z0hV9g4G; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.11 X-TUID: rXM5lKEr82HL --=-=-= Content-Type: text/plain Pierre Langlois writes: > Hi Michael, > > Michael Rohleder writes: > >> * gnu/packages/mp3.scm (taglib)[inputs]: Move zlib to [propagated-inputs]. >> --- >> It seems, consumer of taglib (commit 89e1e44813) needs to be linked w/ libz >> according to the installed pkg-config. >> >> I noticed that emacs-emms-print-metadata fails to link with a missing -lz lib, >> (I guess, all revdeps of taglib that don't have zlib as an input have that problem) > > Oh, indeed emacs-emms doesn't build, sorry for the breakage! :-/ I see > the pkg-config file was changed here https://github.com/taglib/taglib/commit/ef1312d62239f399c40233d76ef3328b8dadf984 > > Propagating zlib seems like the right thing to do (although I'm not a > maintainer), thanks for the patch! Actually, thinking about this a little more, I'm not sure I understand upstream decision to propagate -lz. The commit fixes [0] which indicates it's so that taglib can be linked statically, but then that means if we're dynamically linking, the application will also dynamically link with zlib when it doesn't need to (at least not directly). And in guix we only build shared libs for taglib so we're never statically linking it AFAIK. So, here I'm a bit torn here, should we just follow what upstream is indicating? Even it doesn't look right to me, but I might be wrong! Or, should we revert the change that propagates -lz? Thanks, Pierre [0]: https://github.com/taglib/taglib/issues/872 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9TdT8YHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UKoIH/1Symc4WsyqqhGTafMjEbql8 ai5420ZcSv7DRWd9IHrffN+WeF44Nt+eVakMQaqqJHtTmAgER6UzjRK0zGxRv3Rp Dr9py+zdhIwLOkjB2IhmOhztdjmOahj0a3xyPkdnaTdEEpqGNqe9rDruwwqekC15 IWCjWcZQ9w/5djV7MbHLXPDOnulJVVR9AG2Pk9O06Q8qSIk/p/nAdfvz1iDY08uX Hg0oALdbRoxBrOdUdOywGSa545nNqGbLL/N7Ipc98jLfCS0dru93OY90ocBxP9no bP65AvWiJiM8vFM6qIjTSMFc4ZBhF/AoBtHKGjrJvnzTjMS15C+adaowKuY4dM4= =4MeF -----END PGP SIGNATURE----- --=-=-=--