From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8LG7AS/h9F++bQAA0tVLHw (envelope-from ) for ; Tue, 05 Jan 2021 21:59:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id gKkkOS7h9F9BCgAAB5/wlQ (envelope-from ) for ; Tue, 05 Jan 2021 21:59:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BFEAA94036A for ; Tue, 5 Jan 2021 21:59:10 +0000 (UTC) Received: from localhost ([::1]:45060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwuM9-0004Bj-OO for larch@yhetil.org; Tue, 05 Jan 2021 16:59:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwuM2-0004AD-KC for guix-patches@gnu.org; Tue, 05 Jan 2021 16:59:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59556) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwuM2-0005mc-B8 for guix-patches@gnu.org; Tue, 05 Jan 2021 16:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwuM2-0008Ir-AX for guix-patches@gnu.org; Tue, 05 Jan 2021 16:59:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45409] [PATCH v3 2/3] guix: Move narinfo code from substitute script to module. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Jan 2021 21:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45409 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Received: via spool by 45409-submit@debbugs.gnu.org id=B45409.160988392831898 (code B ref 45409); Tue, 05 Jan 2021 21:59:02 +0000 Received: (at 45409) by debbugs.gnu.org; 5 Jan 2021 21:58:48 +0000 Received: from localhost ([127.0.0.1]:42869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwuLn-0008IQ-O5 for submit@debbugs.gnu.org; Tue, 05 Jan 2021 16:58:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwuLm-0008IF-Qr for 45409@debbugs.gnu.org; Tue, 05 Jan 2021 16:58:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45889) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwuLh-0005hD-IE; Tue, 05 Jan 2021 16:58:41 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41114 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kwuLZ-0002qY-JW; Tue, 05 Jan 2021 16:58:38 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210104211927.14959-1-mail@cbaines.net> <20210104211927.14959-2-mail@cbaines.net> Date: Tue, 05 Jan 2021 22:58:32 +0100 In-Reply-To: <20210104211927.14959-2-mail@cbaines.net> (Christopher Baines's message of "Mon, 4 Jan 2021 21:19:26 +0000") Message-ID: <87wnwrrqpj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45409@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.84 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BFEAA94036A X-Spam-Score: -2.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: O6EJvqaRacuJ Christopher Baines skribis: > This separation between the code for dealing with narinfos from the code = doing > that for a purpose should make things clearer, and better support compone= nts > other that the substitute script in using this code. > > This is just moving the code around, no code should have been significant= ly > changed. > > * guix/scripts/substitute.scm (): Move record type to (guix nari= nfo). > (fields->alist, narinfo-hash-algorithm+value, narinfo-hash->sha256, > narinfo-signature->canonical-sexp, narinfo-maker, read-narinfo, > narinfo-sha256, valid-narinfo?, write-narinfo, narinfo->string, > string->narinfo, equivalent-narinfo?, supported-compression?, > compresses-better?, narinfo-best-uri): Move procedures to (guix narinfo). > (%compression-methods): Move variable to (guix narinfo). > * guix/narinfo.scm: New file. > * Makefile.am (MODULES): Add it. > * po/guix/POTFILES.in: Add 'guix/narinfo.scm'. [...] > +(define-module (guix narinfo) [...] > + #:use-module (guix scripts substitute) This one should be removed. Otherwise LGTM! Thanks, Ludo=E2=80=99.