From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kCdjDRER/F+vJgAA0tVLHw (envelope-from ) for ; Mon, 11 Jan 2021 08:49:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uOg3CRER/F/FDAAAB5/wlQ (envelope-from ) for ; Mon, 11 Jan 2021 08:49:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9F00D940415 for ; Mon, 11 Jan 2021 08:49:20 +0000 (UTC) Received: from localhost ([::1]:53526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyst5-00019T-H8 for larch@yhetil.org; Mon, 11 Jan 2021 03:49:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyssx-00019K-BE for guix-devel@gnu.org; Mon, 11 Jan 2021 03:49:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33304) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyssx-0006wd-4C; Mon, 11 Jan 2021 03:49:11 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=57358 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kyssw-0006HX-JZ; Mon, 11 Jan 2021 03:49:10 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: guix-devel@gnu.org Subject: Re: branch core-updates updated: packages: Fix 'base32' used before definition warning. References: <20210110222441.10557.47179@vcs0.savannah.gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 =?utf-8?Q?Niv=C3=B4se?= an 229 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 11 Jan 2021 09:49:09 +0100 In-Reply-To: <20210110222441.10557.47179@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Sun, 10 Jan 2021 17:24:41 -0500") Message-ID: <87wnwjg8oq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxim Cournoyer Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 9F00D940415 X-Spam-Score: -1.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: ARx5HkNrE3XZ Hi Maxim, guix-commits@gnu.org skribis: > commit 31ebecf73dadb51ccc72053f54dee36c93a2d0ab > Author: Maxim Cournoyer > AuthorDate: Sun Jan 10 08:42:42 2021 -0500 > > packages: Fix 'base32' used before definition warning. >=20=20=20=20=20 > Before this change, compiling the module would emit the following mes= sage: > "guix/packages.scm:213:25: warning: macro `base32' used before defini= tion". >=20=20=20=20=20 > * guix/packages.scm (define-compile-time-decoder) > (base32, base64): Move definitions to the top of the module. To avoid merge conflicts down the road, could you apply it to =E2=80=98mast= er=E2=80=99 as well? (It=E2=80=99s fine to have it on =E2=80=98master=E2=80=99 as it d= oesn=E2=80=99t trigger any rebuild.) Thanks, Ludo=E2=80=99.