From: "Ludovic Courtès" <ludo@gnu.org>
To: Philip Munksgaard <philip@munksgaard.me>
Cc: 48943@debbugs.gnu.org
Subject: [bug#48943] [PATCH] import: hackage: Support "common" field and imports
Date: Sun, 13 Jun 2021 22:34:46 +0200 [thread overview]
Message-ID: <87wnqxzeop.fsf@gnu.org> (raw)
In-Reply-To: <20210610083953.664318-1-philip@munksgaard.me> (Philip Munksgaard's message of "Thu, 10 Jun 2021 10:39:53 +0200")
Hi,
Philip Munksgaard <philip@munksgaard.me> skribis:
> Fixes <https://issues.guix.gnu.org/48701>.
>
> * guix/import/cabal.scm (make-cabal-parser): Modify.
> (is-common): New variable.
> (lex-common): New procedure.
> (is-id): Modify.
> (eval-cabal): Modify.
Could you add a test case in ‘tests/hackage.scm’ and send an updated
patch?
Apart from that it LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2021-06-13 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 8:39 [bug#48943] [PATCH] import: hackage: Support "common" field and imports Philip Munksgaard
2021-06-13 20:34 ` Ludovic Courtès [this message]
2021-06-18 12:48 ` [bug#48943] [PATCH v2] " Philip Munksgaard
2021-06-25 12:27 ` bug#48943: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnqxzeop.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=48943@debbugs.gnu.org \
--cc=philip@munksgaard.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.