From: Arun Isaac <arunisaac@systemreboot.net>
To: BonfaceKilz <me@bonfacemunyoki.com>, 50117@debbugs.gnu.org
Cc: BonfaceKilz <me@bonfacemunyoki.com>, iskarian@mgsn.dev
Subject: [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates
Date: Fri, 20 Aug 2021 01:17:39 +0530 [thread overview]
Message-ID: <87wnohrzc4.fsf@systemreboot.net> (raw)
In-Reply-To: <20210819072156.90545-1-me@bonfacemunyoki.com>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
Hi Bonface,
Thanks for the patches! Some feedback follows.
1. I think we can combine the two commits into one since this is
logically just a single change.
2. We should retain the old package as a deprecated package. We should
add something like the snippet below.
--8<---------------cut here---------------start------------->8---
(define-public go-github-com-aswinkarthik-csvdiff
(deprecated-package "go-github-com-aswinkarthik-csvdiff" csvdiff))
--8<---------------cut here---------------end--------------->8---
> (define-public go-github-com-aswinkarthik-csvdiff
3. We should rename the variable name as well.
> (package
> - (name "go-github-com-aswinkarthik-csvdiff")
> + (name "csvdiff")
3. We should also move the package to some file other than
golang.scm. How about textutils.scm?
Thank you for your patience! :-)
Arun
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]
next prev parent reply other threads:[~2021-08-19 19:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 7:17 [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates BonfaceKilz
2021-08-19 7:21 ` BonfaceKilz
2021-08-19 7:21 ` [bug#50117] [PATCH 1/2] gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff" BonfaceKilz
2021-08-19 7:21 ` [bug#50117] [PATCH 2/2] gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native BonfaceKilz
2021-08-19 19:47 ` Arun Isaac [this message]
2021-12-09 10:35 ` [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
2021-12-09 14:02 ` Bonface M. K
2021-12-10 3:30 ` Arun Isaac
2021-12-10 11:17 ` [bug#50117] [PATCH 0/1] " BonfaceKilz
2021-12-10 11:17 ` [bug#50117] [PATCH 1/1] gnu: Move csvdiff to (gnu packages textutils) BonfaceKilz
2021-12-13 6:08 ` [bug#50117] [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates Arun Isaac
2021-12-13 6:50 ` Bonface M. K
2021-12-13 20:51 ` Bonface M. K
2021-12-20 5:35 ` bug#50117: " Arun Isaac
2021-12-21 12:29 ` [bug#50117] " Bonface M. K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnohrzc4.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=50117@debbugs.gnu.org \
--cc=iskarian@mgsn.dev \
--cc=me@bonfacemunyoki.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.