all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#50341] [PATCH 0/1] emacs-org-roam include extensions
@ 2021-09-02 16:27 Collin J. Doering
  2021-09-02 16:36 ` [bug#50341] [PATCH 1/1] gnu: Update emacs-org-roam to " Collin J. Doering
  0 siblings, 1 reply; 4+ messages in thread
From: Collin J. Doering @ 2021-09-02 16:27 UTC (permalink / raw)
  To: 50341

This resolves issues with the emacs-org-roam packages after the 2.0.0 ->
2.1.0 upgrade. Upstream, some parts of org-roam have been moved to an
extensions directory. This patch also includes these extensions.

In the future, we may want to provide these as a separate output.

Collin J. Doering (1):
  gnu: Update emacs-org-roam to include extensions

 gnu/packages/emacs-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.33.0

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#50341] [PATCH 1/1] gnu: Update emacs-org-roam to include extensions
  2021-09-02 16:27 [bug#50341] [PATCH 0/1] emacs-org-roam include extensions Collin J. Doering
@ 2021-09-02 16:36 ` Collin J. Doering
  2021-09-02 16:48   ` Collin J. Doering
  0 siblings, 1 reply; 4+ messages in thread
From: Collin J. Doering @ 2021-09-02 16:36 UTC (permalink / raw)
  To: 50341

---
 gnu/packages/emacs-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c106e81fa5..bb6d0b0757 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28232,7 +28232,8 @@ snippets for Emacs.")
         (base32 "092xn0sqc7b7f6pdf7m6c3giqqbh6fq02mfz8qrg0wmx4ds1isqp"))))
     (build-system emacs-build-system)
     (arguments
-     `(#:phases
+     `(#:include (cons "^extensions/" %default-include)
+       #:phases
        (modify-phases %standard-phases
          (add-after 'install 'install-image
            (lambda* (#:key outputs #:allow-other-keys)
-- 
2.33.0

-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#50341] [PATCH 1/1] gnu: Update emacs-org-roam to include extensions
  2021-09-02 16:36 ` [bug#50341] [PATCH 1/1] gnu: Update emacs-org-roam to " Collin J. Doering
@ 2021-09-02 16:48   ` Collin J. Doering
  2021-09-03 14:25     ` bug#50341: " Collin J. Doering
  0 siblings, 1 reply; 4+ messages in thread
From: Collin J. Doering @ 2021-09-02 16:48 UTC (permalink / raw)
  To: 50341

Noticed that this duplicates (https://issues.guix.gnu.org/50333),
however in 50333, another build phase is added to copy over extensions
which is not necessary give the #:include option (as used in the patchset).

On 02 Sep 2021 at 12:36, "Collin J. Doering" <collin@rekahsoft.ca> wrote:

> ---
>  gnu/packages/emacs-xyz.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index c106e81fa5..bb6d0b0757 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -28232,7 +28232,8 @@ snippets for Emacs.")
>          (base32 "092xn0sqc7b7f6pdf7m6c3giqqbh6fq02mfz8qrg0wmx4ds1isqp"))))
>      (build-system emacs-build-system)
>      (arguments
> -     `(#:phases
> +     `(#:include (cons "^extensions/" %default-include)
> +       #:phases
>         (modify-phases %standard-phases
>           (add-after 'install 'install-image
>             (lambda* (#:key outputs #:allow-other-keys)
> -- 
> 2.33.0


-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#50341: [PATCH 1/1] gnu: Update emacs-org-roam to include extensions
  2021-09-02 16:48   ` Collin J. Doering
@ 2021-09-03 14:25     ` Collin J. Doering
  0 siblings, 0 replies; 4+ messages in thread
From: Collin J. Doering @ 2021-09-03 14:25 UTC (permalink / raw)
  To: 50341-done

I realized this morning that this change, unlike
https://issues.guix.gnu.org/50333 does not copy extensions into the
load-path that will be used, which is certainly not favorable.

I think that longer term we likely want to have a separate package that
includes these org-roam extensions.

Closing this issue in preference of 50333.

On 02 Sep 2021 at 12:48, "Collin J. Doering" <collin@rekahsoft.ca> wrote:

> Noticed that this duplicates (https://issues.guix.gnu.org/50333),
> however in 50333, another build phase is added to copy over extensions
> which is not necessary give the #:include option (as used in the patchset).
>
> On 02 Sep 2021 at 12:36, "Collin J. Doering" <collin@rekahsoft.ca> wrote:
>
>> ---
>>  gnu/packages/emacs-xyz.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index c106e81fa5..bb6d0b0757 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -28232,7 +28232,8 @@ snippets for Emacs.")
>>          (base32 "092xn0sqc7b7f6pdf7m6c3giqqbh6fq02mfz8qrg0wmx4ds1isqp"))))
>>      (build-system emacs-build-system)
>>      (arguments
>> -     `(#:phases
>> +     `(#:include (cons "^extensions/" %default-include)
>> +       #:phases
>>         (modify-phases %standard-phases
>>           (add-after 'install 'install-image
>>             (lambda* (#:key outputs #:allow-other-keys)
>> -- 
>> 2.33.0


-- 
Collin J. Doering

http://rekahsoft.ca
http://blog.rekahsoft.ca
http://git.rekahsoft.ca




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-09-03 14:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-02 16:27 [bug#50341] [PATCH 0/1] emacs-org-roam include extensions Collin J. Doering
2021-09-02 16:36 ` [bug#50341] [PATCH 1/1] gnu: Update emacs-org-roam to " Collin J. Doering
2021-09-02 16:48   ` Collin J. Doering
2021-09-03 14:25     ` bug#50341: " Collin J. Doering

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.