all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Andrew Tropin <andrew@trop.in>,
	Oleg Pykhalov <go.wigust@gmail.com>,
	50504@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#50504] [PATCH] fixup! home-services: Add Mcron.
Date: Mon, 13 Sep 2021 18:17:21 +0200	[thread overview]
Message-ID: <87wnnktppq.fsf@yoctocell.xyz> (raw)
In-Reply-To: <877dflrmxg.fsf@trop.in>

[-- Attachment #1: Type: text/plain, Size: 2544 bytes --]

On Mon, Sep 13 2021, Andrew Tropin wrote:

> Applied suggestions.
>
> From f93bb50483246e3c2c8df669231b13cb85578bfb Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Mon, 13 Sep 2021 09:39:18 +0300
> Subject: [PATCH] fixup! home-services: Add Mcron.
>
> ---
>  doc/guix.texi | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index a7eacad762..419d9429d6 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -16090,9 +16090,9 @@ This is the type of the @code{mcron} service, whose value is an
>  @code{mcron-configuration} object.
>  
>  This service type can be the target of a service extension that provides
> -it additional job specifications (@pxref{Service Composition}).  In
> -other words, it is possible to define services that provide additional
> -mcron jobs to run.
> +additional job specifications (@pxref{Service Composition}).  In other
> +words, it is possible to define services that provide additional mcron
> +jobs to run.
>  @end defvr
>  
>  @deftp {Data Type} mcron-configuration
> @@ -35689,17 +35689,19 @@ The @code{(gnu home-services mcron)} module provides an interface to
>  GNU@tie{}mcron, a daemon to run jobs at scheduled times (@pxref{Top,,,
>  mcron, GNU@tie{}mcron}).  The information about system's mcron is
>  applicable here (@pxref{Scheduled Job Execution}), the only difference
> -for home services is that they have to be declared in
> -@code{home-envirnoment} record instead of @code{operating-system}.
> +for home services is that they have to be declared in a
> +@code{home-envirnoment} record instead of an @code{operating-system}
> +record.
>  
>  @defvr {Scheme Variable} home-mcron-service-type
>  This is the type of the @code{mcron} home service, whose value is an
> -@code{home-mcron-configuration} object.  It allows to manage tasks
> +@code{home-mcron-configuration} object.  It allows to manage scheduled
> +tasks.
>  
>  This service type can be the target of a service extension that provides
> -it additional job specifications (@pxref{Service Composition}).  In
> -other words, it is possible to define services that provide additional
> -mcron jobs to run.
> +additional job specifications (@pxref{Service Composition}).  In other
> +words, it is possible to define services that provide additional mcron
> +jobs to run.
>  @end defvr
>  
>  @deftp {Data Type} home-mcron-configuration
> -- 
> 2.33.0

The updated patch LGTM!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-09-13 16:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  6:26 [bug#50504] [PATCH] home-services: Add Mcron Andrew Tropin
2021-09-10 18:22 ` Xinglu Chen
2021-09-13  6:44   ` Andrew Tropin
2021-09-13 16:16     ` Xinglu Chen
2021-09-14  6:34       ` Andrew Tropin
2021-09-13  6:48   ` [bug#50504] [PATCH] fixup! " Andrew Tropin
2021-09-13 16:17     ` Xinglu Chen [this message]
2021-09-13 20:02     ` bug#50504: [PATCH] " Oleg Pykhalov
2021-09-14  6:35       ` [bug#50504] " Andrew Tropin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnnktppq.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=50504@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=go.wigust@gmail.com \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.