From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cAqNFm6a5GHNAQEAgWs5BA (envelope-from ) for ; Sun, 16 Jan 2022 23:21:34 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id +HPkE26a5GGzpgAA9RJhRA (envelope-from ) for ; Sun, 16 Jan 2022 23:21:34 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9225238C6A for ; Sun, 16 Jan 2022 23:21:33 +0100 (CET) Received: from localhost ([::1]:38012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9Du0-0005rF-NZ for larch@yhetil.org; Sun, 16 Jan 2022 17:21:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53060) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9DsZ-0004qs-9Y for guix-patches@gnu.org; Sun, 16 Jan 2022 17:20:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9DsZ-00066r-01 for guix-patches@gnu.org; Sun, 16 Jan 2022 17:20:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9DsY-0002TY-N8 for guix-patches@gnu.org; Sun, 16 Jan 2022 17:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53060] [PATCH 0/2] Allow the github updater to update git sources Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 16 Jan 2022 22:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53060 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 53060@debbugs.gnu.org Received: via spool by 53060-submit@debbugs.gnu.org id=B53060.16423716009504 (code B ref 53060); Sun, 16 Jan 2022 22:20:02 +0000 Received: (at 53060) by debbugs.gnu.org; 16 Jan 2022 22:20:00 +0000 Received: from localhost ([127.0.0.1]:44388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9DsV-0002TD-Ls for submit@debbugs.gnu.org; Sun, 16 Jan 2022 17:19:59 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:56778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9DsS-0002Sv-W2 for 53060@debbugs.gnu.org; Sun, 16 Jan 2022 17:19:58 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 255E8195; Sun, 16 Jan 2022 23:19:50 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zKMnKh3pdDcK; Sun, 16 Jan 2022 23:19:49 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 0ADC618A; Sun, 16 Jan 2022 23:19:48 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <538acb9dc52f6992a5a65846db48f8b7382fb1be.camel@telenet.be> Date: Sun, 16 Jan 2022 23:19:48 +0100 In-Reply-To: <538acb9dc52f6992a5a65846db48f8b7382fb1be.camel@telenet.be> (Maxime Devos's message of "Thu, 06 Jan 2022 21:48:15 +0100") Message-ID: <87wnizz5kr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 255E8195 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DBL_PROHIBIT(0.00)[0.9.0.0:email]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642371694; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=04PWuupM0Brorf3/kjV4rK/UUiaX9lzblUYf219w3vQ=; b=tcXHJY+s2pjmd6wVuZa9wlCOTWLlDpki1qO09yDCjXcXipQ7h9IdtAJZzCXWM4+4f5CtIM TWLtqQTM2c0UBxf/xMwkBfHPeM7BScyML+ySV5uOvaycG94SY8/650K3ulzROLignzqmsB GTP5qZwNSz9XA189IJZPinz/wMQjjS4G+i31GoHFIjlcfbKQXbFm5ZPu/I9U8Fv789DvMf kHM/1q4nO+zkXW1f6K08ZfCyUEEDJuLZH+PAZec8s6my39NBr0V5pKHXEvoMxgseMBkH39 gNHuVwvdjYI3k+wc976cGDq+xlC4zkRQmQmsz0t3PqNTIRKVZXkv6IUjqaKkcA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642371694; a=rsa-sha256; cv=none; b=R+CU/AbmOejJGyQbWh1AIa5oLnWihMV8CTvkugr7uAJiOes0pFpXe9N8V9YdciORvUVPY/ tcdHsxtclDwhv+SI4sHASyiRncYUOCzpZZhDvy0rINg3Q7YS5ZMJDqc2BoPNeyfSoNrVzp CQaaaaawCbirvVJTab75bEO0AdFTIQe9EUuQVYDxH8WKuLPdmCWEE8OSNsWMMFE67EfsW+ hLyiT+RZEYaYZ8eloMoDBLlTe1h/u4A/EWYDdY/RLgHaiLs82CEK8wKt0Pphi/QOLMjwvJ Q9DmULciEF+5c2A+BhVnZktgU8qCMxohXlxrYUXmvOH9+KQ8YQz287gIQLG/uQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.12 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9225238C6A X-Spam-Score: -4.12 X-Migadu-Scanner: scn0.migadu.com X-TUID: Eys/EKGrMlUU Hi, Maxime Devos skribis: > Follow-up to=C2=A0. > > To test, you can do > > $ make check > $ ./pre-inst-env guix refresh -t github -u zig > > and verify that the version and sha256/base32 has been updated > (zig@0.9.0 doesn't work though; patches aren't applying cleanly). Nice, applied! One comment: > +(define (call-with-releases thunk tags releases) > + (mock ((guix http-client) http-fetch > + (lambda* (uri #:key headers) > + (unless (string-prefix? "mock://" uri) > + (error "the URI ~a should not be used" uri)) > + (define components > + (string-split (substring uri 8) #\/)) > + (pk 'stuff components headers) > + (define (scm->json-port scm) > + (open-input-string (scm->json-string scm))) > + (match components > + (("repos" "foo" "foomatics" "releases") > + (scm->json-port releases)) > + (("repos" "foo" "foomatics" "tags") > + (scm->json-port tags)) > + (rest (error "TODO ~a" rest))))) > + (parameterize ((%github-api "mock://")) > + (thunk)))) I think the whole point of having the =E2=80=98%github-api=E2=80=99 paramet= er is that it allows us to mock the HTTP server instead of having to override bindings such as =E2=80=98http-fetch=E2=80=99. I=E2=80=99d have a slight preference for doing that, similar to what is don= e in tests/cpan.scm for instance. WDYT? Thanks, Ludo=E2=80=99.