From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54241@debbugs.gnu.org
Subject: [bug#54241] [PATCH 0/4] 'github' importer gracefully handles rate limiting
Date: Sat, 05 Mar 2022 23:03:31 +0100 [thread overview]
Message-ID: <87wnh8m4zw.fsf_-_@gnu.org> (raw)
In-Reply-To: <5ddbea58affe4bdb9a8c8d138bb25ccac9aca65c.camel@telenet.be> (Maxime Devos's message of "Sat, 05 Mar 2022 10:48:56 +0100")
Maxime Devos <maximedevos@telenet.be> skribis:
> Ludovic Courtès schreef op do 03-03-2022 om 22:14 [+0100]:
>> +(define (update-rate-limit-reset-time! headers)
>> + "Update the rate limit reset time based on HEADERS, the HTTP response
>> +headers."
>> + (match (assq-ref headers 'x-ratelimit-reset)
>> + ((= string->number (? number? reset))
>> + (set! %rate-limit-reset-time reset)
>> + reset)
>> + (_
>> + 0)))
>
> When can this second case happen?
I don’t know if it’s supposed to happen. It’s defensive programming:
better keep going than crash if the server starts behaving slightly
differently.
next prev parent reply other threads:[~2022-03-05 22:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 21:13 [bug#54241] [PATCH 0/4] 'github' importer gracefully handles rate limiting Ludovic Courtès
2022-03-03 21:14 ` [bug#54241] [PATCH 1/4] http-client: Add response headers to '&http-get-error' Ludovic Courtès
2022-03-03 21:14 ` [bug#54241] [PATCH 2/4] import: github: Gracefully handle rate limit exhaustion Ludovic Courtès
2022-03-05 9:35 ` Maxime Devos
2022-03-05 22:00 ` [bug#54241] [PATCH 0/4] 'github' importer gracefully handles rate limiting Ludovic Courtès
2022-03-05 9:37 ` [bug#54241] [PATCH 2/4] import: github: Gracefully handle rate limit exhaustion Maxime Devos
2022-03-05 22:01 ` [bug#54241] [PATCH 0/4] 'github' importer gracefully handles rate limiting Ludovic Courtès
2022-03-05 9:48 ` [bug#54241] [PATCH 2/4] import: github: Gracefully handle rate limit exhaustion Maxime Devos
2022-03-05 22:09 ` [bug#54241] [PATCH 0/4] 'github' importer gracefully handles rate limiting Ludovic Courtès
2022-03-05 9:48 ` [bug#54241] [PATCH 2/4] import: github: Gracefully handle rate limit exhaustion Maxime Devos
2022-03-05 22:03 ` Ludovic Courtès [this message]
2022-03-05 22:16 ` [bug#54241] [PATCH 0/4] 'github' importer gracefully handles rate limiting Maxime Devos
2022-03-06 17:18 ` Ludovic Courtès
2022-03-05 22:21 ` Maxime Devos
2022-03-05 9:52 ` [bug#54241] [PATCH 2/4] import: github: Gracefully handle rate limit exhaustion Maxime Devos
2022-03-05 22:06 ` [bug#54241] [PATCH 0/4] 'github' importer gracefully handles rate limiting Ludovic Courtès
2022-03-03 21:14 ` [bug#54241] [PATCH 3/4] http-client: Correctly handle redirects when #:keep-alive? #t Ludovic Courtès
2022-03-04 12:39 ` Maxime Devos
2022-03-06 21:55 ` bug#54241: [PATCH 0/4] 'github' importer gracefully handles rate limiting Ludovic Courtès
2022-03-03 21:14 ` [bug#54241] [PATCH 4/4] import: github: Reuse HTTP connection for the /tags URL fallback Ludovic Courtès
2022-03-04 12:07 ` [bug#54241] [PATCH 0/4] 'github' importer gracefully handles rate limiting Maxime Devos
2022-03-04 20:45 ` Ludovic Courtès
2022-03-05 9:44 ` Maxime Devos
2022-03-05 21:58 ` Ludovic Courtès
2022-03-05 22:04 ` Maxime Devos
2022-03-05 22:11 ` Maxime Devos
2022-03-06 17:21 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnh8m4zw.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=54241@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.