From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wPI3CzcKWGJ28wAAgWs5BA (envelope-from ) for ; Thu, 14 Apr 2022 13:49:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OB4ZBDcKWGLrYgEAG6o9tA (envelope-from ) for ; Thu, 14 Apr 2022 13:49:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5151471D8 for ; Thu, 14 Apr 2022 13:49:09 +0200 (CEST) Received: from localhost ([::1]:46490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nexyG-0003qH-91 for larch@yhetil.org; Thu, 14 Apr 2022 07:49:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nexxC-000379-Ln for bug-guix@gnu.org; Thu, 14 Apr 2022 07:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nexxC-0007SP-Cf for bug-guix@gnu.org; Thu, 14 Apr 2022 07:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nexxC-0000Wk-81 for bug-guix@gnu.org; Thu, 14 Apr 2022 07:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#54787: importer Bioconductor: no tarball, only Git Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 14 Apr 2022 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54787 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: zimoun Received: via spool by 54787-submit@debbugs.gnu.org id=B54787.16499368551853 (code B ref 54787); Thu, 14 Apr 2022 11:48:02 +0000 Received: (at 54787) by debbugs.gnu.org; 14 Apr 2022 11:47:35 +0000 Received: from localhost ([127.0.0.1]:55500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nexwk-0000Tn-Vt for submit@debbugs.gnu.org; Thu, 14 Apr 2022 07:47:35 -0400 Received: from sender4-of-o50.zoho.com ([136.143.188.50]:21080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nexwi-0000TU-FL for 54787@debbugs.gnu.org; Thu, 14 Apr 2022 07:47:33 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1649936850; cv=none; d=zohomail.com; s=zohoarc; b=kp/M6A6OQ5ZAPnhyn7G0LE8Urbc5oPojfQW8KwhrQB56fYTD2b+1dlY3nv8q9wld8RLiPUo2EmkKLIBQN/9b9ta1bS+eT5F4JSNF2bSjdxsqPOenR6b6WRhJz9pKcWShb41qMAPtdQAkdTeKm3weo1EzwyjIyJDTCVhMOIyY56Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1649936850; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=+rAXGJpxct5Ij19dKkv7N/6onhyaUnz5pjzo8BVMwZw=; b=Vkh1Mw+oGVz/4pKFxslAO7h+T46tl/NppKb0zJGvyhCGVYPOa3igjFEcOlOlFX2kvQ50s03gkxqHJChevWbNHH6lBi4/8P98ENpNGpbBj7YIXJQ5AMotDxL8JrzrF74f7UeE2l9k8ZcXHLCzXYGna4W60SQVTOH40+3NX4wmGEo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1649936850; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=+rAXGJpxct5Ij19dKkv7N/6onhyaUnz5pjzo8BVMwZw=; b=dvL77awij6snInHDr0go9DUfd3Bvr2JytcRqltId0VYRA6Z+Sk7pI+Q5zwwBDx/z SSzM7hCTTMD3E7VwzOYMwXxH6SPo8xnfvKf9WOhHSMei2LmUD3DgAxXLS4JdoExNxUD pplElK5XypRsd2p4oPCxbwD+jMbwNiSrMKv+zcfA= Received: from localhost (152-108-142-46.pool.kielnet.net [46.142.108.152]) by mx.zohomail.com with SMTPS id 1649936849792691.6268642098051; Thu, 14 Apr 2022 04:47:29 -0700 (PDT) References: <868rsf23th.fsf@gmail.com> <874k2zzj9p.fsf@elephly.net> <87ilre5kvk.fsf@gmail.com> User-agent: mu4e 1.6.10; emacs 28.0.50 From: Ricardo Wurmus Date: Thu, 14 Apr 2022 13:43:36 +0200 In-reply-to: <87ilre5kvk.fsf@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87wnfrvqcw.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 54787@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649936950; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+rAXGJpxct5Ij19dKkv7N/6onhyaUnz5pjzo8BVMwZw=; b=a2jKlSry4jKkqPtFBeLpl8TmzFsChIWOgza9+aohJONx+TCnHpI9S947gHyZ/3feb21JF/ Jbay/sceyiXNEPOTs+DVIbpl0bGQBdxjxIl+bWFwdpk/9358jkXv21DoyI/REe5QHeioFq NBK3DJyvzI5R2S7281BPn1qk5FRpo5mED+ZMWGs8oQokBaukZo5iTjjMp8dn8q8UgFIS8C 1EsD2V0cGgbdSrZT+rM9QuaOhYCxMkuGl53N01DhiN+Eub1fyn8rwvQ8+1/Tfqx+XBmfRu T9HGbzpD8J0nTHR15+a5A0tnQMPhqV9yg8jLvIiC6mmQVmY3U5eRhJPQiRdbmw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1649936950; a=rsa-sha256; cv=fail; b=ft6ddd+DkM+Em62kd7zAl7pDF+W6CppjG0gXWv4WtI2wnoL0bhhqelZ6K36ZxdEFk2cQey USNWhiXJpPm1ENK6KZdUNqvK62A6IFakaNE9fFLMFv7BXvboLpD809oFp/Cq7ZO+B7Cylm 8snlg2qcnkBxGZuPFJmpEWec3JfFINYANHf0PyL4mxTuS5x82G0jRDy/FGW6+W+Ca3kYOw gsDvZaCT8A/osMugqfsuCoWN435nTOlhye+u98UvYYU4KC+s4Cm6XwQ1+E1KNQPsS40pbk bMryJKLxhZe9rVhx6HaurZYmiL7gsMMcC9faiN/hjT90yz8MDsj9apPXLaw0zg== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=dvL77awi; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.95 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=dvL77awi; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5151471D8 X-Spam-Score: 1.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: aI68FtVncey/ zimoun writes: > First, note that annotations do not have Git repo; at least not always, > e.g., > > That=E2=80=99s fine. We just ignore annotation and experiment packages, an= d use git only for regular packages. > Second, if we go for something like: > > (define* (bioconductor-git-reference name #:optional > (release %bioconductor-version)) > "Return a for the R package archive on Bioconductor for= the > RELEASE corresponding to NAME." > (git-reference > (url (string-append %bioconductor-git-url name)) > (commit (string-append "RELEASE_" (string-replace-substring > %bioconductor-version "." "_"))))) > > > then, it raises the question: import/cran.scm or build-system/r.scm ? > i.e., do we put a module dependency against (guix git-download) for the > r-build-system or not? > > TeXLive already has a dependency to svn-download, so why not. Yes, I don=E2=80=99t think that=E2=80=99s a problem. We probably should *not* use RELEASE_3_14 (or whatever) as the commit, though, because that is a moving target. We need to resolve to the actual commit and use its hash. I wonder how the updater would need to be changed. It would need to know about the release branch and look for new commits in that branch only. > Well, I am also in favor to break the API and move %bioconductor-version > and %bioconductor-url to (guix build-system r). WDYT? It would > simplify some things (#36805 and #39885), I guess. We tried this before and we couldn=E2=80=99t do this because of a circular reference. > Back to CHETAH, note that > > guix import cran -a git htpps://git.bioconductor.org/CHETAH > > works but it points to master instead of RELEASE_3_14. Well, I am not > very familiar with the Bioconductor workflow for their release. That=E2=80=99s because the importer doesn=E2=80=99t let us specify a differ= ent branch. We should add that, but it=E2=80=99s strictly separate from the migration w= e=E2=80=99re about to embark on. > Last, using this in gnu/packages/bioconductor.scm, > > (define-public r-chetah > (package > (name "r-chetah") > (version "1.11.2") > (source > (origin > (method git-fetch) > (uri (bioconductor-git-reference "CHETAH")) > (file-name (git-file-name name version)) > (sha256 > (base32 "021v5831zqdy4pirfsb35kbnz8kmz4lxqc4cwi55qgd6r081xlgh")))) > (properties `((upstream-name . "CHETAH"))) > (build-system r-build-system) > (propagated-inputs > (list r-biodist > r-corrplot > r-cowplot > r-dendextend > r-ggplot2 > r-gplots > r-pheatmap > r-plotly > r-reshape2 > r-s4vectors > r-shiny > r-singlecellexperiment > r-summarizedexperiment)) > (native-inputs (list r-knitr)) > (home-page "https://git.bioconductor.org/packages/CHETAH") > (synopsis "Fast and accurate scRNA-seq cell type identification") > (description > "CHETAH (CHaracterization of cEll Types Aided by Hierarchical classi= fication) is > an accurate, selective and fast scRNA-seq classifier. Classification is = guided > by a reference dataset, preferentially also a scRNA-seq dataset. By > hierarchical clustering of the reference data, CHETAH creates a classific= ation > tree that enables a step-wise, top-to-bottom classification. Using a nov= el > stopping rule, CHETAH classifies the input cells to the cell types of the > references and to \"intermediate types\": more general classifications th= at ended > in an intermediate node of the tree.") > (license #f))) > > it just builds with, > > ./pre-inst-env guix build r-chetah > > > > WDYT? Neat :) --=20 Ricardo