From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4IQnBfks/2K3AAEAbAwnHQ (envelope-from ) for ; Fri, 19 Aug 2022 08:26:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UAEsBfks/2KpKQEA9RJhRA (envelope-from ) for ; Fri, 19 Aug 2022 08:26:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B6F2920445 for ; Fri, 19 Aug 2022 08:26:00 +0200 (CEST) Received: from localhost ([::1]:44238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oOvSB-0002pv-Ib for larch@yhetil.org; Fri, 19 Aug 2022 02:25:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oOvOO-0000Sn-BN for guix-patches@gnu.org; Fri, 19 Aug 2022 02:22:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oOvOM-0001ox-MK for guix-patches@gnu.org; Fri, 19 Aug 2022 02:22:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oOvOM-0001fv-Ha for guix-patches@gnu.org; Fri, 19 Aug 2022 02:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57280] [PATCH 0/3] Add documentation-files argument to emacs build system. Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Aug 2022 06:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57280 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 57280@debbugs.gnu.org Received: via spool by 57280-submit@debbugs.gnu.org id=B57280.16608900936400 (code B ref 57280); Fri, 19 Aug 2022 06:22:02 +0000 Received: (at 57280) by debbugs.gnu.org; 19 Aug 2022 06:21:33 +0000 Received: from localhost ([127.0.0.1]:57265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOvNt-0001fA-1g for submit@debbugs.gnu.org; Fri, 19 Aug 2022 02:21:33 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:34939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oOvNn-0001eq-5R for 57280@debbugs.gnu.org; Fri, 19 Aug 2022 02:21:31 -0400 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id 288BBC0005; Fri, 19 Aug 2022 06:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1660890080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8XqHnNKh4599ewmryIP4rJBih7HXs/MX3t+dFB+NUt8=; b=XN7Sm4i3Xq5spb/g/TC3aMlbZIuVufbi7gQpNaWL5AAMSb12FxAvldxl33IhXbQ96RRrin 2Jbhydg8VJ3ufsVYHwFJczlIvmseGNtNSqFwBZtEy1Is0AfsWkeVYuLcSo5tjdqDX23Hc4 kkPayDQFvgZbacY/MtEygNE7HPFgWuoRIRFlQFO/4VKLWlSUD10NzBTGcdVvPdxthndTsI SWAvObuKEZ1mpZATfMysU6VOBN43Cw5GLt7aIMCSS1rBgCLCMGOPtcM1qBfBK3jCjk5M7E 0yQK5IkT0doW9Rwn3gsGOeZihfgbp2YEiZBi+xsf34BmFDK/Cts7lVXTPdKt3Q== From: Andrew Tropin In-Reply-To: <0f6169482efaaf9f0caac9810841e38c9c569e66.camel@gmail.com> References: <87wnb5lhyr.fsf@trop.in> <107d9c475d47842d67db4f0a7d85d63ae11f9f3c.camel@gmail.com> <87k074gb69.fsf@trop.in> <0f6169482efaaf9f0caac9810841e38c9c569e66.camel@gmail.com> Date: Fri, 19 Aug 2022 09:21:14 +0300 Message-ID: <87wnb47nz9.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660890360; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8XqHnNKh4599ewmryIP4rJBih7HXs/MX3t+dFB+NUt8=; b=TkOD+hC3oecmUhtCl41UeB/ay0hPvVrQ9w0bRP+RnpcPwxpnq99znJI2v5YJbqAqpC1lwM 6jLP92/ZIb8i63wLRylxbQe2+fYhg0dM2UJnjeDmg6m2vbhuMxH58OVnKTElFeeOXH2a9i v2Ox46ThfPDmE4HCOAKrkkQY5JXg/Cgd2iZ+esdoC2X6pwHf3vJfEEGvfTSWuoOcpbBIyn /64dKuAkFWEtISgKCXmwm2BOY7yNolR0XLhO8mHBSiwmd5+kQIJm+YqUa3wpzrr4jTQjH1 7ZDIXBbYXW+EBMqOK10clzVs79Qo9MLrTjpqVIzRJphRBRiBHTy0XaWDf5lvfQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660890360; a=rsa-sha256; cv=none; b=NBGCY/8WgwY/WAK/908fdzK9E3M3ixmsCUeNk3CGRvPu37nGkZunW8KNzewq9kblaota8M F74cRAHC0uKRnzEzjJBoMdu5Qq2XkOjy92ji7jdDxMVXlMML83GLnJIrkSYOdgA0S/sFeu f5KWn+rLx7Fe2hjfnsPo7qqAtLE9KLxDE7zyxG/q0B14lTGasmmhttWLwPpMMEJF4ZlA+0 +vwMpUEx8sAFZ4fcCTmBEB8/lCH+kplUV/aRIpcGDiR+r3Rb5Y3ws5UHYRVbxBS/ZwpuMH gbh1VFRmZpOwZn4K2L4AquQsqk5SgMJTyAAJvipn9rmo7Xu020ZRviF5Ojz09w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b=XN7Sm4i3; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.05 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop.in header.s=gm1 header.b=XN7Sm4i3; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B6F2920445 X-Spam-Score: -2.05 X-Migadu-Scanner: scn0.migadu.com X-TUID: MYoecQM3dznr --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-08-19 06:19, Liliana Marie Prikler wrote: > Am Freitag, dem 19.08.2022 um 06:33 +0300 schrieb Andrew Tropin: >> On 2022-08-18 20:31, Liliana Marie Prikler wrote: >> [...] >> > Am Donnerstag, dem 18.08.2022 um 17:50 +0300 schrieb Andrew Tropin: >> >=20 >> [...] >> > > +(define (default-texinfo) >> > > +=C2=A0 "Return the default texinfo package." >> > > +=C2=A0 ;; Lazily resolve the binding to avoid a circular dependency. >> > > +=C2=A0 (let ((texinfo-mod (resolve-interface '(gnu packages texinfo= )))) >> > > +=C2=A0=C2=A0=C2=A0 (module-ref texinfo-mod 'texinfo))) >> > > + >> > > =C2=A0(define* (lower name >> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:key source inputs native-inputs outputs sy= stem >> > > target >> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 documentation-files >> > I don't think hard-coding this list is useful.=C2=A0 Instead, it would= be >> > nice if we simply used find-files with the right pattern, and use a >> > binary switch as in meson-build-systems #:glib-or-gtk? >>=20 >> It's not clear how to find a documentation file heuristically, it can >> be README, DOCUMENTATION, README.org, docs/MANUAL.org docs/PACKAGE.texi >> or anything else, morevover a few of them can be present at the same >> time and I'm afraid it will be a very tough task to understand which of >> them to use. > I think it's possible to cover most of those with heuristics. For the > rest, we can still override the phase or just rename the file to > something our heuristics handle. > If there is an info file(s) do nothing. If there are texinfo file build them. If there are no texinfo files build README.org or README. Something like that? Will play around with it a little bit and will publish v2 next week. >> >=20 >> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 (texinfo (default-texinfo)) >> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (emacs (default-emacs)) >> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:allow-other-keys >> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:rest arguments) >> > > @@ -77,6 +85,7 @@ (define private-keywords >> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ;; Keep the standard inputs of 'gnu- >> > > build- >> > > system'. >> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ,@(standard-packages))) >> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (build-inputs= `(("emacs" ,emacs) >> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ,@(if (null? documentation-files) '() >> > > `(("texinfo" ,texinfo))) >> > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 ,@native-inputs)) >> > We should probably append rather than prepend implicit inputs. >> > In fact, doing so for emacs itself also means that people could >> > prepend their own emacs if emacs-minimal is not enough rather than >> > needing a transformer. >> >=20 >>=20 >> I thought #:emacs and #:texinfo arguments are enough to specify >> custom emacs/texinfo inputs. > And what if any of the documentations needs emacs-org rather than the > org included by emacs-minimal? Spamming keywords is not helpful. This is a good point. I'll reorder inputs. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmL/K9oACgkQIgjSCVjB 3rDIdw/8CvqSiAfvJ/1PZ7z6P/PVq+6hbbNYOWTtWD/DKqfbdQ6PZubkQTwQ6pbk njgkUvCic9J4hDHz8cOQQE32iOQxHVUka1Tv/eUDogOu/9briV9+e87WSjYx+qw/ QOIMWmzulsn2ddLHEu+GU7aO3/T7CSI0ogxu0Sr0a4EKt8+fJS6XnGwEWyThADnk qm77Wzf9AjhASJxt2cbitutRynE2IL2Hy8wcIhxpQ+cKzGB3pCApus2MyQtGvyKz I/aofunlakzdSvSCIDRWGnqfitXBnrgDsR6EVjCOZYkioxoFK2qzXqmJN9O0yAoJ v4uBCAywqBX3t+m6kvq3shqVwfV4pk+kEyMeIKp9Nu8/hhXjIG7gy7UGZYXxfDxc K8mO2vHGTbtNrblB8zwniZ5wtItbUmyUbZFpnqPO9uk/14WyaZKwCXCx36VP/F0o /7PYHvyr1zN7bOcen56FgZ6n25b7ie1UqC6cEmCsJUBUxG8Qs4BHgjVQixseZdJb fdvx3Bjyy1Mz81JwFT0yqg5TOfH0e9PmxWhfORYKIyDL933CUHl2/MDfggVjTOWR SHKwgv6mXtfQsgLz9q4TSdUoopcYItJ2NJWfVDvvud4TyFGfXsnd7N7VYRpqX9/W FbZiAKWCs9zKf1RSB4EgKT39ND0P+pEpNKU0SjbbdCmhFh8pTN4= =1zUa -----END PGP SIGNATURE----- --=-=-=--