From: Christopher Baines <mail@cbaines.net>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 57671@debbugs.gnu.org
Subject: [bug#57671] [PATCH] gnu: Add mpdevil.
Date: Sat, 10 Sep 2022 10:50:04 +0100 [thread overview]
Message-ID: <87wnab1rqs.fsf@cbaines.net> (raw)
In-Reply-To: <932cec629b2a3cdc01d2eb006eead634b3fd417f.camel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2333 bytes --]
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> * gnu/packages/mpd.scm (mpdevil): New variable.
> ---
> gnu/packages/mpd.scm | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
There's one lint warning that can be fixed, but apart from that this
looks good to me.
> diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
> index 046471f32d..c7d9b4646c 100644
> --- a/gnu/packages/mpd.scm
> +++ b/gnu/packages/mpd.scm
> @@ -523,3 +523,38 @@ (define-public mcg
> album-experience.")
> (home-page "https://gitlab.com/coderkun/mcg")
> (license license:gpl3+)))
> +
> +(define-public mpdevil
> + (package
> + (name "mpdevil")
> + (version "1.7.0")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/SoongNoonien/mpdevil")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32 "1va8fqlz8qb68gvacnzmp4asnipi11316n1cv2wb41sml9d7v00j"))))
> + (build-system meson-build-system)
> + (arguments
> + (list
> + #:glib-or-gtk? #t
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'glib-or-gtk-wrap 'python-and-gi-wrap
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((prog (string-append (assoc-ref outputs "out")
> + "/bin/mpdevil")))
> + (wrap-program prog
> + `("GUIX_PYTHONPATH" = (,(getenv "GUIX_PYTHONPATH")))
> + `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH"))))))))))
The linter says:
"bash-minimal" should be in 'inputs' when 'wrap-program' is used
> + (inputs (list gtk+ python python-mpd2 python-pygobject))
> + (native-inputs (list `(,glib "bin")))
> + (home-page "https://github.com/SoongNoonien/mpdevil")
> + (synopsis "Music browser for the MPD")
> + (description "mpdevil is a music browser for the Music Player Daemon (MPD),
> +which is focused on playing local music without the need of managing playlists.
> +Instead of maintaining a client side database of your music library,
> +mpdevil loads all tags and covers on demand.")
> + (license license:gpl3+)))
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2022-09-10 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 8:48 [bug#57671] [PATCH] gnu: Add mpdevil Liliana Marie Prikler
2022-09-10 9:50 ` Christopher Baines [this message]
2022-09-10 15:25 ` bug#57671: " Liliana Marie Prikler
2022-09-10 9:57 ` [bug#57671] " ( via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnab1rqs.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=57671@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.