From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uJ8RABerfGMXxQAAbAwnHQ (envelope-from ) for ; Tue, 22 Nov 2022 11:57:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uEu3OharfGPLXwEAG6o9tA (envelope-from ) for ; Tue, 22 Nov 2022 11:57:26 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5408727C0C for ; Tue, 22 Nov 2022 11:57:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxQxd-0002B0-7I; Tue, 22 Nov 2022 05:57:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxQxa-0002An-64 for guix-patches@gnu.org; Tue, 22 Nov 2022 05:57:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxQxZ-0001r2-U3 for guix-patches@gnu.org; Tue, 22 Nov 2022 05:57:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxQxZ-0000gp-I1 for guix-patches@gnu.org; Tue, 22 Nov 2022 05:57:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#57608] Upstreaming KDE Plasma and rest of packages Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Nov 2022 10:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57608 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: phodina Cc: maxim.cournoyer@gmail.com, ludo@gnu.org, maximedevos@telenet.be, mail@brendan.scot, leo@famulari.name, marekpasnikowski@protonmail.com, h.goebel@crazy-compilers.com, 57608@debbugs.gnu.org Received: via spool by 57608-submit@debbugs.gnu.org id=B57608.16691146182641 (code B ref 57608); Tue, 22 Nov 2022 10:57:01 +0000 Received: (at 57608) by debbugs.gnu.org; 22 Nov 2022 10:56:58 +0000 Received: from localhost ([127.0.0.1]:49965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxQxV-0000gT-8t for submit@debbugs.gnu.org; Tue, 22 Nov 2022 05:56:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxQxQ-0000gE-Ci for 57608@debbugs.gnu.org; Tue, 22 Nov 2022 05:56:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxQxH-0001pL-0G; Tue, 22 Nov 2022 05:56:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=IKe3hPWZaPx4z4SJtGzTdVzxEIpXV49VYrvwGMfrmQo=; b=IpeflM0nLs7EwE37x6eZ KthauXAZA73twdvhUuTEuX26V57Q+KRXdc0p5A4EwD3NZ86AZ38O7P2LinsKPB2jerzo04dFv6B6r /ulM+/HJz0CVmL8NOMyDdG4xcTivqjoxsoPpTCMIefKnE32VakVejFH46qmZ17u71gmttUyuSo6Hs rikLO32l9+KeTVY8+G1NaESq3yhWu58g2WNdOS4bxoIIs6U5HzdndCw2spqb6if/NMiC50ioeCmBW dbuLGYnzmdC8LFYaEQDEUKhnqDuEHL+IsRialKYHoGkvQ8wZQ9yl+RwnQDMaty+lmmnaM3AHMrz+2 WCUNxO6WTcpD5g==; Received: from [84.214.173.6] (helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxQxG-0001GH-9y; Tue, 22 Nov 2022 05:56:42 -0500 From: Marius Bakke In-Reply-To: References: <87h70wap7m.fsf_-_@gnu.org> <_9i_X2elmnmVduuEMWiqx4qwh8Jlu6wffrzRfrk0M2boZ-SINJbuBmUDidz8oMTRJhaeeNmsNGvDgNTbPRLyCy1EcDAYVk6nwNlliDDWy6M=@protonmail.com> <87zgckypvd.fsf@gnu.org> Date: Tue, 22 Nov 2022 11:56:38 +0100 Message-ID: <87wn7nz28p.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669114646; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=IKe3hPWZaPx4z4SJtGzTdVzxEIpXV49VYrvwGMfrmQo=; b=uS4PtCExPL/x+bJEtbMOTxDeLcXerZ/6UuXvpR53pRc0X1GGJwRjLUVn08jiO+an+kaib0 fgtT7ljdZxIHQuVZIgu5R1Dgth87QkveVYPI7rVrWig0pP5kAyng1lmeUbjO4SXO2BsK+e 5na1+1bH9GxRkTeuU0e5cOcfSXME8IsTOmrQj97WGNHc3xij5FPFLAINxSSAMz40gPBoGP nt8x9gOeKbQ+BmsKV51TLpo183NCsKXGg/LkkgIzjPqGJiv9iqO2g+OOLOkxYvGwwNITAS Icsekseyw4Us9qxFhHQzV2aa2QdpZJYr2GQfw3TupP9fHmt5FvG0jZnPVLQUfA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669114646; a=rsa-sha256; cv=none; b=sFpIPQ4mlMDuP1cYL2ityKAfOLvG5a1K/0T8bEL7PoQxmG6CdWZ6xs4c/I80SYMQG4AAIz v1PJaIigohNh2WUgg8ChrR8DqYHPKSXYVNhN7RL61G8JrkZhK/FohrNP7CVw45EVexFrjw MoyZbTSTM/EArVuq8Il83WOmo9AtlVIjm9X47wHnWzvaLCO+BXZzqR+n7n6tfqJUVUAuvK End2N9Ig4PzuH+Qf/grGObD5EyRFUTDOzkftoreGa9+Nz0CM3++n98ceTUYce55zVmf+qB 8khCIxpk4eJz2Yg9Pyw5wW+NYOaSqWmSiHmdh5XH0ijcyi0LyH6L5G2YBXCT3A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IpeflM0n; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IpeflM0n; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5408727C0C X-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: hIvnL9o8z0IK --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable phodina skriver: > Hi Marius, > > Thanks for the review and push to master! > >> Awesome work Petr. :-) >>=20 >> I went through the branch and applied most of the patches. With a few >> changes: >>=20 >> * shortened multi-line URLs > > Sorry I used the formatter ('guix style') and it set the URLs as such). Right. It still has a few quirks that needs to be inched out... >> * added (file-name ...) for git sources >> * removed knetworkmanager -- AFAICT it is identical to networkmanager-qt >> * switched to git-fetch for packages that were downloading tarballs from >> the KDE GitLab. This is because such autogenerated tarballs are not >> stable: they may get regenerated with a different hash. > > Is this issue somewhere described? I've lately used more tarballs to git = download on other packages. Is the issue connected with any Gitlab/Forge or= just the KDE and the release scripts? We have this problem with all the forges. There have been many-a bug report about it, and the linter also warns about it (apparently for GitHub only, that could be improved). >> * dropped the !! commits >> * Minor tweaks to synopses and descriptions > > My apologies as I noticed there were few packages with wrong license or m= issing description. Oh, I did not license audit these packages as I assumed all the KDE stuffs were using the same license. Can you submit patches to update the licenses? >> * A few commits had a random edit to a different package: I reverted >> those edits. An example: >> https://github.com/phodina/guix/commit/5eaa9c49a78eed419db7847668a55c079= bad5b71 > > Caused due to rebasing and working on a large patchset. I'll split it nex= t time and sent it by smaller parts. No worries; this is what reviews are for. :-) >> * Removed use of direct variable references, i.e. #$qtbase. Always use >> (search-input-file ...), (search-input-directory ...) or as a last >> resort #$(this-package-input "foo"). > > Thanks for the hint. I'll fix all the packages where I use this syntax! >=20=20 >> * Skipped commits that would trigger a lot of rebuilds, e.g. gpgme. > > I'll submit it in new ticket. Note: I added a new version of gpgme and used it for the packages that require it. We already have the newest version on 'core-updates'. >> * Skipped cosmetic commits such as using G-expressions in Qt packages; >> mainly because of rebuilds, but also because they were not indented >> properly. Some also introduced direct #$variable references. > > I'll fix the issues and submit it as a new ticket. Great. >> * Dropped the plasma-desktop-service since it was not working for me. > > Should we keep this ticket open to package also the plasma-desktop-servic= e? > I'll try it now and see what causes the Plasma not to work. Let's keep this ticket open until we get past the finish line. :-) >> For later reference, when adding patches, please add a sentence or two >> at the top of the patch describing what it does. I did not edit the >> patches (except for a long file name), because I did not know what it >> was for. Presumably you did; future you will thank you! >>=20 >> Pushed to 'master' as fe3be8d5e0..82804298ad ! > > Sorry I didn't intend to add so many changes and it's been a challenge th= at taught me some new lessons. It's easy to get lost in a huge patchset. You did great! > I'll definitely add more description for the reviewers and keep it smalle= r so I doesn't take long time to review. Bite-sized PRs are more likely to get through, but I'm not sure we had a lot of choice here given the scope of the project. Ultimately someone just needs to muster enough courage to push it forward. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCY3yq5g8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHdlmQD/QjugwqcWILFzJ+hlRXSny1St5DXqeUmsnEIC ZyNPbK0BALF1YyTJtmV9DgJcLL5JcqvJauf2nJSoPHSOeLhhQdEI =dsMV -----END PGP SIGNATURE----- --=-=-=--