From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6ILgJ5sIl2PTSAEAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 11:55:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uDHaJ5sIl2PETQAA9RJhRA (envelope-from ) for ; Mon, 12 Dec 2022 11:55:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7475CE271 for ; Mon, 12 Dec 2022 11:55:23 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4gSe-0003WG-9P; Mon, 12 Dec 2022 05:55:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4gSc-0003VK-2D for guix-patches@gnu.org; Mon, 12 Dec 2022 05:55:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4gSb-0002xN-Pr for guix-patches@gnu.org; Mon, 12 Dec 2022 05:55:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4gSb-00008w-Ij for guix-patches@gnu.org; Mon, 12 Dec 2022 05:55:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59513] [PATCH v2] doc: contributing: Tweak the Commit Policy. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Dec 2022 10:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59513 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Liliana Marie Prikler Cc: 59513@debbugs.gnu.org Received: via spool by 59513-submit@debbugs.gnu.org id=B59513.1670842458533 (code B ref 59513); Mon, 12 Dec 2022 10:55:01 +0000 Received: (at 59513) by debbugs.gnu.org; 12 Dec 2022 10:54:18 +0000 Received: from localhost ([127.0.0.1]:52180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4gRt-00008X-Na for submit@debbugs.gnu.org; Mon, 12 Dec 2022 05:54:18 -0500 Received: from mira.cbaines.net ([212.71.252.8]:42042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4gRr-00008R-Ve for 59513@debbugs.gnu.org; Mon, 12 Dec 2022 05:54:16 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:3a91:a0a4:ecee:f157]) by mira.cbaines.net (Postfix) with ESMTPSA id D5FE827BBE9; Mon, 12 Dec 2022 10:54:14 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 1b4b2463; Mon, 12 Dec 2022 10:54:14 +0000 (UTC) References: <20221123104946.29480-1-mail@cbaines.net> <20221208112051.5019-1-mail@cbaines.net> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines Date: Mon, 12 Dec 2022 10:49:59 +0000 In-reply-to: Message-ID: <87wn6wq4dl.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670842523; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=ScjhRnnM3SeWkCf1EuzGdkwOaDJg6A+91Nxf9qHGPSI=; b=d2QAd5TXJnEx56sYvCgeUiXj6Ea/yOMKGxh5/Hl9b78PYYz5E8RXOlsd7mImuCH5PJu0hY fNfm++OyHKAZ185GVO4nnMZ7NSV85NgjOnRPiFgTyh/JX4XxgXESyfh+am6ArEYG/nTGdD SXLIrkCLh68BJMg/vffh6XamjUL0Tz+tr619JH/SxGdXx7k6e5yPNpb0MEdzZA7Rk7d7S+ vYGI52zfsSISrP53+hcBxkV20VEmTYlyEXajyQJ9bVFvd/lHQp/E2RFO3XTXTdS5+MJBVn 5klp7+uIYZPyA/kbPLMjS1fJWVN8apB7JEbJzekwu2cFn6nuo7zwtcA3fg0LRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670842523; a=rsa-sha256; cv=none; b=oQS9qgCdIlMiY/81wmArnDX9plnVTEdRQh1Uk6+7t7+CsCsgckg114EcCwprd6QixHXyzC UN+0op5vrN9DXwKISOvFxp2G4RO1pFjHXK2YU9qxM9IIds+Kboos10fvDtXWxxqt0kdd7p QYZHm9ynAnDGUk4RtbRHKAltupTo2fZvUJ9Ihma4Gtw6JgxXOBxGuYxW0lI47uXvQ9Ixfk GCFBV2iddObCPm/s4BgpLEjYGnKmXKctlFDPSEaf8/LBIYOfuGc0og7iAULpR0HQIXWonf fn8YdcpxDUNjONHjFy8PgqDdyUbBgqYfwaM2E0sk4aKQ0nak8byMSxgZP9TG2A== X-Migadu-Spam-Score: -5.06 X-Spam-Score: -5.06 X-Migadu-Queue-Id: 7475CE271 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: PBsGLQUdWh6N --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Liliana Marie Prikler writes: > Am Donnerstag, dem 08.12.2022 um 11:20 +0000 schrieb Christopher > Baines: >> Add more examples of when it can be appropriate to push changes >> without >> review, as I think this can be appropriate in the case of trivial >> changes (as >> mentioned before), but also non-trivial fixes. >> >> No longer suggest pushing simple new packages or package upgrades >> (that don't cause lots of rebuilds) without sending to guix-patches. >> Now there's some automation for testing changes sent to guix-patches, >> sending changes there before pushing can mean that more rigerious > > rigorous Thanks, I've fixed that locally now. >> testing takes place and help speed up substitutes becoming available. >> This is true, even if no human review takes place. >> >> Only suggest waiting one week for review for simpler changes, wait >> two weeks >> for more significant changes. >> >> Also, reorder some of the information in this section so it's grouped >> together >> better. >> >> * doc/contributing.texi (Commit Policy): Tweak. >> --- >> =C2=A0doc/contributing.texi | 41 ++++++++++++++++++---------------------= -- >> =C2=A01 file changed, 18 insertions(+), 23 deletions(-) >> >> diff --git a/doc/contributing.texi b/doc/contributing.texi >> index 6a8ffd6524..d2e7abba98 100644 >> --- a/doc/contributing.texi >> +++ b/doc/contributing.texi >> @@ -1824,23 +1824,26 @@ It additionally calls @code{make check- >> channel-news} to be sure >> >> =C2=A0@subsection Commit Policy >> >> -If you get commit access, please make sure to follow >> -the policy below (discussions of the policy can take place on >> +If you get commit access, please make sure to follow the policy >> below >> +(discussions of the policy can take place on >> =C2=A0@email{guix-devel@@gnu.org}). >> >> -Non-trivial patches should always be posted to >> -@email{guix-patches@@gnu.org} (trivial patches include fixing typos, >> -etc.).=C2=A0 This mailing list fills the patch-tracking database >> -(@pxref{Tracking Bugs and Patches}). >> - >> -For patches that just add a new package, and a simple one, it's OK >> to >> -commit, if you're confident (which means you successfully built it >> in a >> -chroot setup, and have done a reasonable copyright and license >> -auditing).=C2=A0 Likewise for package upgrades, except upgrades that >> trigger >> -a lot of rebuilds (for example, upgrading GnuTLS or GLib).=C2=A0 We have >> a >> -mailing list for commit notifications (@email{guix- >> commits@@gnu.org}), >> -so people can notice.=C2=A0 Before pushing your changes, make sure to r= un >> -@code{git pull --rebase}. >> +Changes should be posted to @email{guix-patches@@gnu.org}.=C2=A0 This >> mailing >> +list fills the patch-tracking database (@pxref{Tracking Bugs and >> +Patches}).=C2=A0 It also allows patches to be picked up and tested by t= he >> +quality assurance tooling; the result of that testing eventually >> shows >> +up on the dashboard at >> +@indicateurl{https://qa.guix.gnu.org/issue/@var{number}}, where >> +@var{number} is the number assigned by the issue tracker.=C2=A0 Leave >> time >> +for a review, without committing anything (@pxref{Submitting >> Patches}). >> +If you didn=E2=80=99t receive any reply after one week (two weeks for m= ore >> +significant changes), and if you're confident, it's OK to commit. > > I would reword that so > (not significant =E2=88=A7 confident =E2=88=A7 qa_green) =E2=86=92 good= after 1 week > whereas > (not significant =E2=88=A7 confident =E2=88=A7 qa_unknown) =E2=86=92 go= od after 2 weeks > and significant changes should anyway take 2 weeks. While I like the intent here, for the moment I prefer a simpler policy. Maybe we can move in this direction when the QA tooling is more usable and reliable. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmOXCFZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcrMA//VuXNnSu3n8qYOHaQDrgrw2XkyojPJyEZ 1fvqPxhHJ6hcTCfEQqfMhhGbbZv+zjdnBLWLbU3cupO9bP00rblVJjJzxY9RG0i8 LBq4No7ZvpdMo2LIAMRZds33l/3e5NanA9vIuK/0EL+Ah/smxjk+GDbeuSTsP0cW YJ2jPpJynsRnCVuAZHtEWYrZ22PqTcVPwos997UIj7MB2bNx/moSNq/8UN74gyXs 3P6AWAwYTH7a/33LPUZlKeVY/T9ZbGs1IARfc6d3jwmVyOQlX2ZP8grG2udTUuM3 Kt/EmIp+g66B7nXuOaJjO1vHv37GUoK8/vhlJ5H6xxo6/N/n4pXzH9a/zW3wRnLt 8olJN7PNZ5w/8mBesjsefCzW80EdC2gFDmjYUdMrgGwJA19orN2QD/fplUSzxEOq Dg06mQMATH4gfd9BJf3xfk7L5KDw2FtRGZo/zpZmoRCGouOTavFEFF3RlgjUZLMi /M+CUBJOWRvnnWSIBD96hjHwnKxoBAMu5dGL+QXQ9v72LnYg4QLOyiNeiSdkixzA XA65ytJsgwAYHDyswpkw7pePA1v+C3ks6N6mjMVb+7bm7kBhJ6bCsFrzAs/F3/BJ zq9OQsGeuo4je4ELpf2SYgfYvumL3Hgcf715ElT+ufKtRTh6NwxTmZXvbJxsDVDK oPydVN98+Ls= =+Pke -----END PGP SIGNATURE----- --=-=-=--