From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sLbpIj39m2N7xAAAbAwnHQ (envelope-from ) for ; Fri, 16 Dec 2022 06:08:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QNXgIj39m2NWKwAAauVa8A (envelope-from ) for ; Fri, 16 Dec 2022 06:08:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2CA311221F for ; Fri, 16 Dec 2022 06:08:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p62x3-0008Nw-8k; Fri, 16 Dec 2022 00:08:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p62x1-0008N4-GT for guix-patches@gnu.org; Fri, 16 Dec 2022 00:08:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p62x1-0005GA-7r for guix-patches@gnu.org; Fri, 16 Dec 2022 00:08:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p62x1-0003Q1-3n for guix-patches@gnu.org; Fri, 16 Dec 2022 00:08:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Dec 2022 05:08:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60069 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: me@tobias.gr, 60069@debbugs.gnu.org, 60068@debbugs.gnu.org Received: via spool by 60069-submit@debbugs.gnu.org id=B60069.167116725413110 (code B ref 60069); Fri, 16 Dec 2022 05:08:03 +0000 Received: (at 60069) by debbugs.gnu.org; 16 Dec 2022 05:07:34 +0000 Received: from localhost ([127.0.0.1]:47008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p62wY-0003PN-8w for submit@debbugs.gnu.org; Fri, 16 Dec 2022 00:07:34 -0500 Received: from mail-qt1-f169.google.com ([209.85.160.169]:39667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p62wV-0003PE-Sd; Fri, 16 Dec 2022 00:07:32 -0500 Received: by mail-qt1-f169.google.com with SMTP id s9so1925622qtx.6; Thu, 15 Dec 2022 21:07:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=+ruKiTPXMUnBVcGs5EQ6S/DYQCNXb1vLfFrgTcjzUrc=; b=gbDt0dDisxym1G8QPVTZEc4YQXShBsYxkz4/nkJc5lFqGts5P0G4tXNbxdJGWxGgse 6sFq3w23qzzHl1vEbCoiQS1VeIuStgAf59W2Nz7Oq33kLTCXjzBKgaOxhsUUXtLmgIfm 2uaWNRqMCxprawPMjE+K9XcSu7M0clYGdUpYScfm/ixKVsxFQy9OQY+hlJt3xtMKP6Ja nYxlsUfkRuYObarDWRNgWd7QiB4He6HlCICWZY64Rj28Kde29KeoZ0fw91ZcH6nHtXMB XnHJ6z90euHLhpu0w2VoDq0gAh2SRYsrWWKYNCl5C1g8hIo8DkIkuoZR2//4cUeIpJOy MHbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+ruKiTPXMUnBVcGs5EQ6S/DYQCNXb1vLfFrgTcjzUrc=; b=JxEEV+MMN7nntsb/XOk+t5r2LOCv9PtPVfErPdNNWOX/stu+Xte+XnN4wsvA7Ji9Cs KO811seUpd3KEu1QqIpTtHxPusce4x9J0P4dfUjg2Od6LXo1rPY8jVov6Noo5ekG4pz7 U+yvQElS2Gq3WRrak6mtcPygUJhbKX6B9K4/QTUIPPgUNuZWUivqG6F/ZTRYdrBgqRaV YSH/gq702OOey4x1n53rjuHEffojX0A1oNV//tEBcuHh7+Ev7Kjr8/NNwacG7CPdPoL5 XAjZSJuR/jkx9Wq93p1RH5I02MMvToOySenICAScLlbnmtxgO2vT2AyR6JWTR6mi5yq7 aEoA== X-Gm-Message-State: ANoB5pkBapyf9xAWNcE1A2lgOiIZK3PQ9JLNLp1PzjEmFUzMu2Tcn/A3 6NG6fjyk0GtFrXT1FM+OEt0= X-Google-Smtp-Source: AA0mqf7TOnSVZfAbeQWKei+AxDEdp100pfU5z/EIMfOtnE7ceCxWFBfemjOyrg+ipQB69gJbwSZdnA== X-Received: by 2002:ac8:5ec6:0:b0:3a7:eab2:e461 with SMTP id s6-20020ac85ec6000000b003a7eab2e461mr38684856qtx.25.1671167246412; Thu, 15 Dec 2022 21:07:26 -0800 (PST) Received: from hurd (dsl-10-129-63.b2b2c.ca. [72.10.129.63]) by smtp.gmail.com with ESMTPSA id t1-20020ac865c1000000b003a4f22c6507sm733994qto.48.2022.12.15.21.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 21:07:25 -0800 (PST) From: Maxim Cournoyer References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> <20221214204640.16879-2-maxim.cournoyer@gmail.com> <87wn6sohh7.fsf_-_@gnu.org> Date: Fri, 16 Dec 2022 00:07:24 -0500 In-Reply-To: <87wn6sohh7.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 15 Dec 2022 15:43:16 +0100") Message-ID: <87wn6saqcz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=gbDt0dDi; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671167293; a=rsa-sha256; cv=none; b=aOo1/Ns4LRctYlAkKWfRX9tmwtDZ42ynf78r4Gt4lbhtkNNElAJt2vLPFlQLJg8UfnYttE Z45orIcN93V9d5CzgANoHf5p8EfnYxOyY7zo1nL/8a7Kk03+izdVV1kZEzST8ibx0kv7fu X15OhLmqKoMEfgR+o8jDVyLIv8wK1eNwlkJ9oS6GazxDUn6ct55qyntwg7OmhckRWcHHjm eFnOw2acy2Qs91l14q9YKFzWOjTXjWutd6SW+BxRwJwaxOHXM9I/LXs0oELhm0fKIsIAbU HJcWVVCf5w+o731sNGJO1FVveFot20MPhiRVpdktXSuoLF8YCi454rms9uIMew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671167293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+ruKiTPXMUnBVcGs5EQ6S/DYQCNXb1vLfFrgTcjzUrc=; b=WpEAqtQ7AwDlnFJ7k7kn4EYAjETMDY12p/FATMYEVP13VxRWFFyuNgprdogv1hCEX+AdBB +cO5jT8C+L1WGh7eEMpgAC+UESOKfGda1z7fmuL8SG9Yvb+xPesGFO1vibWCV4gFj04FQv cjyz6DFOHH7Lcow0rO3U2rxV0RZirTDha+KpaNW5vsLiS/Flzy9lv9DPvIABiNOEX3XU/a a5HWUA0Is1ea5iT2Nzun1EpYvGkwl6DMElM6EDbTW5wSeOHaPT8QUMCdEGzHofxnS9IZ8o fKsD/NAflLyAHjmZDT9gBjARxJl6+h0B4xrUaQS8JoEDBIxV3mfEb0pzjAEo3Q== X-Migadu-Spam-Score: 4.93 X-Spam-Score: 4.93 X-Migadu-Queue-Id: 2CA311221F Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=gbDt0dDi; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Scanner: scn0.migadu.com X-TUID: jfsiAEQKEBEV Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> The need for this use case appeared when attempting to install Guix on a= truly >> minimal image made with Buildroot, which lacked enough GNU components th= at I >> had to extract a guix pack to /gnu before attempting installation, which= would >> then refuse to proceed because of the existing /gnu. >> >> * etc/guix-install.sh: Document environment variables. >> (sys_create_store) [GUIX_ALLOW_OVERWRITE]: Skip pre-existing installation >> checks and output a warning. Extract the tarball directly to /. > > Like Tobias, I=E2=80=99m reluctant to adding environment variables; I=E2= =80=99m also > skeptical about the use case (I think it=E2=80=99s fine to let users remo= ve > their previous installation if that=E2=80=99s what they want). Removing my previous installation wouldn't have helped (it would have cleared the guix packs I needed to be able to run the installer). Without this change, I wouldn't have been able to install guix using guix-install.sh. It's niche, but I bet it'd help folks trying to install Guix on Alpine and similar minimal OSes. > I also think we=E2=80=99d rather minimize changes to the script since we= =E2=80=99re a > couple of days before the release. The change seems fairly small to me and would be easy to revert if it causes a problem. But I'll let you do the call, given you're the one pushing the release forward (thank you!). --=20 Thanks, Maxim