From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yLL8CiMMo2MYcQEAbAwnHQ (envelope-from ) for ; Wed, 21 Dec 2022 14:37:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WDHkCiMMo2O9awAAauVa8A (envelope-from ) for ; Wed, 21 Dec 2022 14:37:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E1F56D5D7 for ; Wed, 21 Dec 2022 14:37:38 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7zFg-0008D1-PC; Wed, 21 Dec 2022 08:35:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7zFO-00087T-4E for guix-patches@gnu.org; Wed, 21 Dec 2022 08:35:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7zFN-00010C-Qw for guix-patches@gnu.org; Wed, 21 Dec 2022 08:35:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7zFN-0003nt-MD for guix-patches@gnu.org; Wed, 21 Dec 2022 08:35:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60055] [PATCH] scripts: system: Skip initrd modules check when using --target. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Dec 2022 13:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60055 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 60055@debbugs.gnu.org Received: via spool by 60055-submit@debbugs.gnu.org id=B60055.167162969914607 (code B ref 60055); Wed, 21 Dec 2022 13:35:01 +0000 Received: (at 60055) by debbugs.gnu.org; 21 Dec 2022 13:34:59 +0000 Received: from localhost ([127.0.0.1]:51931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7zFL-0003nX-05 for submit@debbugs.gnu.org; Wed, 21 Dec 2022 08:34:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7zFJ-0003nP-E5 for 60055@debbugs.gnu.org; Wed, 21 Dec 2022 08:34:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7zFD-0000xV-Dy; Wed, 21 Dec 2022 08:34:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=EZyJUvDaioA+fld5Xi6eDcsqi+JeVqYg+6WYG1WB1Ng=; b=b3gBJeQsIMznOgqG6+44 uB+v3DO577P+MM7vqQaIgPYGUOI+PFiszEn+XN50CKZiuuXRjsUVlpah3uNfnGemSMkwhoiN07daY +iG+EU6PGB1lBDf5RXjT0kBSOizJVDgGLjUCmqXcBI680j6MDBYRi/JNpEsWJ+95fAGWts4SPbcF6 r8SPbBAmDYrhW4coyyn1DnZUasj6fM82leuu+aXYFhYEzNc9AQF5sp1nFoP7CN+ImJZG+7G929H5h YObpMdmVehImqv91QFxARKS/+MF2Xl/a1aDPhEfspMjlQBgtcLbnsUcQ/7LUf+8O4y8nSFhJ85b8F MFMSJsTo+nMj7Q==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7zFC-0007sP-Un; Wed, 21 Dec 2022 08:34:51 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221214015303.18991-1-maxim.cournoyer@gmail.com> Date: Wed, 21 Dec 2022 14:34:48 +0100 In-Reply-To: <20221214015303.18991-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Tue, 13 Dec 2022 20:53:03 -0500") Message-ID: <87wn6k518n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671629858; a=rsa-sha256; cv=none; b=Oq+/9RvuVxBA7yT5uYgDyCyErLbJKci7dWcYUDjjI8i2SYL0YT74ihnqFHJRhYpvOh8jmA sWhqck1F/nOqMeXk4M4WVvXcwBHhik5Y48t/2qXgPAFvsgTSHLVWzOCAb0DIGNGWG9S4p9 dl9Omnt2Wx4IW2v4ybcyJLaIuI0panFmGc4+ykCdJMymzoKie/5OfKXSh16O52Xg3dJypx hjmJWFNhWsMDzcFYnHGb9GLrMZ7rtDLkSnq3u4te8BpdELEaJ5sMG/ox8aEx52JCjLI2XF KCNobIVybKYyzHqnLWGFTXoSi80hFk8sIGFpRJ5IPnGE5OswulGhrEliCEt/IA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=b3gBJeQs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671629858; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=EZyJUvDaioA+fld5Xi6eDcsqi+JeVqYg+6WYG1WB1Ng=; b=L5BNdu7sWOI/v6BoYFYUS0eexIfFou413brVOCwtXYacLBzIjeoqZWXtQ8X5w/FipHodE6 3ezol4p+FyFe/CpJ671WKEjIYyuXKqAQ60iWt7bBfGpx9ejOgTYgO+mmhK9kDPbgy9q2uP OgWy421k7uuAqSbM/vCfOQQofWHikVtq+LOp6pYumWqhEcnLlf1ni74311Xc8pYQ5MZabZ uis7n7r8PDD5aVXeJE0DwIC6Gjy1dqF1R7Z8oHDYwmaX03BxpDLR1V5q8cVeBzZuUy6rSd KxCGm7sIMMPHGhPS1rVn6siUF85wRWWf1/rsAbC8o5XGKdZAaauTaLQ5AJzJFA== X-Spam-Score: -3.89 X-Migadu-Queue-Id: E1F56D5D7 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=b3gBJeQs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -3.89 X-TUID: MsUMudDeQeIY Hi, Maxim Cournoyer skribis: > * guix/scripts/system.scm (perform-action): Do not call CHECK-INITRD-MODU= LES > when the %current-target-system parameter is set. [...] > + (unless (%current-target-system) > + ;; Skip the check if the user is making use of --target, as it d= oesn't > + ;; make sense in this context. > + (check-initrd-modules os)))) s/doesn=E2=80=99t make sense.*/cannot be checked against the running kernel= ./ Otherwise LGTM, thanks! Ludo=E2=80=99.