[bug#60564] [PATCH] scripts: refresh: Add -T option.

[bug#60564] [PATCH] scripts: refresh: Add -T option.

[jgart via Guix-patches via]

* doc/guix.texi (Invoking guix refresh): Document the -T option.
* guix/scripts/refresh.scm (%options): Add the -T flag.
---
 doc/guix.texi            | 1 +
 guix/scripts/refresh.scm | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 96b4675a01..e3ecf1f148 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -14197,6 +14197,7 @@ for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
+@item --T
 List all the packages which one or more packages depend upon.
 
 @example
diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 6498d73c2b..6b633840e0 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -101,7 +101,7 @@ (define %options
         (option '(#\r "recursive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'recursive? #t result)))
-        (option '("list-transitive") #f #f
+        (option '(#\T "list-transitive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'list-transitive? #t result)))
 
@@ -159,7 +159,7 @@ (define (show-help)
   (display (G_ "
   -r, --recursive        check the PACKAGE and its inputs for upgrades"))
   (display (G_ "
-      --list-transitive  list all the packages that PACKAGE depends on"))
+  -T, --list-transitive  list all the packages that PACKAGE depends on"))
   (newline)
   (display (G_ "
       --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))
-- 
2.38.1

[bug#60564] Probably a lost battle

[Felix Lechner via Guix-patches via]

Hi,

Would the meaning of that option be more accessible to people without a
mathematics background, if it were called

  --list-prerequisites   ?

Kind regards,
Felix Lechner

[bug#60564] [PATCH] scripts: refresh: Add -T option.

[Maxim Cournoyer]

Hi,

jgart <jgart@dismail.de> writes:

> * doc/guix.texi (Invoking guix refresh): Document the -T option.
> * guix/scripts/refresh.scm (%options): Add the -T flag.
> ---
>  doc/guix.texi            | 1 +
>  guix/scripts/refresh.scm | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 96b4675a01..e3ecf1f148 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -14197,6 +14197,7 @@ for compatibility with an upgraded @code{flex} package.
>  @table @code
>  
>  @item --list-transitive
> +@item --T

The above should be -T, right?

I wonder if this option is common enough to need a dedicated short
switch?  I use it sparingly myself; typically I use '-l' to know which
packages I'd impact.

The rest looks OK.

-- 
Thanks,
Maxim

[bug#60564] [PATCH] scripts: refresh: Add -T option.

[Josselin Poiret via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Hi everyone,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> The above should be -T, right?
>
> I wonder if this option is common enough to need a dedicated short
> switch?  I use it sparingly myself; typically I use '-l' to know which
> packages I'd impact.
>
> The rest looks OK.

There hasn't been any activity on this: is this still interesting to you
jgart?  If not, we can probably close this.

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

[bug#60564] [PATCH] scripts: refresh: Add -T option.

[jgart via Guix-patches via]

* doc/guix.texi (Invoking guix refresh): Document the -T option.
* guix/scripts/refresh.scm (%options): Add the -T flag.
---

Hi Josselin and Maxim

> I wonder if this option is common enough to need a dedicated short
> switch?

I would probably use the option more if it had a short option ;()

I think that it is useful. What would be the negative of adding the short option for it?

all best,

jgart

 doc/guix.texi            | 1 +
 guix/scripts/refresh.scm | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 6ff525d0ff..25bbd75f04 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -14327,6 +14327,7 @@ for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
+@item -T
 List all the packages which one or more packages depend upon.
 
 @example
diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 6498d73c2b..6b633840e0 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -101,7 +101,7 @@ (define %options
         (option '(#\r "recursive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'recursive? #t result)))
-        (option '("list-transitive") #f #f
+        (option '(#\T "list-transitive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'list-transitive? #t result)))
 
@@ -159,7 +159,7 @@ (define (show-help)
   (display (G_ "
   -r, --recursive        check the PACKAGE and its inputs for upgrades"))
   (display (G_ "
-      --list-transitive  list all the packages that PACKAGE depends on"))
+  -T, --list-transitive  list all the packages that PACKAGE depends on"))
   (newline)
   (display (G_ "
       --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))
-- 
2.39.1

[bug#60564] [PATCH] scripts: refresh: Add -T option.

[jgart via Guix-patches via]

I forgot to mention that the last patch I sent is v2 fixing the typo that Maxim pointed out.

all best,

jgart

[bug#60564] [PATCH] scripts: refresh: Add -T option.

[Maxim Cournoyer]

Hi jgart,

jgart <jgart@dismail.de> writes:

> * doc/guix.texi (Invoking guix refresh): Document the -T option.
> * guix/scripts/refresh.scm (%options): Add the -T flag.
> ---
>
> Hi Josselin and Maxim
>
>> I wonder if this option is common enough to need a dedicated short
>> switch?
>
> I would probably use the option more if it had a short option ;()
>
> I think that it is useful. What would be the negative of adding the short option for it?

Nothing immediately, but we'd have to honor T forever as it'd be part of
the public CLI, loosing that letter for something more useful that may
yet to appear.

Probably an overblown concern, to be honest, eh.

I'll see what Josselin says about it, otherwise I'll push it soon.

-- 
Thanks,
Maxim

[bug#60564] [PATCH] scripts: refresh: Add -T option.

[Josselin Poiret via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

Hi jgart and Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Nothing immediately, but we'd have to honor T forever as it'd be part of
> the public CLI, loosing that letter for something more useful that may
> yet to appear.
>
> Probably an overblown concern, to be honest, eh.
>
> I'll see what Josselin says about it, otherwise I'll push it soon.

I'm on the fence as well, it doesn't seem like something you would use
very often, compared to eg. `-l` or `-u`, especially if you mention that
you would use the option more often if this was implemented (I'd expect
more of a "I use it all the time but typing it is annoying"). `guix
size` and `guix graph` are the more useful commands imho. What do you
use it for specifically (maybe that would help us understand the
use-case a bit more)?

At the same time, it's probably fine, we don't have many options for
`guix refresh` and it's not like dozens of them will get added overnight
(and they maybe don't deserve a short argument either).  I'll leave it
in your hands 🤠.

Best,
-- 
Josselin Poiret

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]

bug#60564: [PATCH] scripts: refresh: Add -T option.

[Maxim Cournoyer]

Hi,

jgart <jgart@dismail.de> writes:

> * doc/guix.texi (Invoking guix refresh): Document the -T option.
> * guix/scripts/refresh.scm (%options): Add the -T flag.
> ---
>  doc/guix.texi            | 1 +
>  guix/scripts/refresh.scm | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 96b4675a01..e3ecf1f148 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -14197,6 +14197,7 @@ for compatibility with an upgraded @code{flex} package.
>  @table @code
>  
>  @item --list-transitive
> +@item --T
>  List all the packages which one or more packages depend upon.

Fixed to use itemx:

--8<---------------cut here---------------start------------->8---
modified   doc/guix.texi
@@ -14324,7 +14324,7 @@ for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
-@item --T
+@itemx --T
 List all the packages which one or more packages depend upon.
 
 @example
--8<---------------cut here---------------end--------------->8---

>  @example
> diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
> index 6498d73c2b..6b633840e0 100644
> --- a/guix/scripts/refresh.scm
> +++ b/guix/scripts/refresh.scm
> @@ -101,7 +101,7 @@ (define %options
>          (option '(#\r "recursive") #f #f
>                  (lambda (opt name arg result)
>                    (alist-cons 'recursive? #t result)))
> -        (option '("list-transitive") #f #f
> +        (option '(#\T "list-transitive") #f #f
>                  (lambda (opt name arg result)
>                    (alist-cons 'list-transitive? #t result)))
>  
> @@ -159,7 +159,7 @@ (define (show-help)
>    (display (G_ "
>    -r, --recursive        check the PACKAGE and its inputs for upgrades"))
>    (display (G_ "
> -      --list-transitive  list all the packages that PACKAGE depends on"))
> +  -T, --list-transitive  list all the packages that PACKAGE depends on"))
>    (newline)
>    (display (G_ "
>        --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))

And installed it.

-- 
Thanks,
Maxim