From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CLe6NSqZ0GPGgQEAbAwnHQ (envelope-from ) for ; Wed, 25 Jan 2023 03:51:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KHGpNSqZ0GO/YwAA9RJhRA (envelope-from ) for ; Wed, 25 Jan 2023 03:51:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A140F2F37B for ; Wed, 25 Jan 2023 03:51:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKVsN-0007s7-JY; Tue, 24 Jan 2023 21:51:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKVsM-0007qT-IB for guix-patches@gnu.org; Tue, 24 Jan 2023 21:51:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKVsM-0000BJ-Aa for guix-patches@gnu.org; Tue, 24 Jan 2023 21:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKVsL-0003hH-PU for guix-patches@gnu.org; Tue, 24 Jan 2023 21:51:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60976] [PATCH] gnu: Add ditaa. References: <63cb23b3.650a0220.26d15.f66d@mx.google.com> In-Reply-To: <63cb23b3.650a0220.26d15.f66d@mx.google.com> Resent-From: Frank Pursel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 25 Jan 2023 02:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60976 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60976@debbugs.gnu.org Received: via spool by 60976-submit@debbugs.gnu.org id=B60976.167461505714201 (code B ref 60976); Wed, 25 Jan 2023 02:51:01 +0000 Received: (at 60976) by debbugs.gnu.org; 25 Jan 2023 02:50:57 +0000 Received: from localhost ([127.0.0.1]:57963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKVsG-0003gz-Pg for submit@debbugs.gnu.org; Tue, 24 Jan 2023 21:50:57 -0500 Received: from mail-pj1-f48.google.com ([209.85.216.48]:37661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKVsE-0003gl-EU for 60976@debbugs.gnu.org; Tue, 24 Jan 2023 21:50:55 -0500 Received: by mail-pj1-f48.google.com with SMTP id x2-20020a17090a46c200b002295ca9855aso604753pjg.2 for <60976@debbugs.gnu.org>; Tue, 24 Jan 2023 18:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=pMmvyK+HdfhNLr18WzGcrInANgALp2GpIELkeAr2BvY=; b=iTNDYSU7IRnXnylkSh7d8swHbhCDj/y1KFsbvh7Bu5xixBACTuNz0M31Flr03b/QmY WqEFfNjUfVn0xMIytGiqDxaY0rYrMhDIxPBJ3AM+0lTzP7aGqB2BgaS9hb3rjsJSmmBR duLEtgew4/Gncm1OmjjPksK9mQT2SIdoYKzUfS/UAf4yztk1k55fjI64bt7AVN15h4gG dcX1JhKjaR2f3XFZJN+m4w89W3InJ8v6M+0eACjVvKC40IxLx67Xvpt1Qg9cuzVRB6dm QrUV2Sf2CQAq1lbp+sPyOC2SZw6wQrC2NcQ89VtEB+lDvWuNWir9OcSBGatyUdmQtgVw i56g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pMmvyK+HdfhNLr18WzGcrInANgALp2GpIELkeAr2BvY=; b=EzXEmabNUAglHVlGw9wuXLloWNyofZyGjsTowV7tKW3NEMMTfcj3mpxeIEmR5Ar431 niM6wnM5CGE7U2u9LTvzWr8tX4lQ3utMsGn+7VMVCoFEzxAr6+96jTAHI+5Bmx4wxKXj G3lnUez6dY+oNYHjPPEPq2sSY/Qwi9wfhwrgawwQEmdDZomQaG4/FsLS/xbTzFBuEOmp pY6Qwio6om0uTiADguYbyP7j9Hyv+qwjBqgOPWXY8TyCl5ei+8dvIN5s6WSFS2luXybI N8yx+Q8TtnYJ5h0Yp/QnxUdel0+BvXUynSI8T8pXxFCjBsgFsOwAxZYSXsnlvXDL6nx+ /Sgw== X-Gm-Message-State: AFqh2kocfEEwMkKE5YgeIGhkBxkV3uDmZWNM//LUFpJ7GRC1XO4GRSaz dQgu8cLSPUXgy7UK/aZWUytGFp6Fx6M= X-Google-Smtp-Source: AMrXdXubTtKTtbgeBZB5qXHeT2jSfoXDjB+6qRWxq12FW99/socOpye/i2GsLSZ4hRP+2Tpph9ae4Q== X-Received: by 2002:a17:903:2448:b0:192:7845:e0cc with SMTP id l8-20020a170903244800b001927845e0ccmr73602391pls.68.1674615047742; Tue, 24 Jan 2023 18:50:47 -0800 (PST) Received: from Ginko ([66.170.190.211]) by smtp.gmail.com with ESMTPSA id y16-20020a17090264d000b0019335832ee9sm2367582pli.179.2023.01.24.18.50.46 for <60976@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 18:50:47 -0800 (PST) From: Frank Pursel X-Google-Original-From: Frank Pursel Date: Tue, 24 Jan 2023 18:50:45 -0800 Message-ID: <87wn5bxr7e.fsf@Ginko.mail-host-address-is-not-set> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674615082; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pMmvyK+HdfhNLr18WzGcrInANgALp2GpIELkeAr2BvY=; b=GdXwBFAdBgP1z8zmh9dqWjfMwdFX8rirWsp7f+C9vt7o4HXynsyHesLZFgFpwnas+lTyir zRcPHwhwOjn5lii12UMuD4QptVySsf+RcKQysx+0gRhjythpN8E8Rc/Lj5eTklzt67mSY5 ikt5iBH9G9l1Mof0IsH1jjLLDWnRgYzQcodpvJl+Z6yjZdo+Tu6kAgjy3uFGT5IAVv+jji RJc2295ifSoeZkqUb4BRD6O8gC3EKdetn7aScc+DBoQ6oe0Zrln9iwGEEanD15DzIVOiDV QPTtNOHNQr8JNlTsN1TcyHCN06EgLkr/Fc3GVIRDpyFfDxcdB/uLlOs3VwzpKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iTNDYSU7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674615082; a=rsa-sha256; cv=none; b=PceGV5z6T1O95V+eiMJ4C8tdMY8pU8g4hiQYQmm+lv+0NgUT0eat4wXxhBUqvqtg7HP3Qh 49Jltq/Wm7eBjRvR2mx9vgnhonnIAwXvf8bBy0RJPy00vEcHHwBSy4BAYoUyEvXFcXjUky Bw4d3RkCLVJKQBqM9P3nhv0M+eY4HFvcB5FHsyBdn4YFXRCEl5DAVDypOA3iONatmzLXiS ScqxUFqIy7OrzWFi961OnmjtV/4IWJRdfKOxaNPl8aHvRPIO629hrKkJ8cCi55IxX6XMsw 8Yv7FH2CfWUulgd2z376qqaO0l8N970nEcUAd03pfErUY9KheDvvKi2PGZoJBQ== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=iTNDYSU7; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-Migadu-Spam-Score: 7.42 X-Spam-Score: 7.42 X-Migadu-Queue-Id: A140F2F37B X-TUID: 7Qai2t4zwaTV > On Tuesday 24 Jan 2023 at 0435 PST, Simon Tournier wrote: > Why a new file? > Could you split this commit? Basically, each package addition should go > to their own commit. Yes, I puzzled over that too and I think this is the best answer. If you don't admit a new file (for which I don't see great economy) then you must decide what three others you would dilute or adjust to avoid clearly identifying the relationship between these three packages. There seem to be prior examples of small, unique packages of about this size having separate files. Ditaa creates graphics but does not do anything like provide OS level interfaces like in 'graphics.scm'. Similarly, it does not deal with computer science graphs like in 'graph.scm'. It seems to me it is more like curl which stands alone in curl.scm or bison, in bison.scm, cmake, cpio, abiword, and I could go on. While, I know, ditaa is not as fundamental as these other giants it shares that ubiquity. So, I think, ditaa's uniqueness merits that distinction. Together with it's odd dependencies I don't see a better fit but if someone has the courage to positively assert where each of these packages fits I'm completely supportive. > Why not some of the gnu/packages/java-*.scm files? Or gnu/packages/batik.scm Another reason not to want to split this commit is because, per the reference manual, It seemed to me that this was also 'one set of related changes' enabling ditaa. java-libbatik and java-jericho-html are unlikely to be used in support of anything else but cannot be commited separately without breaking ditaa. I also suspect their purpose would quickly become unclear if mixed with other java packages. If there were another application that also built upon the concrete java-libbatik then I think the argument for moving it into batik.scm would be stronger but don't think there is one because batik.scm remains more abstract. I think that is ok. 'batik.scm' is java internally uses an svg api but ditaa leverages svg to produce other than svg output and is independent of java. It is a tool that is likely to be used in non-java environments. > Please provide a comment why the tests are disabled. For example, if > there is no test suite or if upstream does not provide tests, Knowing that ditaa's checks (which depend upon libbatik) was enough for me but I think I can do better. I'll get another patch together to achieve this. Noting that the qa checks on this patch now indicate that this patch is successful (I never take this for granted) does this seem like a good path forward? Regards, Frank