From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KLolB/ZE4GOikwAAbAwnHQ (envelope-from ) for ; Mon, 06 Feb 2023 01:08:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ODoyBvZE4GO4XQAAG6o9tA (envelope-from ) for ; Mon, 06 Feb 2023 01:08:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 649F03B236 for ; Mon, 6 Feb 2023 01:08:21 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOp3D-00057t-MZ; Sun, 05 Feb 2023 19:08:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOp3C-00057K-Pm for guix-patches@gnu.org; Sun, 05 Feb 2023 19:08:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOp3C-0006Gw-E3 for guix-patches@gnu.org; Sun, 05 Feb 2023 19:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOp3C-0006vQ-A0 for guix-patches@gnu.org; Sun, 05 Feb 2023 19:08:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#49946] About migrating support from emacs-tree-sitter to treesit Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Feb 2023 00:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Luis Henrique Gomes Higino Cc: Pierre Langlois , 49946@debbugs.gnu.org Received: via spool by 49946-submit@debbugs.gnu.org id=B49946.167564206926601 (code B ref 49946); Mon, 06 Feb 2023 00:08:02 +0000 Received: (at 49946) by debbugs.gnu.org; 6 Feb 2023 00:07:49 +0000 Received: from localhost ([127.0.0.1]:46739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOp2z-0006uz-FG for submit@debbugs.gnu.org; Sun, 05 Feb 2023 19:07:49 -0500 Received: from mout.gmx.net ([212.227.17.21]:56561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOp2x-0006uk-Kn for 49946@debbugs.gnu.org; Sun, 05 Feb 2023 19:07:48 -0500 Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MwQTF-1oZSuX3NdF-00sOoo; Mon, 06 Feb 2023 01:07:40 +0100 References: <874jsemfcy.fsf@gmail.com> <874js8ewsw.fsf@gmail.com> User-agent: mu4e 1.8.13; emacs 28.2 From: Pierre Langlois Date: Mon, 06 Feb 2023 00:00:41 +0000 In-reply-to: <874js8ewsw.fsf@gmail.com> Message-ID: <87wn4vzmes.fsf@gmx.com> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:/Ly/QUCSXjeQAkj7cL8EPUT/9CPQUMcY/uBvrntmC+0jYNqSSdF LmCgonWX1pEa37/Ne3hsFXow1hhW2b7ZtncZa7O/7iUdyAUIi/plAJQ+JeODgN6Cq8gbjAL A6/MOisu1KxKrfdTeJxlAcQ4CY1+GiqD98+4LIehvxrSl5MU8REpejQ9Quz1muz99Rdsn7z xRwFha4U32/MHm0l3ZVNw== UI-OutboundReport: notjunk:1;M01:P0:LEpGu9j32TY=;dCKiICeQwu45apPtmjdVo6FWdO/ pi3PaJ6ypTZhP8XDLvS/4rtGrCVjeJqlsR6o/DPqYl9lPVmVmCQXpyGwy4QXJyPiHOn1cj4dd y66+kfhKw8FV46kOnniMdqluZJdhTDJJ4FMB3dGRO6raC4zVMA0wSMRF+cCDZRmen9qQ+bcwx SyqDOB0BDYxdFSh1QpEW9ySHKxYW+j66tTiAW4qriqWu9pqSUg6K0v9Rg2jHWlnr9zj5vqGs6 G5o7h+zfXhHm/5wrIyhNm6rUCFA6KH2d3Y3u98axjEnfHXhIE9ZfqHjPOW+uGiUpkUhhLiD3z r1lCmoohAKBdqqZ/y46+Ygk+XL4958bQ9BHcgiY3ARTJ/6x/uue/pfcnXWGTx7Z+o2JlCqbTb ZP9iCCi7AviEbQ5wPPznH8X3Q7F8h6BU2Xs6pkGoMFaGv9pgmO4Iai0H9GZV0z0+FTiCZNK5C BbKfx/MSWvhSjtCgd8M9b3f7MCi0qm7lW7VxECETtulSojdOyT2PXZyVfzEp0NN5wpQnLUf/Q p5d+AYN3vvZV31KSH/dcuymOmFrgRUCrKMXt189Dcyiqzi67qwA5k7PJyUoAKCdYQktPALaa7 EnOOmyln69Nzb25V0oIy/E5yhdWqTR9XW4yhwwVraSdRE676ZzwJk67cCAYP05ZZOQUJPBYFR jkf+9QDFFroUX5izHsEKKtGSKagtXd49SjEB4KUoHSVqR/HZ3kq7yPssK84inPMyzuBSRoPNj kxfZ7Sgn1GZ9B/EnAUuSaCDtywGC/WM3Y2jM4O8NRJbO/ooHmIKKKAYzm8QViTqedIouvoPwW SGbYQGXylXFsa53b798H2N7aqbC9w7t0Ip20t2EJ2QJEdSl3SDXneyQb0VqwPfQvDAs4HriPb GQq5rbh6V/OVXWrdtH5ifjwaFfyxdEnw0+jWwBq0TexNJQgiABCus1f6LMu7Ppha8KHXxETvV YHl+7f1xXopsC63ldvvE+1Mkaho= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675642101; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=gjqwRdGz0mpaNpHU2l739NTR6cpyDWy9LjjHIgpmCPA=; b=BLn353VmXG1qpVjxYTD+iq2om2qvOtH+s5tbX8Z5f96tWIxCopZPQgX+zNK6f1NaX7TMpy vBybWA31tYocBv1LkY4rgBnNnWEUv/9mlLHOIPSDvUySKkqkz0DDMFioTMdreRiecNUf/W 3ya++B0Nmw3Si+NEczgrIy+3kGy2bQ0t/GNQdtrqGV4eV6IN3y+ojaxZenGx7nMATIERmV zOgSGI3c0moqeZUnMh0gV2bKvZiOXnpuDUIOBrRj4C53y2rmEtEiVJk9my6puJ8T8DUTzz DPvrVR4SZl4OYQWeDFZKB0UV0OyBaERirNsjuHC26/pAWJVA0U5Fqbum/nkr4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmx.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675642101; a=rsa-sha256; cv=none; b=BUukckb8nHg+faSVklCt7UFUKcqaV12wJt0KITXNpAOi4kXaCzwWsOA08cpevTzrr79RpM W0zi/N+UBvfjmxlv1dTmtEPQrc4vEMAZgOF8MMDxT4s84p7smmudr2syzpBToj+YJbSwmv A/ni+G+LJdNf78xNHnGU5BVzh10Fai8r3w5YUjWLxEFpk1iQe92MhNwnUrPzWGzoe+S/uv ep3CXNftgIuX1cvOrQ88GrdjvY6rLfiM6cckbTpteToHm3Cqzx8y2+DDmH8B0OG3ZbtuXp l5WqzKp0TA99AcB2ISYsk0wPt3Mnku1Ef55vOu9lBbTSfHiZpe2re9o5FwPjbw== X-Migadu-Spam-Score: -1.89 X-Spam-Score: -1.89 X-Migadu-Queue-Id: 649F03B236 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmx.com (policy=none) X-TUID: LUUls+NnIsMX Hi Luis, Luis Henrique Gomes Higino writes: > Hi guix, > > Luis Henrique Gomes Higino writes: > >> Hi guix, >> >> I was taking a look at this patch series again and wondering if it >> could >> be modified to support the new built in treesit module coming in >> Emacs 29 instead of emacs-tree-sitter, as the latter recommends using >> the native integration going forward [1]. Maybe we should leave this >> to when >> Emacs 29 is released, but I think working on this in advance could >> result on it being delivered earlier, which would be great. What do >> you think Pierre? >> >> [1]: >> https://github.com/emacs-tree-sitter/elisp-tree-sitter/commit/d3eab879e9b0ccc9582113d81a93ad06f3c6bfb1 >> >> PS: I'm willing to help >> >> Regards, > > I played around this idea this weekend and I got `treesit' to use the Guix > installed grammars :) ! > > First, I applied a patch that added tree-sitter as an input for emacs-next > [1]. [1]: https://issues.guix.gnu.org/61139 > > Then, I did the edits below on top of Pierre's latest patch series: This is super cool, thanks for looking into this! and sorry for replying so late. I agree that we should try and get these grammars integrated into emacs as soon as we can, it's the end goal after all (by that I mean that I'm not sure the Rust-based emacs module will live on after emacs 29 is released). But anyways, it's great that you got it working with minimal changes, looks like there won't be any blockers :-). Regarding the patch series, I do have a new version in the pipeline (fixing style and improving testing) but I'm afraid I've had no time to work on it in the past month and a half. I should have more time starting from next weekend. Thanks! Pierre