From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id oIEUOOg3YmRJTAEASxT56A (envelope-from ) for ; Mon, 15 May 2023 15:47:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id EPTwN+g3YmQpWgEAauVa8A (envelope-from ) for ; Mon, 15 May 2023 15:47:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7744118AA for ; Mon, 15 May 2023 15:47:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyYXa-0000KL-4M; Mon, 15 May 2023 09:47:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyYXW-0000Jw-L4 for guix-patches@gnu.org; Mon, 15 May 2023 09:47:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyYXW-0003S0-Cw for guix-patches@gnu.org; Mon, 15 May 2023 09:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyYXW-0007zC-6l for guix-patches@gnu.org; Mon, 15 May 2023 09:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63499] [PATCH gnome-team 1/3] gnu: gst-plugins-base: Fix build. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 15 May 2023 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63499 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: rg@raghavgururajan.name, 63499@debbugs.gnu.org Received: via spool by 63499-submit@debbugs.gnu.org id=B63499.168415841730688 (code B ref 63499); Mon, 15 May 2023 13:47:02 +0000 Received: (at 63499) by debbugs.gnu.org; 15 May 2023 13:46:57 +0000 Received: from localhost ([127.0.0.1]:43020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyYXR-0007yu-5Z for submit@debbugs.gnu.org; Mon, 15 May 2023 09:46:57 -0400 Received: from mail-qv1-f45.google.com ([209.85.219.45]:49288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyYXP-0007yh-Tq for 63499@debbugs.gnu.org; Mon, 15 May 2023 09:46:56 -0400 Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-61aecee26feso57837376d6.2 for <63499@debbugs.gnu.org>; Mon, 15 May 2023 06:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684158410; x=1686750410; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=yCEVTkh3bhqqmhu/k508MGWkwHeWnzIVNpG2zSZW7d8=; b=r6X3RJdp4i40geuChYEnbgz97NwfZem8ELm50bBVsVf5FC+w0b8PZcZxdOYNQ6qOWw 84f1kq6kFWO9TwsNOLbP/3TAHV2BafZ40ugj8iz7O+3grTAfxaywdub3ZRGxQ77gKJ8t 3vX2znceJM21TsbX7DFRjmHlsJWGRTOXPxBLYrTw8fvajdmBsFgtOqlNMURkWZcdNSXD C9eCH/vsXwYZ7i1fQW7Y/KamNy45w0lH4WEvirJpd8is8zj/cMQ2ORNIBCg4tdGJAkDv ref6dCIpe8htT0CefFvTs8bM5DsZoEMTLTnbYnP4dvQU/sNIeFY5UYPrThwacwxxi4oE 2Tjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684158410; x=1686750410; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yCEVTkh3bhqqmhu/k508MGWkwHeWnzIVNpG2zSZW7d8=; b=UaRPglryXR4gFLYkQw3v4k/whCF16iKVVpUvtoTpnVj7zSaJlZ+DzQ9XOxnvvWuMT7 8xInlzCFymzjXZCcoONGn8dN33GIif1Vw/OWRvzk1wxtka+Y5OFXbrYVKD72nO961KZU dWs5Dl/uyEZQzb1GY9ZnK+yTUwCCwqxIP+G9YCENyQx1mh7cTlBUEb7F8Rr5W1JgCOCt qe1uWtnYrnDASzvEE30ISTUWpOEyBhO6SDGuSE5A/P8rz7gC58Wx3X7fT8cNEEu1NDyj 2fBF2ULjsYacN9SoOHfQvXMKCaujBer2OMMSpO6jXt/hCxs1SF0gsM0alKDPgzKkcTSb CHig== X-Gm-Message-State: AC+VfDzqHfIv3gzpb9EoNqCqE/x6gwXi87F+sqUyJTPzwEg052mcLnkX PeNH87etbab8I3ytFASP+8oYcDlU+uQ2wg== X-Google-Smtp-Source: ACHHUZ4xaFxCXmx7Zzs1k3c5IzUuAjSADWDoaGgb+na4olRUoYDcqoJgxnAdqBVkbS541ew34RsIUA== X-Received: by 2002:a05:6214:20a5:b0:620:a1be:c74d with SMTP id 5-20020a05621420a500b00620a1bec74dmr48170322qvd.37.1684158410249; Mon, 15 May 2023 06:46:50 -0700 (PDT) Received: from hurd (dsl-205-236-230-106.b2b2c.ca. [205.236.230.106]) by smtp.gmail.com with ESMTPSA id fi19-20020a0562141a5300b005ff569bca72sm4943242qvb.93.2023.05.15.06.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 06:46:49 -0700 (PDT) From: Maxim Cournoyer References: <2c36d93661d5cf9d3a7c60068571225716f129bd.1684060546.git.liliana.prikler@gmail.com> Date: Mon, 15 May 2023 09:46:48 -0400 In-Reply-To: <2c36d93661d5cf9d3a7c60068571225716f129bd.1684060546.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sun, 16 Apr 2023 07:47:00 +0200") Message-ID: <87wn19vh9z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684158440; a=rsa-sha256; cv=none; b=ZlXrwwOayysZNCawLWEei1pn91Em9a6Dlb9ZSq6uxzTjDVklPxnEev40MYjBPqQa3PgYGz gwLazklAMg36YmveLoIMQA6TyABH4JlehJ4wznKdyVcIt++pEmsdJGekN3oH06GXRbXZP/ WiU9HQzt2Tl/mQ7vpz9CMjC4e9NXtTkQ63HaCmCp0ga2vTonT8wI6SJlJlVT/YQKa66Cnr 5mKAy8Esv1jhAv8GQED8SPhP8tNKUwyZ90iFKd8nyRBLMOCpzQkaP7ma+Nm8ODvkjxg01c lzovq6Kk+W0963b2u0S0q1MJ6dstESMuYhlZ025AcR4XaVBfv1qtD13VMWwJug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=r6X3RJdp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684158440; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=yCEVTkh3bhqqmhu/k508MGWkwHeWnzIVNpG2zSZW7d8=; b=jBx7I6/Fn6Eh4mnX6sMSRyFmc2/Yn7mn/od5/dHcO5VXwiiMNJUzl90uLE17KnQfE1ETsy 1ja//YF1zpyxEX9SyLrOOyV6zA3pu0aFCQFSRv0MYA+Hl3ih5yUB5fSnBqvK+AyQ0Q7VSe fuyLz5zIAcMsEIWkuAjIJZ6+6BOtYaYnucI2V2KBgGJk0i1P5tdIcp+M4Od/CnhQ76HZrA zR24bUO8IKjNegwemm9aZtzU0ei0YZgBWGaAfgjPa/aay541KAV61KsjU7uWucrtAn4Snc UxAa8dRYM9vQQwJRFDdNNpTNvSSex4ambFM1NSP8aXmfXYd5z5S7311N5G3Mog== X-Migadu-Spam-Score: 0.49 X-Spam-Score: 0.49 X-Migadu-Queue-Id: A7744118AA X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=r6X3RJdp; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: 4XcSU56RGJ73 Hi Liliana, Liliana Marie Prikler writes: > * gnu/packages/patches/gst-plugins-base-fix-broken-test.patch: New file. > * gnu/packages/gstreamer.scm (gst-plugins-base)[patches]: Use it here. > * gnu/local.mk (dist_patch_DATA): Register it here. > --- > gnu/local.mk | 1 + > gnu/packages/gstreamer.scm | 3 ++- > .../gst-plugins-base-fix-broken-test.patch | 22 +++++++++++++++++++ > 3 files changed, 25 insertions(+), 1 deletion(-) > create mode 100644 gnu/packages/patches/gst-plugins-base-fix-broken-test.patch > > diff --git a/gnu/local.mk b/gnu/local.mk > index 43d6077943..0ff787e8f3 100644 > --- a/gnu/local.mk > +++ b/gnu/local.mk > @@ -1316,6 +1316,7 @@ dist_patch_DATA = \ > %D%/packages/patches/guile-present-coding.patch \ > %D%/packages/patches/guile-rsvg-pkgconfig.patch \ > %D%/packages/patches/guile-emacs-fix-configure.patch \ > + %D%/packages/patches/gst-plugins-base-fix-broken-test.patch \ > %D%/packages/patches/gtk2-fix-builder-test.patch \ > %D%/packages/patches/gtk2-harden-list-store.patch \ > %D%/packages/patches/gtk2-respect-GUIX_GTK2_PATH.patch \ > diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm > index 8971c11479..f7e5b397fd 100644 > --- a/gnu/packages/gstreamer.scm > +++ b/gnu/packages/gstreamer.scm > @@ -550,7 +550,8 @@ (define-public gst-plugins-base > name "-" version ".tar.xz")) > (sha256 > (base32 > - "0jcxcx4mgfjvfb3ixibwhx8j330mq3ap469w7hapm6z79q614rgb")))) > + "0jcxcx4mgfjvfb3ixibwhx8j330mq3ap469w7hapm6z79q614rgb")) > + (patches (search-patches "gst-plugins-base-fix-broken-test.patch")))) > (build-system meson-build-system) > (propagated-inputs > (list glib ;required by gstreamer-sdp-1.0.pc > diff --git a/gnu/packages/patches/gst-plugins-base-fix-broken-test.patch b/gnu/packages/patches/gst-plugins-base-fix-broken-test.patch > new file mode 100644 > index 0000000000..2785983d8d > --- /dev/null > +++ b/gnu/packages/patches/gst-plugins-base-fix-broken-test.patch > @@ -0,0 +1,22 @@ > +Index: gst-plugins-base-1.22.1/tests/check/libs/allocators.c > +=================================================================== > +--- gst-plugins-base-1.22.1.orig/tests/check/libs/allocators.c > ++++ gst-plugins-base-1.22.1/tests/check/libs/allocators.c > +@@ -80,7 +80,7 @@ GST_START_TEST (test_fdmem) > + > + alloc = gst_fd_allocator_new (); > + fail_unless (alloc); > +- mem = gst_fd_allocator_alloc (alloc, fd, 10, GST_FD_MEMORY_FLAG_KEEP_MAPPED); > ++ mem = gst_fd_allocator_alloc (alloc, fd, 10, GST_FD_MEMORY_FLAG_KEEP_MAPPED | GST_FD_MEMORY_FLAG_DONT_CLOSE); > + > + fail_unless (gst_memory_map (mem, &info, GST_MAP_READ)); > + fail_unless (info.data[5] == '5'); > +@@ -95,7 +95,7 @@ GST_START_TEST (test_fdmem) > + gst_memory_unmap (mem, &info); > + > + gst_memory_unref (mem); > +- fail_unless (g_close (fd, NULL) == 0); > ++ fail_unless (g_close (fd, NULL)); > + gst_object_unref (alloc); > + } > + The patch should be annotated with metadata concerning its origin, with a link to track the status upstream (not yet released upstream patch? custom patch?). If it wasn't reported to upstream, it should be. Thanks! Maxim