From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id UPxGEq8NQWXI2AAAauVa8A:P1 (envelope-from ) for ; Tue, 31 Oct 2023 15:22:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UPxGEq8NQWXI2AAAauVa8A (envelope-from ) for ; Tue, 31 Oct 2023 15:22:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E79AC17F67 for ; Tue, 31 Oct 2023 15:22:38 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=axl+xRIr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1698762159; a=rsa-sha256; cv=none; b=SjA/OT+X0TMsNBcKvoX69Mx2Y33LZiEiAJgPUD1VWDEBAF1uwfafNDFnpEKxG31C5cWayu QvizapH0Dw0HM0OUcZcsjAuMjWs4hKHDyNiy0gXdhombGc9hvQ+fV8UkuUM/91EimSAxoJ QB6M+fk0DIA+GcvxGR07e8o1HS3flraMHBuiTgJpLR0RqLRACT/9gp+72qchx8/dSB/M3Y IUSL3vnTwARovdKHwAVr55XeHiecPJ52fnz38Obn1N4UJw7PzElapFcVzdQlYC0HNL5PwY hdqNt0vA2Ka96NThXvIZ5YEiM01so0VnQ2RdXS/rQUADfkFK/VO0D1COCrD9NQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=axl+xRIr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1698762159; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=DpqZoQ04978WY3g/KyQbvOCYXUFw5ilSVngL2bVrBsU=; b=dGPtdBVygSJ5twMbyByLqTQ9acftH2Vc9eJbjynKUbgZdrXL1tNE500akJUNtPh6LQ0l4/ 1wZjgbUqsT1H7sVZLmBV0lVGtfZj7l7pZjRXyjytMcGzWcDrNSCtzPVKAQMqeC1/VJaTjL 6rx3G6xmWl9dRuqvdtEiQvIaeqaGfJmC7lO5W6ZDbPwuv88GbdjVIwQ+Gb5Gfh6kME8HPN KrTqWzH3WUyaRGiDTIhAyMa1pp829DAVVi0giw0Zpo8GUSQ8WB1CxQt2p3ZhSa7ZnV5S5X zpQJnrT6qQFNgC3NWLYOmDR0mQ2fYju+iI29HKDBqAToGm59Uz3Fhp8rsDwD5A== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxpdW-0003Mm-Eb; Tue, 31 Oct 2023 10:22:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxpdV-0003Ma-Bi for guix-patches@gnu.org; Tue, 31 Oct 2023 10:22:29 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxpdV-0006JD-3j for guix-patches@gnu.org; Tue, 31 Oct 2023 10:22:29 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxpe2-0005pv-7U for guix-patches@gnu.org; Tue, 31 Oct 2023 10:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66823] [PATCH gnome-team 4/4] gnu: Add calls. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 31 Oct 2023 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66823 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vivien Kraus Cc: rg@raghavgururajan.name, liliana.prikler@gmail.com, 66823@debbugs.gnu.org Received: via spool by 66823-submit@debbugs.gnu.org id=B66823.169876213122359 (code B ref 66823); Tue, 31 Oct 2023 14:23:02 +0000 Received: (at 66823) by debbugs.gnu.org; 31 Oct 2023 14:22:11 +0000 Received: from localhost ([127.0.0.1]:48918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxpdC-0005oZ-K3 for submit@debbugs.gnu.org; Tue, 31 Oct 2023 10:22:11 -0400 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:55499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxpdA-0005oM-59 for 66823@debbugs.gnu.org; Tue, 31 Oct 2023 10:22:10 -0400 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3b52360cdf0so2870435b6e.2 for <66823@debbugs.gnu.org>; Tue, 31 Oct 2023 07:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698762088; x=1699366888; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=DpqZoQ04978WY3g/KyQbvOCYXUFw5ilSVngL2bVrBsU=; b=axl+xRIrIOd3bQ+BXUqZTeuYAnDsd2x39OhF7cT2Xf8PUrwUVmhKphNNC016TYiVfx YbOxWpM43AYh6nuOdYZ68MdjMGnQz/wviZ21vEh886mJvAaxyxSx5VjtMYN7yUa63oAi tGGlftBv+/zKgDBpFN0YZvyCzBn8EmxQLlYlAv5mDdS3+QSELIK+lM33ZkSb+ij81xgd 0O/0wVeIobde5uf8Shrb1mUfUYVWNcUrp2Fq7FYHz3nj/gUbXzhDVAT2i12WEKyiulyn rIrGRemESHz8viBiIcaIcVKQK7vB92VDKLBEwxLClF6OZqdNK2dSwtwP9UNvb9hjYsbc xW0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698762088; x=1699366888; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DpqZoQ04978WY3g/KyQbvOCYXUFw5ilSVngL2bVrBsU=; b=J4ivHfOvg1FfZuriyxHfGKKjm2tpM6VvYOE9lkiE9u/zXqFs24FrVguAbKq7JDvIwi SjpyJqogoldILniLWXiWJu95tSs5CPQFmjlC6S7UdR+PjBiiCzLKXeYN1zMdPMQJNIr4 eMcBSFwzqjqKuG84Wjf4/Q5ZibrCtWaKLtSnPdeeOnSv6E9iAXyoRvrXt75wd/lvZ9m4 BOSOU6R4apjsHRJkD9VIGM7Cl3KS6WkF5RxVcHadULggQqDhGWlgRUHhe7QuYsTO9Qhq 3U8/bjECnHiG2CvMQO+4AUZG0FLxKd+51E6rFHeemg3OVZwIkW8vEjdrbHMw5VEi2MGH f2tA== X-Gm-Message-State: AOJu0Yxu9Knl55e3RZ/6qgldxZ0aUmcXHsfTuR46JSwfphNb28jfQqMF ZxWLnHKtR41W/DL/Fq1Jwj8= X-Google-Smtp-Source: AGHT+IEeWgJf2ZuWWQ9aUya9PCXpbPTtZRnAJoIwaRQihdDnChoUNgHh+esAEsocFca1/MxFa+IZEw== X-Received: by 2002:a05:6358:7e0d:b0:169:8e44:1786 with SMTP id o13-20020a0563587e0d00b001698e441786mr1251665rwm.26.1698762088333; Tue, 31 Oct 2023 07:21:28 -0700 (PDT) Received: from hurd (dsl-10-128-239.b2b2c.ca. [72.10.128.239]) by smtp.gmail.com with ESMTPSA id mz8-20020a0562142d0800b0066cf2423c79sm560779qvb.139.2023.10.31.07.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 07:21:27 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <02ab6d7a2efc2d402f967841fcffd8837d28d61a.1698597871.git.vivien@planete-kraus.eu> (Vivien Kraus's message of "Sun, 29 Oct 2023 12:04:57 +0100") References: <02ab6d7a2efc2d402f967841fcffd8837d28d61a.1698597871.git.vivien@planete-kraus.eu> Date: Tue, 31 Oct 2023 10:21:26 -0400 Message-ID: <87wmv2swih.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: E79AC17F67 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -3.51 X-Spam-Score: -3.51 X-TUID: JV8zpDZsy+i3 Hi Vivien, Vivien Kraus writes: > * gnu/packages/gnome.scm (libcallaudio): New variable. > > Change-Id: I6f0485e4c73536c576713005cf7cd74610923a21 > --- > gnu/packages/gnome.scm | 82 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 8092715795..2536b8f98d 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -13463,3 +13463,85 @@ (define-public xffm+ > (home-page "http://xffm.org/") > (license license:gpl3+) > (properties '((upstream-name . "xffm"))))) > + > +(define-public calls > + (package > + (name "calls") > + (version "45.0") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://gnome/sources/" name "/" > + (version-major version) "/" > + name "-" version ".tar.xz")) > + (sha256 > + (base32 > + "1mvnrm5wbl69xbcjg8nxd6l6nj2fd3whbyh70axlm75c7l7d5j5r")))) > + (build-system meson-build-system) > + (arguments > + (list > + #:glib-or-gtk? #t > + #:configure-flags #~'("-Dgtk_doc=true") > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'unpack-gmobile > + (lambda _ > + (copy-recursively > + #$(origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.gnome.org/World/Phosh/libcall-ui") > + (commit "6798b38d4d66d069751151b3e9a202c6de8d7f3c"))) > + (file-name (git-file-name "libcall-ui" version)) > + (sha256 > + (base32 > + "0zfrxh77ag8garqj319amnxjcdyp3ig12dkxfkl6wbwn1mvyrwx8"))) > + "subprojects/libcall-ui"))) > + (add-after 'unpack 'disable-failing-test > + (lambda _ > + ;; 3 tests fail with: Could not create pipeline: Could not create > + ;; 'srtpdec' element of type srtpdec Nitpick: I'd double-quote the error and add a trailing '.'. It'd be nice to understand where this error comes from; e.g. is it because we're not building gstreamer with an optional dependency? > + (substitute* "plugins/provider/tests/meson.build" > + (("^test\\('media'") > + "# test('media'") > + (("^test\\('sip'") > + "# test('sip'")) > + (call-with-output-file "tests/test-application.c" > + (lambda (port) > + (format port "int main(void) { return 0; }"))))) > + (add-before 'check 'pre-check > + (lambda _ > + (setenv "HOME" (getcwd)) > + ;; Tests require a running X server. > + (system "Xvfb :1 &") > + (setenv "DISPLAY" ":1")))))) > + (inputs > + (list evolution-data-server > + feedbackd > + folks > + glib > + gom > + gstreamer > + gst-plugins-base > + gst-plugins-good > + gtk+ > + libgee > + libpeas Same comment as earlier about the @ import hack, but I guess there was a cyclic problem, as something in (gnu packages telephony) is not following the rules laid in (info 'guix (Cyclic Module Dependencies)'). The problem likely stems from the ffmpeg-jami variant that inherits ffmpeg from a different module (these are top level references and *not* delayed). > + (@ (gnu packages telephony) libcallaudio) > + libhandy > + modem-manager > + (@ (gnu packages telephony) sofia-sip))) > + (native-inputs > + (list desktop-file-utils ; update-desktop-database > + gettext-minimal > + `(,glib "bin") ; glib-mkenums > + gtk-doc ; gtkdoc-scan > + `(,gtk+ "bin") ; gtk-update-icon-cache > + pkg-config > + python-docutils ; rst2man Nitpick: Ensure at least 2 leading spaces before a ';' inline comment. I like to use M-; in Emacs to produce those, as it also aligns them. I also don't put a space between the ';' and the *inline* comment. Otherwise, LGTM. I'll be looking forward to try it! -- Thanks, Maxim