all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ian Eure <ian@retrospec.tv>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 68309@debbugs.gnu.org
Subject: [bug#68309] [PATCH 1/2] gnu: Add powertop-service-type.
Date: Sat, 01 Jun 2024 11:18:28 -0700	[thread overview]
Message-ID: <87wmn8tti3.fsf@meson> (raw)
In-Reply-To: <87a5p4jmen.fsf@gnu.org>

Hi Mathieu,

Sorry for the extremely late response on this.

Mathieu Othacehe <othacehe@gnu.org> writes:

> Hey,
>
> Thanks for the v2!
>
>> +The @code{(gnu services pm)} module provides a Guix service 
>> definition
>> +for PowerTOP.  When started, it tunes kernel settings to 
>> reduce power
>> +consumption.
>
> I have this error when building the documentation:
>
> guix.texi:34841: `@end' expected `lisp', but saw `defvar'
>

Fixed in v3, which I just sent.

>> +
>> +\f
>> +
>
> Kill that extra line
>

This matches the style used by every other package in the module, 
so I believe it should stay how it is.

>> +;;;
>> +;;; powertop
>> +;;;
>> +;;; Calls `powertop --auto-tune' to reduce energy consumption.
>> +
>> +
>
> That one too.
>

Done.

>> +   (description "Tune power-related kernel parameters to 
>> reduce energy consumption.")))
>
> Wrap it to be under 78 characters.
>

Done.

  — Ian




  reply	other threads:[~2024-06-01 18:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-07 21:21 [bug#68309] [PATCH] gnu: Add powertop-service-type Ian Eure
2024-01-08  9:10 ` Mathieu Othacehe
2024-01-13 21:23   ` Ian Eure
2024-01-14  0:40 ` [bug#68309] [PATCH 1/2] " Ian Eure
2024-01-14  0:40   ` [bug#68309] [PATCH 2/2] gnu: Correct package description Ian Eure
2024-01-17 10:15   ` [bug#68309] [PATCH 1/2] gnu: Add powertop-service-type Mathieu Othacehe
2024-06-01 18:18     ` Ian Eure [this message]
2024-06-01 18:15 ` [bug#68309] [PATCH v3] " Ian Eure
2024-11-23 15:09   ` bug#68309: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmn8tti3.fsf@meson \
    --to=ian@retrospec.tv \
    --cc=68309@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.