From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id KG0EILbyjWaE3QAAe85BDQ:P1 (envelope-from ) for ; Wed, 10 Jul 2024 02:32:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id KG0EILbyjWaE3QAAe85BDQ (envelope-from ) for ; Wed, 10 Jul 2024 04:32:22 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="GTzM2/0R"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1720578742; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=jfJ4jjAIoYXGwnNspp9xebqCA5Knon9q7GbpAKRfx+c=; b=H42NObq3mEI8cHa2pzyA8sgRDdM+MqnKarBHcyO6F/MkexieLE3Iw5pddev9bdE9dg7AZN PBMASI8G1tWBrEkETBc/9f5cnhUJbSEhUzMA4jSAXPzUyTF59MkCVs8IoM/xnwYAw3CRAj qzOxF7qMAFh6HEx/NW66aipVoZb0LyM0AtMKOJFSXzWpDv+9LyEejadNYZTKMQrvHPYjR2 Su0DZ3i70zkC4gJyYOr1cBnlYTQoPNK5haP26+kBYW45fwd8ij0euItwmSrE2lT+jj/xiQ iR1vPe6mDG9tiBDrTU6rbvhX2ASaf+9EcsDWCOGMk1tnEX5YLdI4BLTwTrwBFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1720578742; a=rsa-sha256; cv=none; b=jv5z0safs/20XcL/yYW8FgSAJzN/evh/IKFE4fj9+yU/FQGn6AuGocGMQB9k0ly5ADbG6v 0c6GxcNTBWUOo0qoIPAdx7e2Kk97TI8cPFwL/hF71g4p37IvqvkY/41L3jmyWrNGPWLWU7 YOSIawjfbEQp+HDVZSiswQ4z3+CKPrVrJdR6DaXVAPAkEmYsImihpVIs/lygpCauv0/Tts I5kKNcMUQZC3Da3CgmUBTo0eVsz6S7uY3J1iHx5kYCjeU5pSUdWLZZNKisXBezXka50PJ3 hFoe03SAIShRFzND6l3KjV2H5V/YhG1H6r2h5qSzhH2PpSYqpMOqZ88N5g2CMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="GTzM2/0R"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 207136BF22 for ; Wed, 10 Jul 2024 04:32:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRN7f-0006qf-9j; Tue, 09 Jul 2024 22:31:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRN7d-0006kY-Lf for guix-patches@gnu.org; Tue, 09 Jul 2024 22:31:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRN7d-00032j-Ct for guix-patches@gnu.org; Tue, 09 Jul 2024 22:31:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRN7i-0006cL-6P for guix-patches@gnu.org; Tue, 09 Jul 2024 22:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70880] [PATCH v2 6/8] gnu: Add prusa-libbgcode. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 10 Jul 2024 02:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: "Artyom V. Poptsov" Cc: 70880@debbugs.gnu.org Received: via spool by 70880-submit@debbugs.gnu.org id=B70880.172057870225406 (code B ref 70880); Wed, 10 Jul 2024 02:32:02 +0000 Received: (at 70880) by debbugs.gnu.org; 10 Jul 2024 02:31:42 +0000 Received: from localhost ([127.0.0.1]:54564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRN7O-0006bh-3v for submit@debbugs.gnu.org; Tue, 09 Jul 2024 22:31:42 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:42023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRN7L-0006bQ-O7 for 70880@debbugs.gnu.org; Tue, 09 Jul 2024 22:31:40 -0400 Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-447e2d719afso2997851cf.0 for <70880@debbugs.gnu.org>; Tue, 09 Jul 2024 19:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720578627; x=1721183427; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=jfJ4jjAIoYXGwnNspp9xebqCA5Knon9q7GbpAKRfx+c=; b=GTzM2/0R7gyfw/rEiikji3S/XWXEnpF0YhzeQaMbHt6ORhEykORuVwSqlM9ntC14tJ UqYaE7SyYsv5fdsIVXBCyKSVY/kmui0SpX734aWUnx0xpZwoh9ZSE/Y+1aiK12h3q1CA wsbqA7fpRqJcdWaLvDfqKqljh1k4FzHBMROM8n4+672sAaKRLmjUp+GpbbO6bKh+fYzE o8ZsmGSTw9RYn5vmjgfyGdJllITyayRfHuieu2vOlvW3aaTmDUYLBS9FxmUUWVLWOISm v4xQXbgqeWevsVLN2n0W1Q8V5kjdEnJ8l43YDisT+Yp87Evg7VNj+0UkzPZxYyGxzZrJ TaFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720578627; x=1721183427; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jfJ4jjAIoYXGwnNspp9xebqCA5Knon9q7GbpAKRfx+c=; b=KXN/jftvkuwXGaEudWta7iRNtI4O/kucecCCj3CUVM4j7Q5cP49ISJWhSAyxCYDK+0 Yx6ewbm3H8Ox/RYFyHPkR3EHsQy5AdEXubbmbENPYRvNN0vfiAufLfdclck5ZOFQ8pDt /vNQIIqWWXfoXgnbhHzNlBCcuCprtyRpL3DqY24EEHhjT8gepWUldaa/rJ0kFnnwhURv u1BSceJGZC22ath4Y07cewVbPBkPV7GNCIBOsEMRm4OyOemVkM0TpAdyv0oSbVCTSZhV tXIWaxRBNHaf/0jU1U22esucjp9LMHYt7s4bIw+OLXM9Et2Lp1yDJOQkvMnIL4WcNxxQ CrtA== X-Gm-Message-State: AOJu0YzT0yjynYuHjtE6Z6an5ZVQIn2L0RmcJc2/3xIleNs+Sw5nF1/X zTSwxl8hdE3/4V4JxxAiSZVoj1GeLQX8X2+98OtRJmNhlh+Gq+NUGGu9vw== X-Google-Smtp-Source: AGHT+IGSzoTRRmeylj6k2lt6M1bQNPbintZN7doYh/XaNjRME31y0hj9r4mEvAqloiFEihwNUy5HwA== X-Received: by 2002:ac8:5fd3:0:b0:447:f891:1e72 with SMTP id d75a77b69052e-447fc3b976bmr78145931cf.15.1720578627212; Tue, 09 Jul 2024 19:30:27 -0700 (PDT) Received: from hurd (dsl-205-236-230-124.b2b2c.ca. [205.236.230.124]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-447f9b2818esm16123341cf.10.2024.07.09.19.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 19:30:26 -0700 (PDT) From: Maxim Cournoyer In-Reply-To: <2cdedc4189efac291f16e099b91605a8f8f4aca9.1719853592.git.poptsov.artyom@gmail.com> (Artyom V. Poptsov's message of "Mon, 1 Jul 2024 20:07:08 +0300") References: <2cdedc4189efac291f16e099b91605a8f8f4aca9.1719853592.git.poptsov.artyom@gmail.com> Date: Tue, 09 Jul 2024 22:30:25 -0400 Message-ID: <87wmluugfy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 207136BF22 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -5.30 X-Spam-Score: -5.30 X-TUID: n8BzqgDf8mUt Hi, "Artyom V. Poptsov" writes: > * gnu/packages/engineering.scm (prusa-libbgcode): New variable. > > Change-Id: I1f18c399d0fe36987c613ce4c0c3845c803beb45 > --- > gnu/packages/engineering.scm | 46 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm > index 7f29e2c365..de4b4a5825 100644 > --- a/gnu/packages/engineering.scm > +++ b/gnu/packages/engineering.scm > @@ -3753,6 +3753,52 @@ (define-public libigl > visualization, matrix manipulation.") > (license (list license:gpl3 license:mpl2.0)))) > > +(define-public prusa-libbgcode Sorry for missing that in my first review: there should be an explanatory comment here mentioning which commit to use and why (e.g.: "Use the latest commit since there are no proper releases nor tags.") > + (let ((commit "8ae75bd0eea622f0e34cae311b3bd065b55eae9b") > + (revision "0")) > + (package > + (name "prusa-libbgcode") > + (version (git-version "0.0.0" revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/prusa3d/libbgcode") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 (base32 "0fjx2ijz9zqpqs486lcrrrhqvmfzrpb8j6v57l0jiynavwv3kznw")))) > + (native-inputs (list catch2)) > + (propagated-inputs > + (list zlib boost heatshrink)) Nitpick: when there are few inputs (< 5), it's OK to list them inline if it fits the 80 columns rule, like: (propagated-inputs (list zlib boost heatshrink)) I think this is what 'guix style' would do. > + (build-system cmake-build-system) > + (home-page "https://github.com/prusa3d/libbgcode") > + (synopsis "Prusa Block and Binary G-code reader/writer/converter") > + (description > + "Binary G-code is a new standard for encoding and compressing ASCII G-code > +files. G-code files are easy to read and interpret, but their downside is that the > +data is not saved efficiently, and the file size is often very large. Compression of > +the file is problematic because the printers usually run on limited hardware and they > +may not have enough memory and/or CPU power to decompress it. > + > +Block and Binary G-Code is a new G-code file format featuring the following > +improvements over the legacy G-code: > +@itemize > +@item Block structure with distinct blocks for metadata vs. G-code. > +@item Faster navigation. > +@item Coding and compression for smaller file size. > +@item Checksum for data validity. > +@item Extensibility through new (custom) blocks. For example, a file signature block > +may be welcome by corporate customers. > +@end itemize > + > +The binary G-code format is flexible and the encoding and compression of individual > +blocks is variable. @code{libbgcode} library contains the routines to convert ASCII ^ The @code{libgcode} ... > +G-codes to binary and vice versa. The library is written in C++ and the repository > +includes bindings for Python.") It looks like this package does not provide the Python bindings, so it may be best to drop that part of the last sentence mentioning their existence, as it would be misleading for Guix users. -- Thanks, Maxim