From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id KPvDGM+EUGfCVgAA62LTzQ:P1 (envelope-from ) for ; Wed, 04 Dec 2024 16:35:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id KPvDGM+EUGfCVgAA62LTzQ (envelope-from ) for ; Wed, 04 Dec 2024 17:35:27 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Cq7ES6Ip; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IgXaCwnB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733330126; a=rsa-sha256; cv=none; b=qyRgL4SZhjQiLUXQYWfQHfVM0en9O2/DkOXz9dl50ThvazCHdX1TrVEJjAwZ768mM7+cYF pTVewADM/QBPfT/q6rOW82T14CkajPSQ3H9lqJIil84zlRjGvj6h/wNjupE+H9JfNN6jkQ 1o/r64geyrtC2AlzNpy7YFchUu16vIJyHwgNThEhYF1n+Aap//fS+beiHxiZbZWESKmhba 22UDSWiZwaABrjivxj7xH0RVG/4z3W/I2JUzqSb/bTH++uw1RjSXUuYmsrYFd0ObXUftgT ASBw95QDbc5w0ODITJ3tav8WyXSmlQgdO6CjWG3AEGPrvywEkN49FdT/OCoVzw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=Cq7ES6Ip; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=IgXaCwnB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733330126; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=svpcnAQYuDSjWjaMlt56LkDuJG8xGyH/WLicuaS0K4E=; b=jvPdP/v0bIO9cqmujOP/6BbF1+bN+JpAKEou7/k17xQfq/N63bQJtJX9GQP91+ZH56wfoa 5UFRG8NsyOFnPajGJsN/W35oUWsG9PqB/n1VTmLcye9qT5auR2Z2qUWxGqwSA1YhqHh/9q QBSYLV7+Qsz0Qgp04HRt5mcjgu4NeM7ta0z2sz7oiumIc8/5NgKZ8ehNsJnhgjQH7JacmQ UsEnSwq41Ne/QNF3qrYSxfQiPhH3QAsQfKOjH40O+BoW2EwbFJ7mULo87T9ge1DPcRI/0G 1OWHsaaBLnxShz0fV1SevJY4ADAZ/3dUkoaB1KxnYfRdFk/tlyz/lU/MiLukWA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2FC747B34B for ; Wed, 04 Dec 2024 17:35:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIsLL-0001JZ-FD; Wed, 04 Dec 2024 11:35:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIsLJ-0001Gj-IT for guix-patches@gnu.org; Wed, 04 Dec 2024 11:35:13 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIsL8-0007jy-4O for guix-patches@gnu.org; Wed, 04 Dec 2024 11:35:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=svpcnAQYuDSjWjaMlt56LkDuJG8xGyH/WLicuaS0K4E=; b=Cq7ES6IpOJ8/sopDPjRU9TqWyLYTMQpXVDjpEVP/oXFG7ZHp18LY3mjxB/hshjGNVMOzBew1UYn4bozu7IEz/XZifs3mrXcgpAjHuAt1gpvlRkeH3VThNwJx39pvdZqTQv7XSUB2PWHDnVIvALNNKDCYkNqn7APcoboyZKtCuAMZiTWWgtBex/fzbulfYwJep1TabI52wrovag+6w9wczW8PD6tDnvgW1rRKzVzZbSn3tvZ/iywPNv/PrOhw5m/WAUhQEt4WjKt6HrORbz872tQX3ImkyYS+JkE/FNlPNxitpo2dqmspF0DrlWkztyyNo7uqCjxfw7g/cjMtSsi/wQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIsL7-0002Rd-Uc for guix-patches@gnu.org; Wed, 04 Dec 2024 11:35:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74654] [PATCH 2/5] packages: Optimize =?UTF-8?Q?=E2=80=98all-packages=E2=80=99.?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Dec 2024 16:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74654 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: David Elsing Cc: 74654@debbugs.gnu.org Received: via spool by 74654-submit@debbugs.gnu.org id=B74654.17333300539312 (code B ref 74654); Wed, 04 Dec 2024 16:35:01 +0000 Received: (at 74654) by debbugs.gnu.org; 4 Dec 2024 16:34:13 +0000 Received: from localhost ([127.0.0.1]:36506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIsKK-0002Q7-SX for submit@debbugs.gnu.org; Wed, 04 Dec 2024 11:34:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIsKH-0002Pf-BX for 74654@debbugs.gnu.org; Wed, 04 Dec 2024 11:34:10 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIsKB-0007SE-2b; Wed, 04 Dec 2024 11:34:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=svpcnAQYuDSjWjaMlt56LkDuJG8xGyH/WLicuaS0K4E=; b=IgXaCwnBFm7XaidrJYGf mJczWf8DxEGGgkyq5OMsY/kOlIoJ7vDiUpTVAORufg4MPDB1ILmql0To44Hd5CLvnnq/cm6OX1b5t lhOKCfHMKSX0Vs5yULdGl5AIpSWmNWhD5Vepahi9gzCzpQA4iU5mFbWzpi7/grQECWPtSh+nffqo4 Pjj20MR+Ur3EVhY7NWgct+Z4aZu81ToTscDpeXqfX8bW+3+2PujiXHT34Gy7/qBDdIeeKNfFTYIQM X7dws7ubn2S9QLcjcCAXvaoS5uNdkjgadVxPxryTfPxvhBI2DG4u+2jzEDW8d/6B+UQnKQY1CtyPT K0dU8eEZzHmo/g==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <7ywmghr6jf.fsf@posteo.net> (David Elsing's message of "Mon, 02 Dec 2024 23:47:48 +0000") References: <642880c208f4445f1d63dba5618a315671d558e2.1733158049.git.ludo@gnu.org> <7ywmghr6jf.fsf@posteo.net> Date: Wed, 04 Dec 2024 17:34:01 +0100 Message-ID: <87wmgfwgp2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.33 X-Spam-Score: -4.33 X-Migadu-Queue-Id: 2FC747B34B X-Migadu-Scanner: mx10.migadu.com X-TUID: SaqIoXaEA6Ic Hello, David Elsing skribis: > Ludovic Court=C3=A8s writes: > >> On my laptop, wall-clock time for (all-packages) goes from 27s to 1s. >> >> * gnu/packages.scm (all-packages): Use a hash table to remember visited >> packages instead of calling =E2=80=98delete-duplicates=E2=80=99 on the f= inal list. > > Thanks for fixing this, commit 4b5dae8 also made > `guix graph -t reverse-package` much slower, because `delete-duplicates` > had not been used in the old `all-packages` procedure before. I wanted > to make a patch, but then saw your series already. :) Yes, my bad! I tried to take the common denominator of all the =E2=80=98all-packages=E2=80=99 procedures, and here=E2=80=99s what happens.= :-) Ludo=E2=80=99.