Re: [PATCH] gnu: Add glibc-hurd-headers

[ludo@gnu.org (Ludovic Courtès)]

Manolis Ragkousis <manolis837@gmail.com> skribis:

> Take notice that it needs the patch "glibc-make-4.0.patch" for the
> configure check to pass. I should bring up this issue to the hurd
> guys.

That’s a sign that the Hurd’s libc should be rebased on top of libc 2.19.

> +(define-public glibc/hurd-headers
> +  (package (inherit glibc)
> +           (name "glibc-hurd-headers")

The indentation is wrong (see this file for examples.)

> +           (arguments
> +            (substitute-keyword-arguments
> +                `(#:strip-binaries? #f
> +                  #:out-of-source? #t
> +                  #:tests? #f 
> +                  #:configure-flags (list 
> +                                     "--host=i686-pc-gnu"
> +                                     "--enable-addons"
> +                                     ;;"--disable-sanity-checks"
> +                                     (string-append "libc_cv_localedir="
> +                                                    (assoc-ref %outputs "locales")
> +                                                    "/share/locale")
> +                                     (string-append "--with-headers="
> +                                                    (assoc-ref %build-inputs "gnumach-headers")
> +                                                    "/include:"
> +                                                    (assoc-ref %build-inputs "hurd-headers")
> +                                                    "/include")
> +                                     
> +                                     ;; Use our Bash instead of /bin/sh.
> +                                     (string-append "BASH_SHELL="
> +                                                    (assoc-ref %build-inputs "bash")
> +                                                    "/bin/bash"))
> +                  ,@(package-arguments glibc))
> +              ((#:phases phases)
> +               `(alist-replace
> +                 'install
> +                 (lambda _
> +                   (zero? (system* "make" "install-headers")))
> +                 (alist-delete
> +                 'build
> +                 ,phases)))))))

This looks good to me, but unnecessarily complex: get rid of
‘substitute-keyword-arguments’:

  (arguments
    '(#:out-of-source? #t
      #:tests? #f
      #:configure-flags ...
      #:phases (alist-replace ... %standard-phases)))

HTH,
Ludo’.